Received-SPF: pass (google.com: domain of linux-kernel+bounces-147347-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 16 Apr 2024 11:05:09 -0700
From: "H. Peter Anvin" <hpa@zytor.com>
To: Borislav Petkov <bp@alien8.de>, "Xin Li (Intel)" <xin@zytor.com>
CC: linux-kernel@vger.kernel.org, luto@kernel.org, tglx@linutronix.de,
        mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org
Subject: Re: [PATCH v1 1/1] x86/fred: Fix int80 emulation for FRED
User-Agent: K-9 Mail for Android
In-Reply-To: <20240416101147.GDZh5O473e4X_ZG1lZ@fat_crate.local>
References: <20240412234058.1106744-1-xin@zytor.com> <20240416101147.GDZh5O473e4X_ZG1lZ@fat_crate.local>
Message-ID: <1AE9FA53-A130-4F95-8408-C1990DD031AA@zytor.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable

On April 16, 2024 3:11:47 AM PDT, Borislav Petkov <bp@alien8=2Ede> wrote:
>On Fri, Apr 12, 2024 at 04:40:58PM -0700, Xin Li (Intel) wrote:
>> Commit 55617fb991df
>
>Use the full commit abbreviation when mentioning commits:
>
>"Commit
>
>  55617fb991df ("x86/entry: Do not allow external 0x80 interrupts")
>
>=2E=2E=2E"
>
>> added a bunch of tests to the int $0x80 path,
>
>Added a bunch of tests?
>
>What does that even mean?
>
>> however they are unnecessary and event wrong in fact under FRED=2E
>
>Are the bunch of tests wrong or is do_int80_emulation() simply the wrong
>handler to use on a FRED?
>
>> First FRED distinguishes external interrupts from software interrupts,
>> thus int80_emulation() should NEVER be called for handling an external
>> interrupt, and then int80_is_external() should be skipped under FRED=2E
>>=20
>> Second, the FRED kernel entry handler NEVER dispatches INTx, which is
>> of event type EVENT_TYPE_SWINT, so the user mode checking in
>> do_int80_emulation() is redundant, and should be skipped=2E
>>=20
>> It might be even better to strip down do_int80_emulation() to a lean
>> fred_int80_emulation(), not to mention int80_emulation() does a
>> CLEAR_BRANCH_HISTORY=2E
>
>Yah, how about you do a FRED-specific INT80 handler instead of
>sprinkling moar tests around? fred_intx() looks like the right place to
>stuff it in=2E=2E=2E
>

The question was if you wanted a quick fix for x86/urgent=2E It's pretty o=
bvious that a FRED fork of the int80 code is called for=2E