Received-SPF: pass (google.com: domain of linux-kernel+bounces-147348-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 16 Apr 2024 11:06:21 -0700
From: Charlie Jenkins <charlie@rivosinc.com>
To: Zhao Ke <ke.zhao@shingroup.cn>
Cc: paul.walmsley@sifive.com, aou@eecs.berkeley.edu,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	dawei.li@shingroup.cn, shenghui.qu@shingroup.cn
Subject: Re: [PATCH] Use bool value in set_cpu_online()
Message-ID: <Zh6+HZnsgh9ncvPj@ghost>
References: <20240318065404.123668-1-ke.zhao@shingroup.cn>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240318065404.123668-1-ke.zhao@shingroup.cn>

On Mon, Mar 18, 2024 at 02:54:04PM +0800, Zhao Ke wrote:
> The declaration of set_cpu_online() takes a bool value. So replace
> int here to make it consistent with the declaration.
> 
> Signed-off-by: Zhao Ke <ke.zhao@shingroup.cn>
> ---
>  arch/riscv/kernel/smpboot.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/riscv/kernel/smpboot.c b/arch/riscv/kernel/smpboot.c
> index 519b6bd946e5..3f7c274653ab 100644
> --- a/arch/riscv/kernel/smpboot.c
> +++ b/arch/riscv/kernel/smpboot.c
> @@ -229,7 +229,7 @@ asmlinkage __visible void smp_callin(void)
>  	riscv_ipi_enable();
>  
>  	numa_add_cpu(curr_cpuid);
> -	set_cpu_online(curr_cpuid, 1);
> +	set_cpu_online(curr_cpuid, true);
>  
>  	if (has_vector()) {
>  		if (riscv_v_setup_vsize())
> -- 
> 2.34.1
> 
> 
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv

Thank you!

Reviewed-by: Charlie Jenkins <charlie@rivosinc.com>