Received-SPF: pass (google.com: domain of linux-kernel+bounces-147353-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <2474f02c-c835-4691-b531-62c8c747aede@linux.ibm.com>
Date: Tue, 16 Apr 2024 13:09:04 -0500
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 25/31] i2c: fsi: Calculate clock divider from local bus
 frequency
To: Andi Shyti <andi.shyti@kernel.org>
Cc: linux-fsi@lists.ozlabs.org, linux-kernel@vger.kernel.org,
        linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
        alistair@popple.id.au, joel@jms.id.au, jk@ozlabs.org, robh@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        lakshmiy@us.ibmcom
References: <20240226165321.91976-1-eajames@linux.ibm.com>
 <20240226165321.91976-26-eajames@linux.ibm.com>
 <q6bl7sbskt4ukd3mylfgwpo6dmv444umdpycs6xp7ozd2kv335@syeymu62fczb>
Content-Language: en-US
From: Eddie James <eajames@linux.ibm.com>
In-Reply-To: <q6bl7sbskt4ukd3mylfgwpo6dmv444umdpycs6xp7ozd2kv335@syeymu62fczb>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 4/15/24 17:11, Andi Shyti wrote:
> Hi Eddie,
>
>> @@ -689,6 +692,20 @@ static int fsi_i2c_probe(struct device *dev)
>>   	mutex_init(&i2c->lock);
>>   	i2c->fsi = to_fsi_dev(dev);
>>   	INIT_LIST_HEAD(&i2c->ports);
>> +	i2c->clock_div = I2C_DEFAULT_CLK_DIV;
>> +
>> +	lbus = fsi_device_local_bus_frequency(i2c->fsi);
>> +	if (lbus) {
>> +		u32 clock = I2C_DEFAULT_CLK_RATE;
> I don't see the need for initialization.


Does device_property_read_u32 set clock if the property isn't found? If 
not, it needs to be initialized here. Or I can set it in an else 
statement from device_property_read_u32.


>
>> +
>> +		if (!device_property_read_u32(dev, "clock-frequency", &clock)) {
>> +			if (!clock)
>> +				clock = I2C_DEFAULT_CLK_RATE;
>> +		}
> no need for brackets.


Perhaps not, but checkpatch didn't complain, and I personally like 
brackets if multiple lines are included.


>
>> +
>> +		// i2c clock rate = local bus clock / (4 * (i2c clock div + 1))
> You forgot to remove this.


I actually meant to leave that comment to explain how the clock rate is 
calculated, as the reverse calculation in the code is a little more 
confusing.


>
> Andi
>
>> +		i2c->clock_div = (((lbus + (clock - 1)) / clock) / 4) - 1;
>> +	}
>>   
>>   	rc = fsi_i2c_dev_init(i2c);
>>   	if (rc)
>> -- 
>> 2.39.3
>>