Received: by 2002:a05:6500:1b45:b0:1f5:f2ab:c469 with SMTP id cz5csp158413lqb; Tue, 16 Apr 2024 11:32:29 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWSDybhRC8SJLN3UT0+0CCA8UYTEF9vKv4EcQ20SQoVv0o1nJoMxamMJhgSmqn5+CstD7rYMlsLCH+C2k4GQd+E/7ttOOcjn9p8p0pvtw== X-Google-Smtp-Source: AGHT+IFe7Wvl7xNnHYWa+DhB44T8rLoG2amd+SH7Hdauvq4tfHKzipgZqJ6zfSAdRlZ36oMybw5t X-Received: by 2002:ad4:4c07:0:b0:699:3a42:4a18 with SMTP id bz7-20020ad44c07000000b006993a424a18mr14335836qvb.31.1713292349529; Tue, 16 Apr 2024 11:32:29 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713292349; cv=pass; d=google.com; s=arc-20160816; b=MQ1ZHnc/MSmp6BvUqza513x2lIufGmEZAQMoPgAqmfnOE3MObKZTS/HXOXn+Lvev+1 ZcBH3/BALAdqSNTmfSd2/jx/GX/zzx3KwTZNiQdZbSpP1pOutnA+NnkkZmTKwYJMLQ6f Tj3rg2IoiQvrknbCvBKW0hI0hpZdB/+BcU/b4TS3SozNZHeBV0+GyAHtg5DwLzlhI+ua tXfE6F3yS6gh6nS7QG2x45cMPkDcGG8b1v7Fp1KbyAi2A7rpmGomd/6BwlL2LgrYXzJ9 T+Q0eYz4RjgKjTfMYnPAPGDHtT/eed226/25CckivAquYol/DWIAZId8UVtRwkxYxcVD GdCQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:user-agent:date :message-id:organization:from:references:cc:to:subject; bh=xlC1wHRuuo+Ah31ZZo1iT/qsJ4kjg9UrajkpCyKMuUY=; fh=GBedYRe8CV9CODBtz6d2uYhENEWIwOxDoGyCIhAV7GM=; b=amPTgGfFU2UA3PhQ+sCIgvMopZFwaWhZz0fK8HbcGt4cUWPSx/0lB8/3cpnn+w6Hs8 /pwm7UDj4TLpbJEv3XrO6V5LDbwNpZidLRfTBG3NVcQ1O0I1Kg5A43GdzZsSHPJ0pPLb BIYMRe/+8mGdmOcI8MUTwUEYMpub1lJxX16FPPKS/4WXqYJwvMGk6m1uxwXjV/RiIlXz I/+33+aNZBjqUyMsAdBxrB38rXARhswduS6rXTNuhAAJzgMW2/xQdaCw0SGUuT0ZUpj/ 6tqYAlZnN8eUfkV0YmpNiEcnzJtqIaRyQPqQlkQvvP3rG72oF9QjIKIjUI11gvAYz7CB KwQg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=omp.ru); spf=pass (google.com: domain of linux-kernel+bounces-147391-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-147391-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id ee9-20020a0562140a4900b00698725f3baesi12777793qvb.153.2024.04.16.11.32.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 11:32:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-147391-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=omp.ru); spf=pass (google.com: domain of linux-kernel+bounces-147391-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-147391-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id C28761C226FE for ; Tue, 16 Apr 2024 18:32:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CD58C136E3F; Tue, 16 Apr 2024 18:32:19 +0000 (UTC) Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B987D1CF8A; Tue, 16 Apr 2024 18:32:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.154.21.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713292339; cv=none; b=YBNLWC1KkjGqzbumpFQEUBkl3uubafDxKyfVebAUhgSvVMvaahWx3u8isNsnmFymeIk3D6Jjg8cFo5OIKdtg9WG0I5PLNJcrOjFQvtvurThIsx47Xpp/vEOifbCm30ZIOjT/Nmb81UF4/MBd7a4aw2R6tX8ZT3AjlvkBcS7TErQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713292339; c=relaxed/simple; bh=A9E5PowJNlwkdjjlmnNiS/tKUzmTL4S0WybXnAWFDNI=; h=Subject:To:CC:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=L/rjWjGBiEw+cqY+5x1AI3/NOABsSeAU9jfYJeI+jUg3W63Sd/r0/UmY0qzEmRq2Mjsx6fsHaAcBKvt0/JO5V9lbKgsuz2ajhcV0Hk+C2IGyULqsNc1huN0OG7pAacMwYcev9bbsF+FJKR+T3tWRGwHWBVpohJ7vdXgsx/Flf68= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru; spf=pass smtp.mailfrom=omp.ru; arc=none smtp.client-ip=90.154.21.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=omp.ru Received: from [192.168.1.105] (31.173.81.200) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1258.12; Tue, 16 Apr 2024 21:32:13 +0300 Subject: Re: [PATCH 1/3] media: tuners: tda18271: fix error code handling in tda18271_attach() To: Roman Smirnov , Michael Krufky , Mauro Carvalho Chehab , Jia-Ju Bai , Hans Verkuil CC: , , References: <20240416114509.198069-1-r.smirnov@omp.ru> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: <625d9a00-7509-83b1-0f16-c2a24291e84e@omp.ru> Date: Tue, 16 Apr 2024 21:32:13 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20240416114509.198069-1-r.smirnov@omp.ru> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 6.1.0, Database issued on: 04/16/2024 18:12:36 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 0 X-KSE-AntiSpam-Info: Lua profiles 184744 [Apr 16 2024] X-KSE-AntiSpam-Info: Version: 6.1.0.4 X-KSE-AntiSpam-Info: Envelope from: s.shtylyov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 17 0.3.17 f2153f38d75b12894d9cf445f96cd15c9ef63a9d X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: 127.0.0.199:7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;omp.ru:7.1.1 X-KSE-AntiSpam-Info: ApMailHostAddress: 31.173.81.200 X-KSE-AntiSpam-Info: Rate: 0 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 04/16/2024 18:16:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 4/16/2024 4:06:00 PM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit On 4/16/24 2:45 PM, Roman Smirnov wrote: > tda18271_attach() uses the hybrid_tuner_request_state() macro. > It may return the error code -ENOMEM, but the function handle > the value 0 instead. > > Found by Linux Verification Center (linuxtesting.org) with Svace. > > Fixes: b9302fa7ed97 ("media: tuners: fix error return code of hybrid_tuner_request_state()") > Signed-off-by: Roman Smirnov Reviewed-by: Sergey Shtylyov [...] MBR, Sergey