Received-SPF: pass (google.com: domain of linux-kernel+bounces-147392-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <5a8557e3-4289-4d6b-90d6-5bb23a636f66@zytor.com>
Date: Tue, 16 Apr 2024 11:33:30 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 1/1] x86/fred: Fix INT80 emulation for FRED
Content-Language: en-US
To: Borislav Petkov <bp@alien8.de>
Cc: "Xin Li (Intel)" <xin@zytor.com>, linux-kernel@vger.kernel.org,
        luto@kernel.org, tglx@linutronix.de, mingo@redhat.com,
        dave.hansen@linux.intel.com, x86@kernel.org
References: <20240416175804.3328999-1-xin@zytor.com>
 <ece31eca-37bc-4b39-9fc9-7e6fda741729@zytor.com>
 <20240416182803.GIZh7DMyPNHphpa9JA@fat_crate.local>
From: "H. Peter Anvin" <hpa@zytor.com>
In-Reply-To: <20240416182803.GIZh7DMyPNHphpa9JA@fat_crate.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 4/16/24 11:28, Borislav Petkov wrote:
> On Tue, Apr 16, 2024 at 11:23:24AM -0700, H. Peter Anvin wrote:
>> (I think there is actually less than half the code left. This could be
>> further cleaned up by inlining the common code,
> 
> Yeah, was just thinking about that too. I'd say, though, let's let the
> FRED code settle, we start using it and then we can always unify common
> stuff later if it turns out that it won't diverge anymore.

Good plan.

>> but if I were still maintainer I would not want that for x86/urgent.
>> This patch has the very nice property for x86/urgent purposes that it
>> doesn't touch non-FRED code at all.)
> 
> Right.

:)

> I'd let Xin work in all those comments and then I'll pick it up.

Thanks!

	-hpa