Received: by 2002:a05:6500:1b45:b0:1f5:f2ab:c469 with SMTP id cz5csp168758lqb; Tue, 16 Apr 2024 11:54:04 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWde2hlIXq+zecgVLzLEjxYZ05oJalwMFQPCYcFG96CgrQgJ/3it54WdEC2qtJGe7HlJ0aODoo+K0oJQBCjy7sOuC27GmT0YA5orYdd9A== X-Google-Smtp-Source: AGHT+IHHa3tFzIelN5pTsjOa5xjPr2qA1POk4lQtOI/Ro1z8U3n0xZL0SFjm1J5Jzc8UfxjErTr/ X-Received: by 2002:a0c:db01:0:b0:69b:47d1:456b with SMTP id d1-20020a0cdb01000000b0069b47d1456bmr13675533qvk.7.1713293644654; Tue, 16 Apr 2024 11:54:04 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713293644; cv=pass; d=google.com; s=arc-20160816; b=fz4MYCu6PjKmCPkfCQ+L8SokraR9cvPaxSXHubKerHRnTP/vNveQsbnB/uN7szarEr kmYwvOfTJmYSAYdx3LH5TvGCIf6CjbjlH/GrOXnQ74kJNdMCK47TxyozZKU8DIKU6DD9 ay47i3bcK03wNSVg1WM5tnhXj7UtksPyyH7X5HeW3DPkC0HpSdZ+UPSn2nkgMQXH60zp 04HGYImfMPLG2j7jvHYGGSS+zzbakiAl9HHUlwXjHVZgzp5OStmHHDDTB9vXQv7nLCcL P2ixKk4Sx0vBeiJ3lWpIzw7o1XLY661muuA75LnWBf/yQeMqThGl83n1Ly08yJ4ncUbC CNkg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=fqBn3lZQTZ2jBdb2hM90KT2R+E3hO1iD8Cd/HZfhMbE=; fh=5i8AaVz4y77q98nJ2c2zzfDyyzySUeX7aHzbBQL3eg4=; b=a0Np7ZyDUDUEF8YAowkVHJliItdQ69OUbgfSEFKVRQxi09DPpnJBN5Sy5hVYAeTyYx Slv4owg49JDoMaT4TTl/7UM0uZXnzzhoUQ9EFv2mu/6f/ncW3EVrl0/hhSm0jMBhN53S k+V7wBVhR+qbgeJacWe50HCiWKkPfszXUJcrleUI4Q8XFK8MVV6ghaysM9gz4QbZN+KE obj1wOieG6RA26yhBVED6iGw/hs8Mw1utUEcKJhMnxhIEscDJRGUhKR8BtdDiqVynUVQ NTYsEXRC/UIKjHoZlgGib0moIuhKgbK6eOH8fAiqSgUpRhQf5Prn+5nIIhx9rRkGcgVB 0xPA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=Kl9ZtWxL; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-147426-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-147426-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id q2-20020ad45ca2000000b0069902184208si14887370qvh.265.2024.04.16.11.54.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 11:54:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-147426-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=Kl9ZtWxL; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-147426-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-147426-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 4CBB01C21943 for ; Tue, 16 Apr 2024 18:54:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B3CFA1386D5; Tue, 16 Apr 2024 18:51:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="Kl9ZtWxL" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4B48137C26; Tue, 16 Apr 2024 18:51:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713293475; cv=none; b=Ezera1T9exkxHuHIQwXEntyFPRIUHvdRDNM7JW6wUikT3d8JCw9TOkbr215YkBFe0cvkzOrG09sd4bZyKMmEfYLrO83f0/jLoAeNt9dp3ta1bOS6MbGSLZpy6g29BZ+tZzBc47JC2b60+OUzGUgo8OKkVU3bUOTPNXMglr9zRzc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713293475; c=relaxed/simple; bh=Tb/H+4YgFd51hFSuhrwmFRYeEJAYFHRd90KcANVm3cw=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=fjWim0Lc5AyNM5dztmFFF5rlF/t1k55GlXTXV4iYv05oi/JrVa7daqEzpoWxX5lgS8wTnwSvN1RDKYAMZTTLjW+IEC/5tyxJkEy7s5w/CRrqmNigxnhAq803gzLSSYhtvG8pHvQwOseGObU99/NkG2l4xZofChgbQHoHt8wvZ/I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=Kl9ZtWxL; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44F65C113CE; Tue, 16 Apr 2024 18:51:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1713293475; bh=Tb/H+4YgFd51hFSuhrwmFRYeEJAYFHRd90KcANVm3cw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Kl9ZtWxL+gLv41LGOBtWYoQCosg4WXkp8I02rcJXgYbuGdJzlSYtJPWtMpLnQiJ2S K5mNaSwdh8aJPfFz12MgnIMpwB3uXA8/oGYHfmAeWwPxXAFJSPf+IDI5Q5u2NIMXXV 3LJY0TBQ3u0u1ZIDOOg3qVPXcVv/gimqaAcdjNWg= Date: Tue, 16 Apr 2024 11:51:14 -0700 From: Andrew Morton To: Stephen Rothwell Cc: Qiang Zhang , Linux Kernel Mailing List , Linux Next Mailing List Subject: Re: linux-next: build warning after merge of the mm-hotfixes tree Message-Id: <20240416115114.8f1673a2490d31f77d276a41@linux-foundation.org> In-Reply-To: <20240416173525.13bfd8dc@canb.auug.org.au> References: <20240416173525.13bfd8dc@canb.auug.org.au> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 16 Apr 2024 17:35:25 +1000 Stephen Rothwell wrote: > Hi all, > > After merging the mm-hotfixes tree, today's linux-next build (htmldocs) > produced this warning: > > lib/bootconfig.c:911: warning: Function parameter or struct member 'early' not described in '_xbc_exit' > lib/bootconfig.c:911: warning: expecting prototype for xbc_exit(). Prototype was for _xbc_exit() instead > > Introduced by commit > > aaeda6237dec ("bootconfig: use memblock_free_late to free xbc memory to buddy") > > from the mm-hotfixes-unstable branch of the mm-hotfixes tree. Thanks. How's this? --- a/lib/bootconfig.c~bootconfig-use-memblock_free_late-to-free-xbc-memory-to-buddy-fix +++ a/lib/bootconfig.c @@ -901,7 +901,8 @@ static int __init xbc_parse_tree(void) } /** - * xbc_exit() - Clean up all parsed bootconfig + * _xbc_exit() - Clean up all parsed bootconfig + * @early: in early xbc init error * * This clears all data structures of parsed bootconfig on memory. * If you need to reuse xbc_init() with new boot config, you can _