Received-SPF: pass (google.com: domain of linux-kernel+bounces-147434-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <91e70916-d86a-450e-8cf7-a083fc25d665@oracle.com>
Date: Tue, 16 Apr 2024 11:58:47 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] slub: limit number of slabs to scan in count_partial()
To: Vlastimil Babka <vbabka@suse.cz>,
        "Christoph Lameter (Ampere)" <cl@linux.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "penberg@kernel.org" <penberg@kernel.org>,
        "rientjes@google.com" <rientjes@google.com>,
        "iamjoonsoo.kim@lge.com" <iamjoonsoo.kim@lge.com>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        Junxiao Bi <junxiao.bi@oracle.com>
References: <20240411164023.99368-1-jianfeng.w.wang@oracle.com>
 <e0222219-eb2d-5e1e-81e1-548eeb5f73e0@linux.com>
 <38ef26aa-169b-48ad-81ad-8378e7a38f25@suse.cz>
 <a8e208fb-7842-4bca-9d2d-3aae21da030c@oracle.com>
 <1207c5d7-8bb7-4574-b811-0cd5f7eaf33d@suse.cz>
 <e348dfcd-6944-4500-bf84-c58b8c2e657f@oracle.com>
 <5552D041-8549-4E76-B3EC-03C76C117077@oracle.com>
 <567ed01c-f0f5-45ee-9711-cc5719ee7666@suse.cz>
Content-Language: en-US
From: Jianfeng Wang <jianfeng.w.wang@oracle.com>
In-Reply-To: <567ed01c-f0f5-45ee-9711-cc5719ee7666@suse.cz>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?Z1IrSVZGR0V6bjAzSVR5MEpCWk5DQXoyYU56d3ExY0Eza2QyakRxeGc1SkdO?=
 =?utf-8?B?dlNoN00zdEZwYWZ0RlVRbE0xRS9TeHBIc1ljd3pGKzFMR3JkRjI3YzgzWjhO?=
 =?utf-8?B?RUticG1Oczh0MGFLYkdlNFFWN2N2RCtHenQxWE1yZHpDV1pkMG5EY0N0dUdY?=
 =?utf-8?B?TjRLVlI5V080NFdCanY5UHEzQzNWWG1TOVVTSi9oMkdnUDZQREt6d1g3Y2M4?=
 =?utf-8?B?dTRoNXVramEvUFBlb1BPZXJKQkRjR0JkZUs4UVJSbHl2bnJTaEcvbG9WV2lY?=
 =?utf-8?B?dDBMNXNwcmdQZmt0T2RNQmxaZ2F6K3o0QzlBTldYeWc5VHBQbE04U2p3WVc5?=
 =?utf-8?B?ak5KbTRDSzlEK3FZZEtnTFRaTlNFcjd6dW16RTlwdHRZVFFENmdDVFd0bnRH?=
 =?utf-8?B?TXBQUWFrQk50cE9JUy9NQnZralhPbWdyY1dOTlQ5SmpNZ0pnYjN1WEdkME1K?=
 =?utf-8?B?L0NtUE92UjFtVnMwQlFHd0trNjV3UGN4SGRKaU1TRm9GVFdQMzUzalJJMkdB?=
 =?utf-8?B?R1N6dEk5KzQwckNncWdiSDI3R1ZpVzJUa1hodm9aZ3RiV0szNzdEM0Viell2?=
 =?utf-8?B?d1VTRzZ0TnEyZ05CcGlNVDlLS3NtVnVTU0V1K0pNNkNjZ0wzYnRzWVRRL2M5?=
 =?utf-8?B?TzZKL2VkM2hpS2pwc2dCdWRMdTRtbmxwVDcxdS9kWC9kSzVOejdLOHovekVO?=
 =?utf-8?B?NWhLc1ZYdWpPbkIvMzFqMFNLaFhDVXgzdTdiaGVqd2sxejR0NWk3Mk9RcWRG?=
 =?utf-8?B?UjJDRVVyc095RW1rNXU2TkJTRWJ2YjltT0svQ2VPUmlxcDZ6M0dkOXpuNjk5?=
 =?utf-8?B?RUtJaEY2c014a1Y3bkpnNEx3czRrTzkzaWlrRHoxWTBVNmlaQ0VVZzNSb3I4?=
 =?utf-8?B?OUhjbnY4T2Z4bnJnUUQzQlBPT2dad1MvSW4rdFpzaDg5b1M0dFRtMFBLOURE?=
 =?utf-8?B?U2J0UjYxSEVQNjhKTW13VjJLdmdlREpOa3JERXgrRXJISC9pMXBlZHZQL1ds?=
 =?utf-8?B?aTNDelU0ejBQbU0xOHg4ZVB2RVBWOFFOMm5DR3R3RFRIRU1NeWZWZDZRUnUv?=
 =?utf-8?B?NVdrUHNRQ1hPZEdlandZa3VxdXhURlhlSWV5Y3RwNmovY1RpOThyS0RhZnBa?=
 =?utf-8?B?OE55azRYMy9XY0tZREdTUlVvZi9rN2lpTitqS1VWeVpzTVlOeURxdUIvSmEx?=
 =?utf-8?B?UHZRQjduWC9Wc3VubU1lOFBLMklFOXJhdWdQVDdSYnRlWkZYbXR4YXQyUjJC?=
 =?utf-8?B?VXo5WDJTL3hUUDUxK3AwVGcwVzZTdUg2WWtRSzh1YXhPajlHck0rcHc2bU9i?=
 =?utf-8?B?STkyRGNZYWVPZzE2V2Q3TzhnQ2NCUjhTT1JWNExzcyt4dDFiWHVnVEwyWWFC?=
 =?utf-8?B?VzdsYVlNMTJOWitCRVZ5bW81ZWFYTUNsUXBwMTlxeVpvemZBUlhwSUY5SWRI?=
 =?utf-8?B?dE1YejN6ZlZiTFBGMXV5VWVJZzRBNzFvUVBpTWdxT2J6K2tCdG41b1V1ZjdS?=
 =?utf-8?B?SGl3MElLRmR1NjM1WGRobzNzWkNHTU9zdnVJSHBrSXNrc25IeklJSGtVa3o4?=
 =?utf-8?B?MndnanFTRWVzVXc1VnBuMWdlTkhJNE5HaldxSThyeXgxMFlRdmtmaTFZdGRm?=
 =?utf-8?B?Q1B0MGprNmsxeVB1a2JvM3pWQ0ZuQkxLeEZ4WGNkSTEyUms2MnFqMTZIelIz?=
 =?utf-8?B?V1h3dnUzS3Q4QmdXMmhHZk1ORWtoTHprMm5KSitBaXUvYU1lS0piQmRES1NP?=
 =?utf-8?B?RnRDUGhPNDkrN2tRbFlFY2xMemJtVmYzNTlDbWovOE5pRzhzRFo2L0VwTjdl?=
 =?utf-8?B?NDFYbTZPR3hYREd2T2Q5a0NYazl6VjVDWmlCTExsU21BT0dsclRGTzdFazdv?=
 =?utf-8?B?WGp2bDAwL3VtVEpSbzdldVBkNVBpNTlyNkxiNzIzNWVoR0RwZ2RHUG91VHZB?=
 =?utf-8?B?dks1eUtXYWZZRk9zQVVoTnk1bDh5SmduSkRQOTVIcmxDZ1ZKbVV0UDB2SzlK?=
 =?utf-8?B?YUhVUE41TnhEQ3ZJa3c0VHRGR3pxbkZ2RGZ6aExteWNqaTR0QnROdzdFRWpS?=
 =?utf-8?B?blpJZi9iUmZBdkIvQjd3OVpGd2EwTEt3RStUaG0vS0NuZEFNSC9SRDFuMlR5?=
 =?utf-8?B?OEQ3bWFzNmZCVEpHOWNoZDNsekVGQmw0VDVZQU5pOUpUcWY4aFVwNWxKdGNn?=
 =?utf-8?B?d1E9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	x8pAiZgyspYgtX8pjpAAIAGuA0NP7s8Kbw/BIROBmkd+ZQkrqCdwLVHn9sT+kdfZLiTWZ5blfQna5COLrB2w7RnSxdBl75rOySn5S4gUQiGvK5KW4OjCP4HUrUkvJC60R6oFSyL+vpKmTiU3MciYYJ3IIhBWM69OfW+3EkZO+Fi4lYoYgP5jLwwsmPRjk/3c+jfu2c7MIuCQSYx7yyNF89TKiy6APdqJZoEkBZ1vYe6Qp9Oi+X8mF0w8mlCufObCCmtg38itf894NKJs++bhVycSSG0WxRoKv/CwhfRv+dtdaD+pb0sRHLmvUFqffyC2oWImMyJxItVu2gyfq9ZBNYB5DHvwaT5fb9XGD9RD2o820E2ukx+AzMnyl6EwH2ugXO9ga7D1tz6ESW+fAr8EdaviXZh+gID1MK4AtkW8EpUTTgUBPvARDP3QuJcF5REdnEh4u106x/U0J0Hw3A3zLn7zaHvXfR2dQYyOg0B8ih/YAp8q78k1ldSwtOVCu57k+r4OIQtVwhfTeqeXRl4Kkph3bJdbkUuMYC/BIPEF8KAXb3eFw4t831WL24hQe63ixAvEKDuXBdEwDba1yVEAm2bvpDQqIrrzwVZCVfOkKgg=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3c422c47-ffa9-4095-9daf-08dc5e47408c
X-MS-Exchange-CrossTenant-AuthSource: PH7PR10MB6379.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2024 18:58:49.9907
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8BJnAV0nVkwgAVroCya+nshwlAt2y/hxETtr4WINEIO/XMe8g0FKAM/bFTbixaWVohG+GfL3niO+9pkCHCTQdINjzawCaByU16gR0qM+4fU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4656
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-16_16,2024-04-16_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 mlxlogscore=999
 suspectscore=0 adultscore=0 phishscore=0 bulkscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000
 definitions=main-2404160120
X-Proofpoint-GUID: 16miysIs9uLKa8SjjG_DFwgORCioSTNl
X-Proofpoint-ORIG-GUID: 16miysIs9uLKa8SjjG_DFwgORCioSTNl


On 4/15/24 12:35 AM, Vlastimil Babka wrote:
> On 4/13/24 3:17 AM, Jianfeng Wang wrote:
>>
>>> On Apr 12, 2024, at 1:44 PM, Jianfeng Wang <jianfeng.w.wang@oracle.com> wrote:
>>>
>>> On 4/12/24 1:20 PM, Vlastimil Babka wrote:
>>>> On 4/12/24 7:29 PM, Jianfeng Wang wrote:
>>>>>
>>>>> On 4/12/24 12:48 AM, Vlastimil Babka wrote:
>>>>>> On 4/11/24 7:02 PM, Christoph Lameter (Ampere) wrote:
>>>>>>> On Thu, 11 Apr 2024, Jianfeng Wang wrote:
>>>>>>>
>>>>>>>> So, the fix is to limit the number of slabs to scan in
>>>>>>>> count_partial(), and output an approximated result if the list is too
>>>>>>>> long. Default to 10000 which should be enough for most sane cases.
>>>>>>>
>>>>>>>
>>>>>>> That is a creative approach. The problem though is that objects on the 
>>>>>>> partial lists are kind of sorted. The partial slabs with only a few 
>>>>>>> objects available are at the start of the list so that allocations cause 
>>>>>>> them to be removed from the partial list fast. Full slabs do not need to 
>>>>>>> be tracked on any list.
>>>>>>>
>>>>>>> The partial slabs with few objects are put at the end of the partial list 
>>>>>>> in the hope that the few objects remaining will also be freed which would 
>>>>>>> allow the freeing of the slab folio.
>>>>>>>
>>>>>>> So the object density may be higher at the beginning of the list.
>>>>>>>
>>>>>>> kmem_cache_shrink() will explicitly sort the partial lists to put the 
>>>>>>> partial pages in that order.
>>>>>>>
>>
>> Realized that I’d do "echo 1 > /sys/kernel/slab/dentry/shrink” to sort the list explicitly.
>> After that, the numbers become:
>> N = 10000 -> diff = 7.1 %
>> N = 20000 -> diff = 5.7 %
>> N = 25000 -> diff = 5.4 %
>> So, expecting ~5-7% difference after shrinking.
>>
>>>>>>> Can you run some tests showing the difference between the estimation and 
>>>>>>> the real count?
>>>>>
>>>>> Yes.
>>>>> On a server with one NUMA node, I create a case that uses many dentry objects.
>>>>
>>>> Could you describe in more detail how do you make dentry cache to grow such
>>>> a large partial slabs list? Thanks.
>>>>
>>>
>>> I utilized the fact that creating a folder will create a new dentry object;
>>> deleting a folder will delete all its sub-folder's dentry objects.
>>>
>>> Then, I started to create N folders, while each folder has M empty sub-folders.
>>> Assuming that these operations would consume a large number of dentry
>>> objects in the sequential order. Their slabs were very likely to be full slabs.
>>> After all folders were created, I deleted a subset of the N folders (i.e.,
>>> one out of every two folders). This would create many holes, which turned a
>>> subset of full slabs into partial slabs.
> 
> Thanks, right, so that's quite a deterministic way to achieve the long
> partial lists with very close to uniform ratio of free/used, so no wonder
> the resulting accuracy is good and the diff is very small. But in practice
> the workloads that may lead to long lists will not be so uniform. The result
> after shrinking shows what happens if there's bias in which slabs we inspect
> due to the sorting. But still most of the slabs will have the near-uniform
> free/used ratio so the sorting will not do so much difference. But another
> workload might do that.
> 
> So what happens if you inspect X slabs from the head and X from the tail as
> I suggested? That should help your test case even after you sort, and also
> should in theory be more accurate even for less uniform workloads.

Yes, the approach of counting from both directions and then approximating
works better after sorting the partial list.

Here is what I did.
---
+static unsigned long count_partial(struct kmem_cache_node *n,
+                                       int (*get_count)(struct slab *))
+{
+       unsigned long flags;
+       unsigned long x = 0;
+       unsigned long scanned = 0;
+       struct slab *slab;
+
+       spin_lock_irqsave(&n->list_lock, flags);
+       list_for_each_entry(slab, &n->partial, slab_list) {
+               x += get_count(slab);
+               if (++scanned > MAX_PARTIAL_TO_SCAN)
+                       break;
+       }
+
+       if (scanned > max_partial_to_scan) {
+               scanned = 0;
+               list_for_each_entry_reverse(slab, &n->partial, slab_list) {
+                       x += get_count(slab);
+                       if (++scanned > MAX_PARTIAL_TO_SCAN) {
+                               /* Approximate total count of objects */
+                               x = mult_frac(x, n->nr_partial, scanned * 2);
+                               x = min(x, node_nr_objs(n));
+                               break;
+                       }
+               }
+       }
+       spin_unlock_irqrestore(&n->list_lock, flags);
+       return x;
+}
---

Results:
---
* Pre-shrink:
MAX_SLAB_TO_SCAN | Diff (single-direction) | Diff (double-direction) | 
1000             | 0.43  %                 | 0.80   %                |
5000             | 0.06  %                 | 0.16   %                |
10000            | 0.02  %                 | -0.003 %                |
20000            | 0.009 %                 | 0.03   %                |

* After-shrink:
MAX_SLAB_TO_SCAN | Diff (single-direction) | Diff (double-direction) | 
1000             | 12.46 %                 | 3.60   %                |
5000             | 5.38  %                 | 0.22   %                |
10000            | 4.99  %                 | -0.06  %                |
20000            | 4.86  %                 | -0.17  %                |
---

For |MAX_SLAB_TO_SCAN| >= 5000, count_partial() returns the exact
object count if the length of the partial list is not larger than
|MAX_SLAB_TO_SCAN|. Otherwise, it counts |MAX_SLAB_TO_SCAN| from both
the head and from the tail, and outputs an approximation that shows
<1% difference.

With a slightly larger limit (like 10000), count_partial() should
produce the exact number for most cases (that won't lead to a
lockup) and avoid lockups with a good estimate.