Received-SPF: pass (google.com: domain of linux-kernel+bounces-147445-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <cover.1713234515.git.albanhuang@tencent.com> <4e68f5557ad53b671ca8103e572163eca52a8f29.1713234515.git.albanhuang@tencent.com>
In-Reply-To: <4e68f5557ad53b671ca8103e572163eca52a8f29.1713234515.git.albanhuang@tencent.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Tue, 16 Apr 2024 21:05:42 +0200
Message-ID: <CAJZ5v0ikW4o4g-yt5SnUFvKfLS6q1tGQ+3NTOfVPvwp7hZ3t2g@mail.gmail.com>
Subject: Re: [PATCH v8 1/3] PNP: Add dev_is_pnp() macro
To: Guanbing Huang <albanhuang0@gmail.com>
Cc: gregkh@linuxfoundation.org, andriy.shevchenko@intel.com, 
	rafael.j.wysocki@intel.com, linux-acpi@vger.kernel.org, tony@atomide.com, 
	john.ogness@linutronix.de, yangyicong@hisilicon.com, jirislaby@kernel.org, 
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, 
	lvjianmin@loongson.cn, albanhuang@tencent.com, tombinfan@tencent.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 16, 2024 at 5:16=E2=80=AFAM Guanbing Huang <albanhuang0@gmail.c=
om> wrote:
>
> From: Guanbing Huang <albanhuang@tencent.com>
>
> Add dev_is_pnp() macro to determine whether the device is a PNP device.
>
> Signed-off-by: Guanbing Huang <albanhuang@tencent.com>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> Reviewed-by: Bing Fan <tombinfan@tencent.com>
> Tested-by: Linheng Du <dylanlhdu@tencent.com>

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

and please feel free to route it along with the rest of the series.

Thanks!

> ---
> v7 -> v8: delete a "Reviewed-by" tag, delete a "Reported-by" tag
> v6 -> v7: add a "Reviewed-by" tag and a "Reported-by" tag, fix build erro=
rs when CONFIG_PNP is not enabled
> v5 -> v6: fix the issue that the cover letter is not chained with the pat=
ch series
> v4 -> v5: change "pnp" in the commit message to uppercase
>
>  include/linux/pnp.h | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/include/linux/pnp.h b/include/linux/pnp.h
> index ddbe7c3ca4ce..82561242cda4 100644
> --- a/include/linux/pnp.h
> +++ b/include/linux/pnp.h
> @@ -469,6 +469,8 @@ int compare_pnp_id(struct pnp_id *pos, const char *id=
);
>  int pnp_register_driver(struct pnp_driver *drv);
>  void pnp_unregister_driver(struct pnp_driver *drv);
>
> +#define dev_is_pnp(d) ((d)->bus =3D=3D &pnp_bus_type)
> +
>  #else
>
>  /* device management */
> @@ -500,6 +502,8 @@ static inline int compare_pnp_id(struct pnp_id *pos, =
const char *id) { return -E
>  static inline int pnp_register_driver(struct pnp_driver *drv) { return -=
ENODEV; }
>  static inline void pnp_unregister_driver(struct pnp_driver *drv) { }
>
> +#define dev_is_pnp(d) false
> +
>  #endif /* CONFIG_PNP */
>
>  /**
> --