Received: by 2002:a05:6500:1b45:b0:1f5:f2ab:c469 with SMTP id cz5csp175772lqb; Tue, 16 Apr 2024 12:06:22 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUPtCJQMKMCJKigisIlLBfoIJKX2yPKsOo1DYvHSYO1HUlTsYDl86HVTID6KA0WLSxNaTXy019Ex2E8Z+i+g8+uOcts2Tr5b5c59SD2iQ== X-Google-Smtp-Source: AGHT+IFvNBY55Hy5SxniVxiEWLBiWCca1NmyTaVAlguGl1mQ7IbyWyT7H+Sq86RtTNLyhUwOCQ5Y X-Received: by 2002:a05:6870:c086:b0:21f:aba0:772d with SMTP id c6-20020a056870c08600b0021faba0772dmr17029163oad.39.1713294382358; Tue, 16 Apr 2024 12:06:22 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713294382; cv=pass; d=google.com; s=arc-20160816; b=vZ/8d5zSKGbKr3yAYCUqP/98Wa5o7JAtjfltImuBCpAFLTemtkmHpTY9ZxDhnY50LV IX3eiK8k7/+CTDu4fAFlifSk18+EMFXWtaCB2jmSak1XCsKLIX5hu7SqbEsmu+Z4IPQI xNtVWHm7aQIcCco4Ze6BAabIZkikz1PrvE/d6nXMYnlzMBZXEjaiFDV0WbHVAfpA5fbo mo0mBK5rTQ1lRlUWS/rLlO9wzzpRW93BrglaUkB2+P6190CJ9oelCYcRvpj8wtacUYUq nRwSXmnaFROsd7pPAIuVdUfHhqxAXq6pt3oa+tG/k2XlK7X/2k8zyuYpq3pnPJrUAq41 MeSw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:user-agent:date :message-id:organization:from:references:cc:to:subject; bh=Bzjm41XxvwWH39lQxhLvmnzJRjP7AaRup6AEGKverHI=; fh=CQlUdf1mN+tuDdLG5ara4OmyNvx+jdR2h2Ksv1XtR0g=; b=zqRqWDbCDR1LM9+JpXTUV8YcQUTA0m+IhggJLzYs8mdJVpVug9HV2BacT9cSYOKIWu FmMx9hAowR/L4T3we/AaEhYvenKm218UcYJfhss6TJMLfr5rrl4urvUwWjveN+suTx9+ GKRqqXrzyCxzjg/nF48J6xKzMH8uGqTdYxfFBblO8xygY8WkROPocffUlrHaHwK1aCYq XjbphOExH2L/R6T2m40icCMHJbEpp0Yexi+LMf62ydHTDcydJbYKC1R0yjG8g2lOY5GJ pcd3WgvVwJFYtds2TBuLhps5m+Hh18ztnfd3rp66/244N/qmSEOcvKUoc92vUHcvOSvA OtLQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=omp.ru); spf=pass (google.com: domain of linux-kernel+bounces-147433-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-147433-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id t24-20020a63dd18000000b005dc8280f3b1si10425665pgg.303.2024.04.16.12.06.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 12:06:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-147433-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=omp.ru); spf=pass (google.com: domain of linux-kernel+bounces-147433-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-147433-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id DCDD4B22584 for ; Tue, 16 Apr 2024 18:59:13 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4419B13792D; Tue, 16 Apr 2024 18:59:06 +0000 (UTC) Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FD6D137777; Tue, 16 Apr 2024 18:59:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.154.21.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713293945; cv=none; b=q0kP1jbjCHJc6VqeU/4OBjTZBZ9VZ0C3Rx+vyMjx94kigeh4q0uuOtILskj8LTUTq4sQgyDu9R5AV3pGGosOiZl6k1KNF0zCBrzBzbFTpvkWQ3ggZyEPQ61M6nAto3M2UR88DUCJppUb6yDTTrPo5nam+kpxWLvDdGoLHA2Kg8o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713293945; c=relaxed/simple; bh=1Ld+ycEs17szCKQzP68kYUns5w+E28E1p3B6H+yY1vE=; h=Subject:To:CC:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=fhLsW2LiWvM62W3RzhVLebOaJkyLlZPwxJDbhyJdMi/QJWks2AZNXnkUWFunFIfiJk1jFzZvN3DDg2tBx+fXC35jjYs1cTaom3RrF6Q/pTGu8xofYF3fULV36qNFBXabk+jNRGvy2JoGtfAhuFJasJF88rVuAm0INg9BXhxzodo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru; spf=pass smtp.mailfrom=omp.ru; arc=none smtp.client-ip=90.154.21.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=omp.ru Received: from [192.168.1.105] (31.173.81.200) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1258.12; Tue, 16 Apr 2024 21:58:52 +0300 Subject: Re: [PATCH 2/3] media: tuners: xc5000: fix error code handling in xc5000_attach() To: Roman Smirnov , Mauro Carvalho Chehab , Hans Verkuil , Luis Chamberlain , Jia-Ju Bai CC: , , References: <20240416114509.198069-1-r.smirnov@omp.ru> <20240416114509.198069-2-r.smirnov@omp.ru> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: Date: Tue, 16 Apr 2024 21:58:51 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20240416114509.198069-2-r.smirnov@omp.ru> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 6.1.0, Database issued on: 04/16/2024 18:34:01 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 59 X-KSE-AntiSpam-Info: Lua profiles 184744 [Apr 16 2024] X-KSE-AntiSpam-Info: Version: 6.1.0.4 X-KSE-AntiSpam-Info: Envelope from: s.shtylyov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 17 0.3.17 f2153f38d75b12894d9cf445f96cd15c9ef63a9d X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {relay has no DNS name} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: {Found in DNSBL: 31.173.81.200 in (user) b.barracudacentral.org} X-KSE-AntiSpam-Info: 127.0.0.199:7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;omp.ru:7.1.1 X-KSE-AntiSpam-Info: ApMailHostAddress: 31.173.81.200 X-KSE-AntiSpam-Info: {DNS response errors} X-KSE-AntiSpam-Info: Rate: 59 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 04/16/2024 18:38:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 4/16/2024 4:06:00 PM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit On 4/16/24 2:45 PM, Roman Smirnov wrote: > xc5000_attach() uses the hybrid_tuner_request_state() macro. > It may return the error code -ENOMEM, but the function handle Handles (just noticed that grammar issue in all 3 patches). > the value 0 instead. > > Found by Linux Verification Center (linuxtesting.org) with Svace. > > Fixes: b9302fa7ed97 ("media: tuners: fix error return code of hybrid_tuner_request_state()") > Signed-off-by: Roman Smirnov Reviewed-by: Sergey Shtylyov [...] MBR, Sergey