Received-SPF: pass (google.com: domain of linux-kernel+bounces-147450-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 16 Apr 2024 14:08:28 -0500
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: Lu Yao <yaolu@kylinos.cn>
CC: <ogabbay@kernel.org>, <thomas.hellstrom@linux.intel.com>,
	<maarten.lankhorst@linux.intel.com>, <mripard@kernel.org>,
	<tzimmermann@suse.de>, <airlied@gmail.com>, <daniel@ffwll.ch>,
	<intel-xe@lists.freedesktop.org>, <dri-devel@lists.freedesktop.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/xe: select X86_PLATFORM_DEVICES when ACPI_WMI is
 selected
Message-ID: <vxcohxeef53mqgz5frmo5n3ol42eyawqvcrzti4ebh2qnaqpnp@qckpzayhjemk>
References: <20240415025215.15811-1-yaolu@kylinos.cn>
Content-Type: text/plain; charset="us-ascii"; format=flowed
Content-Disposition: inline
In-Reply-To: <20240415025215.15811-1-yaolu@kylinos.cn>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QKwOPkiyRDbpkS4oEwmfbWTxRVBpYvUCwhM5qYn6kMw9PftIqa1kU9vyT2eh?=
 =?us-ascii?Q?urwFEFjhGfVCQcc6UUWWYbrEzEaJSijaF/u7gqefHrroZ1+juTWplqrxSVLF?=
 =?us-ascii?Q?v/uYGTpM2MPGbwOHjttRXPJZcqqHsxDgCIpStidJynlLmN0npm1EvaRn5EKx?=
 =?us-ascii?Q?SCwqrb9ELyhcKzlhY2XRk6sMFKrLxg1re+qHefYXD190fBO2oXw+b2mk+aj5?=
 =?us-ascii?Q?cTX3cm64a7KYwsDB8ib+9tUd5KK/EZNVUQusPiQ+i/8cf26pWWu1Zz8VvhYA?=
 =?us-ascii?Q?NI3G0JxbB3QSgPU0DeyKEfshGn1Rj7iIjXoN9HZoQ3G2CwKHCIOpCg5e1+gk?=
 =?us-ascii?Q?bEKGsXjsQlgClqL6EOFQ3vzxPRB5OEfTqRHxnNXnrVzflfih4EMcJL8PXDXi?=
 =?us-ascii?Q?gWDlKciiCPB9x+WSpluaCUDYgGmAUFajObRxiquwDA+CzJRmQimS/j5ybw8G?=
 =?us-ascii?Q?BbeidYio5hueXSgQZLKWGjDNIgBWfMG+oICVwDToUhctHEnjzTt+/RPO3zpJ?=
 =?us-ascii?Q?P9I6Ixgz8mxbd+pXatrK8RGxj7kjnVoSWdO1ebNh7drMLKyUFxEuvVsSfqF1?=
 =?us-ascii?Q?k/UQiqiXL32yKKFQ/rP2xYD2xR5Tbf1K+Dj9TsEGANjfg2vONIfWPuj6kh6x?=
 =?us-ascii?Q?o0LQschuq6ToFttkmnQmLoSa1orTMxz2pPUFo/XZnxQPegfKey134MWuxNPv?=
 =?us-ascii?Q?bymnqhKbFHVf4YxACHy7m32lJF29RyvN3gu5bGikbEudQpoIG6a525/EARTX?=
 =?us-ascii?Q?axnEP6vJBjaN3CusU7YQGUBolcLuYn46TiZEw7kVkl6DA75dqcL4a9cfcwm0?=
 =?us-ascii?Q?8ZCwb9tBoIZNykdYJlNxk6X/CTktt2rigYhBm4Jv6fVKe7RS2rk6fMS63/7a?=
 =?us-ascii?Q?PerDa9TNvpTmys3MN7bDzYeGqgnY7A3HLgrn7alHiLbqNMi3CdZlXdlLP9a1?=
 =?us-ascii?Q?Q2KOWSMqPcKCgYWuH3Vqu/ciuP4Mnl/ejz7UqhOjeeS/SfA8ZgTM00EXhrNP?=
 =?us-ascii?Q?DVrn1wAsKqvF6gAyxSsByjNHsTG1rbZiLXQHwOeeTBQuxgTZeJ28mWk/bLAw?=
 =?us-ascii?Q?QiMvwd0YD1D1K+2eQD10dCItQPKqNIQGrpZVBg7RYhM7KUKkAQMkYWu5fwch?=
 =?us-ascii?Q?hSrjLugnNtWN9P8987wmSn7diXXxdKwRmWQRiKc8dcLkGzZGupcIb/e1sZu3?=
 =?us-ascii?Q?JRx4j5bV/PtP6akajXzSx3nPy2mnyJZp9itIDO9EiyjMdaDptEOSeA66Pln1?=
 =?us-ascii?Q?BOywZwk5+MutqfwcVbMqYzxfmkQ3XZFHneO9Rrhc+Rh0AdT7ux9kgqit43Ff?=
 =?us-ascii?Q?cFRTvlpWkdaAN1ueC1wGsvrlnUcODNvtslCF7UgZfXJ3wS7hrWWLe2exkV7y?=
 =?us-ascii?Q?9QmNL4EibvfopdvGCX/9KbA4p3ZMDKRX1k3VZ5E2mMrHiMLUY8rvClUwXH3E?=
 =?us-ascii?Q?GNQthNxY9nLMmMBKPP2Iz4G4HxDMpq3B22OMwMz64gNDXyp2Nfgb3FDjygoU?=
 =?us-ascii?Q?o0TkOxBKvfoy7JJWpZiG0HAFlbOioaqhnKUWaF14EyDXtUdnz5gs/wANDsh0?=
 =?us-ascii?Q?x9yqy9dqIEbp0uzm7z5P4K2355dsdk89L5dBjbQKaKFvC/6eXNEiL4hF2B+Z?=
 =?us-ascii?Q?HA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a27f767a-0221-4d81-ed56-08dc5e489af2
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6139.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2024 19:08:31.1708
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iczn7RynzZjwEBc7B0TsuPkF1IFfmMHE0VC3E/iSDh2lsMn5z/29ReWVs3YYcnICMpgfG5MpbZD58VSAKjuzgRFfjXxyUhUhqe9dm4w5X+Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR11MB8767
X-OriginatorOrg: intel.com

On Mon, Apr 15, 2024 at 10:52:15AM GMT, Lu Yao wrote:
>ACPI_WMI is a subitem of X86_PLATFORM_DEVICES. And X86_PLATFORM_DEVICES
>is not selected in the current Kconfig, and may cause Kconfig warnings:
>
>WARNING: unmet direct dependencies detected for ACPI_WMI
>  Depends on [n]: X86_PLATFORM_DEVICES [=n] && ACPI [=y]
>  Selected by [m]:
>  - DRM_XE [=m] && HAS_IOMEM [=y] && DRM [=m] && PCI [=y] && MMU [=y] &&
>    (m && MODULES [=y] || y && KUNIT [=y]=y) && X86 [=y] && ACPI [=y]
>
>Signed-off-by: Lu Yao <yaolu@kylinos.cn>


Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>

and pushed to drm-xe-next, thanks.

Lucas De Marchi

>---
> drivers/gpu/drm/xe/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig
>index 1a556d087e63..f483e69a5d0f 100644
>--- a/drivers/gpu/drm/xe/Kconfig
>+++ b/drivers/gpu/drm/xe/Kconfig
>@@ -26,6 +26,7 @@ config DRM_XE
> 	select INPUT if ACPI
> 	select ACPI_VIDEO if X86 && ACPI
> 	select ACPI_BUTTON if ACPI
>+	select X86_PLATFORM_DEVICES if X86 && ACPI
> 	select ACPI_WMI if X86 && ACPI
> 	select SYNC_FILE
> 	select IOSF_MBI
>-- 
>2.25.1
>