Received: by 2002:a05:6500:1b45:b0:1f5:f2ab:c469 with SMTP id cz5csp182568lqb; Tue, 16 Apr 2024 12:18:46 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXrG34r1W4dhiXvAfBO/HPOeMyn0GS9ez8VyZsadlwFKZwSiV+gbwwPSvhPrDIeo9dB+0IA3b4AxJKEdXCK/l0b1wW8/2pXSktQ2OTJhA== X-Google-Smtp-Source: AGHT+IFvKu0q3a9fF6IJHPZGIUqywFH4m/VjwgCq+k6Ah7GSMQViZQFWwg0UvBaUS0ezG0LLHIRh X-Received: by 2002:a17:90a:5794:b0:2a0:86b6:2e9 with SMTP id g20-20020a17090a579400b002a086b602e9mr12538364pji.12.1713295126389; Tue, 16 Apr 2024 12:18:46 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713295126; cv=pass; d=google.com; s=arc-20160816; b=dh0HHZASFJ8u9pFuE+4QtP9LEf6zZUEEPa9Q8iUB/VQEqvzabrqA6XIlD6gchKHQUV KAqklyTJpmJzmW5K/wUoGKRU+vCa9J8f/n8Z3puKVk6Egq0yHBGt9XQmnKArVCIuzeKZ HQz2aQs4pqyckDyq8CHdpP1yZFRfafbWWAJX6a2r6TNip6GSmFCbD+Bl934RqB5Ko9Zp Zk4Te9Ne5p+A8MOgeWcSPWE8PFHlLRUTFVltKbtcYCBmJdukjw+tf8OK3DBYjm3kNCfr D3SvgkUDTP4nPPSfLHQKmsjkMv80HwT+rIDyIMHtDAxrSBahdnSxu/hTUEpfOf4i9Rdk 73lw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=eFsQnwS6PGFtgDcFaHJVKvrfFzDGNqbI1upRmAGSdUs=; fh=G77vWvFy3ModCRac4Dh3Zt2Dhgpvl2U2BxREu+lcivA=; b=Sv4AP8Pacwf7FJX0G+zJ1e2wN4Bo8OOQesgOrwXnHNi+CNYw1ar9Jwl9OwM+BUgD+C 8ZZwCH1B4zTHtwLuyjKLnA4Nmkgvub2CW0dFxyOUPklPZPmZNmk/c8lBf51TJnMVV/pR U0BtjyBvCMg6OUKt/PXUwUQQE5uT9jRfYLxgQQyUQMEmgS9hftSZJXEp57OERzSy1tXO 2VM7B73efV0dizbsZaOsCpBGjZRg3OKq3kgzOOOlTxl/WcIZa89dYXrBpACYhSwFla0G eLXLMPXAGxoKU//5EPzRjrmcXJjmnlDSPLzTkM5lbvQVu4WCBfHI+BXThF3bpPb+ee73 A93A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@acm.org header.s=mr01 header.b=fx8QpHx7; arc=pass (i=1 spf=pass spfdomain=acm.org dkim=pass dkdomain=acm.org dmarc=pass fromdomain=acm.org); spf=pass (google.com: domain of linux-kernel+bounces-147458-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-147458-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=acm.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id ls7-20020a17090b350700b002a66c1dca70si9804872pjb.66.2024.04.16.12.18.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 12:18:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-147458-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@acm.org header.s=mr01 header.b=fx8QpHx7; arc=pass (i=1 spf=pass spfdomain=acm.org dkim=pass dkdomain=acm.org dmarc=pass fromdomain=acm.org); spf=pass (google.com: domain of linux-kernel+bounces-147458-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-147458-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=acm.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 16927281EEB for ; Tue, 16 Apr 2024 19:18:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C7FAA137C3A; Tue, 16 Apr 2024 19:18:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b="fx8QpHx7" Received: from 009.lax.mailroute.net (009.lax.mailroute.net [199.89.1.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAE6F137921; Tue, 16 Apr 2024 19:18:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=199.89.1.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713295117; cv=none; b=S01ohVwhoBBwkz7vS9i6Vx7WnsJNVB77Eh6qNpk1joubxZOL2Yj6LGZiuqTUnesDjNCMe8YEnlz+dd88+YbIKRMRdq98B4HAVCRAFxe7ERy/SfGe7qbVdR6I/gfU3jmKPoiKB/KjhqLURKMx+bcDFbUXeOP4aol0nK2JwlSRRxw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713295117; c=relaxed/simple; bh=eFsQnwS6PGFtgDcFaHJVKvrfFzDGNqbI1upRmAGSdUs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Zefl1IMeAE2ZuHJIeYFuQlsuTAt8gL/UQwhKNwiKc5XPZePJLrXefg7Unh3acPFLjOhbxGXKbpYXpT+RHT2OTo71SwG9SPXg6ufg+eEhbyCpZjfcA0xYaK2KawEJEdiux+bG3uMD6eWsf+tacV0Q0XNI/BGbvL03S6/pwHxwgwY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=acm.org; spf=pass smtp.mailfrom=acm.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b=fx8QpHx7; arc=none smtp.client-ip=199.89.1.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=acm.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=acm.org Received: from localhost (localhost [127.0.0.1]) by 009.lax.mailroute.net (Postfix) with ESMTP id 4VJv2s5Ty9zlgTHp; Tue, 16 Apr 2024 19:18:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:content-language:references:subject:subject :user-agent:mime-version:date:date:message-id:received:received; s=mr01; t=1713295108; x=1715887109; bh=eFsQnwS6PGFtgDcFaHJVKvrf FzDGNqbI1upRmAGSdUs=; b=fx8QpHx7MdXz4DWNF5sKx2pET/oKMw17BAId9stL 5lzAFPohxQeKZACWn35Z8lu+Ne42NFD8qXLHVetH5fTj1WFay6FH1Gfn/XoYRCKx kEYjzppO5JLFiPFgqOIcYv1hRVcxoy+yoL6LB9e8FQT8QgyxCPb8qFiv2vo0laLq /+sX5Uc/C0O7KWaFLCidfxjTC1Xu2wpCB1soWkDo6WptScusk9a38o+3Zf90YLEu HOBCLE0o5RKQaDzZ/SnkeEumTTSmZliH1sY2f5G7OSVCbTZfBi4umZWPkczglsW9 Pr7t9qwMb1oSjIo5s0agNOQYGEhfWupQHcPtSrFWZEl31g== X-Virus-Scanned: by MailRoute Received: from 009.lax.mailroute.net ([127.0.0.1]) by localhost (009.lax [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id gvqFSUSqaQat; Tue, 16 Apr 2024 19:18:28 +0000 (UTC) Received: from [100.96.154.26] (unknown [104.132.0.90]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 009.lax.mailroute.net (Postfix) with ESMTPSA id 4VJv2q3mZZzlgTsK; Tue, 16 Apr 2024 19:18:27 +0000 (UTC) Message-ID: <0b031b8f-c07c-42ef-af93-7336439d3c37@acm.org> Date: Tue, 16 Apr 2024 12:18:25 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] scsi: ufs: core: Make use of guard(spinlock_irqsave) To: Avri Altman , "Martin K . Petersen" Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240416102348.614-1-avri.altman@wdc.com> <20240416102348.614-2-avri.altman@wdc.com> Content-Language: en-US From: Bart Van Assche In-Reply-To: <20240416102348.614-2-avri.altman@wdc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/16/24 03:23, Avri Altman wrote: > +#define SERIALIZE_HOST_IRQSAVE(hba) guard(spinlock_irqsave)(hba->host->host_lock) Something I have brought up before: what does the host lock protect in the UFS driver? Rather than reworking the code that acquires and releases the host lock, all uses of the host lock should be eliminated from the UFS driver. The host lock should be replaced with new locks of which it is clearly documented what member variables these new locks protect. Thanks, Bart.