Received: by 2002:a05:6500:1b45:b0:1f5:f2ab:c469 with SMTP id cz5csp186956lqb; Tue, 16 Apr 2024 12:28:15 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW6/P7EKlxbpZV2p4NbzSSwIZjAK0yi1KIUqN9IuBINyw79wu0P+SBbImVDerQ1v42cltQ19QH+y3Ntu/FlmUggI2ocJO1TEOGWiySMjw== X-Google-Smtp-Source: AGHT+IEOuyiJSwLjo+keQ7EPUV6w7fEtD1sRXvRRmR/IuvIzX7pGWm8XdsX4aUwB9J0XbqRQN7n6 X-Received: by 2002:a05:6a20:96d0:b0:1a7:8b88:96b3 with SMTP id hq16-20020a056a2096d000b001a78b8896b3mr16755630pzc.9.1713295694946; Tue, 16 Apr 2024 12:28:14 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713295694; cv=pass; d=google.com; s=arc-20160816; b=df5D4GRCc2lHx4CJxu2Nm+TeYBRH3emFa+0vbsVTxWllbAXYnB5A+HK8w8aMStrZNT vFH1UXzWJdwQfIZOVF3VB+5JjwJUCkG0zPqgoEUQ4lkLuFDC2gj+qrq67EINhXWe3+2R EnCQ2hAeFl9OiZO9Z+PyVEoIqok/H6YTm9+Q+DqStKuoVxanVA96XfQAdjPywJnNQS+F XsZjCnUoDoVJXaJsNxWMeJ9x7/GB13btMHi/td6bmIVSRwQcc1CNUZC7BKt9e2yDE8GQ XdfnOQzcoqki8LuY34TtrFv4uq5K9/z8feEcT1nYxAUPabUvk+H8AKiNGrHRfZV9HZ1s 7ovQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=FxdtFVH/2uAQXMgoryBXaitmMAXcOlHSCzHSVcK2yX8=; fh=chwVLnq76ReeO6Jye2uxMDmPBZrNnq+u7kJEHzIRzxo=; b=P1RczRGSeWTsvJvPDexbb+vqou0Sf8IIhU2CM/+eFfR05+JJMU74F6kHB1DW5wOgKw tiEtmg3EB8yFdSbD0ym6AzhGuLkQKW1UWTMdaqLWeTsqY3Uja/fjsnXOQ7ijrVcWvANM 2QtoL7IA6WkQaMAk24W71DnYHXpM4QrbLD+E7I5abyMX/oZETX8oro0tqNkDf6Z5Vw2i GVLjv7GGf92w2WelobTCVjUSxbJxGXlrWJ61a9NwCeP1VkIsAtgbHjgT9pcFZw7uC/dV hh8GfsQ8wBG+ODxE6xeRvApo6Tny77ywoDnxO624GjtjtKz5E2pcW8gmRH6K0Lc26GC5 bmlA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Zs7SGRHw; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-147474-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-147474-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id j26-20020a634a5a000000b005dc491389b1si10147855pgl.679.2024.04.16.12.28.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 12:28:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-147474-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Zs7SGRHw; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-147474-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-147474-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 9C0A6282E8E for ; Tue, 16 Apr 2024 19:28:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4A7AE13848E; Tue, 16 Apr 2024 19:28:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Zs7SGRHw" Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32DAD137C3A; Tue, 16 Apr 2024 19:28:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713295685; cv=none; b=pjSfZf34GWwUV931Do0OARNt9Jg966bka1Q6In0tjgew+gsBwppT5IHHC91mNly4SlboBeygIX3yLY/rxTtWz9EJOC/V/IIGjreeJJ7eMAL+34RmARX/UfIauii9/PEgQ6MtUVDaXkAARyD7rLaU9bIV7gCsYfdF8m4ZJhVLcSc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713295685; c=relaxed/simple; bh=6oYvzJCewT/Y7/t2YqN6eF5ZDY7C7jCDP57CX3DncwI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iCFSfUCpRJt4L3dWYQzfVTceqZRhx0TUjoq9N9V9k7D7AefEQbWVUCh1fn7N6dIdj2BEsX6aXr0NsngaBvx0BnEEnAbizQx5hg6k3T5z4j4ta9x2Lt1sGKTcw494kg0kgTdPIEfTu4tVE8ZmLSIDIRGklfVej4Boh1c3zHJaAJU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Zs7SGRHw; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-6ece8991654so4325122b3a.3; Tue, 16 Apr 2024 12:28:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713295681; x=1713900481; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :from:to:cc:subject:date:message-id:reply-to; bh=FxdtFVH/2uAQXMgoryBXaitmMAXcOlHSCzHSVcK2yX8=; b=Zs7SGRHwVGy5a81UpiHdjq+SrKb89AhDxIMYV7UlqCiT8EsP/1IWC49xIWg/bto7jw hTZ6iu0HoKNBcNu1rcBdmgJW7CCn22WxM6PYwPb7QMgTGh5hMuOvhULOe/lApyIKUPc+ TLiaPT1GWb+w+47dnI5xgM+2uqVK6vbqlPIcozODQe8a8lzpwcuUBJ4dRxGe2l+jvmwC wz0BB4VzeQLVC5RBYihtclLms3hSMbci5ZrdYhRtNqtGV4DnOiYbIaa3Bw/Nc2b8pcXZ ErjjhRh4RwfNUbiVU5ln5PqP6C+r2//8vTJJnaT3fvNdrppm/M0uPFDaVtXemb1ABEjc sKHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713295681; x=1713900481; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FxdtFVH/2uAQXMgoryBXaitmMAXcOlHSCzHSVcK2yX8=; b=DdmJxwZ8z0qwLqeQT9iqkdYgMxzKUINJ0Egjmu/WdB0ht0YcZfy7SZckqepFt6y5Gx KGmRZIBnpq/IHg6ETzswgqHuBBzFZqMsVFOOdzaRBuWtqajgDmLZn+R1RsUEEauk9Fkc bNu6pAN4n0cowOZcGZHCwS1oJ8+itGkeuk2vSj7BMvWRg/c6A72uqeGsS45vEYLq6BUm rrXGUBLeB5b6+YQ5ftJTCHwEbGz2cEB6k9PcSymzZxdtVIwIATJfHXPtGowXnTRZrjb0 VGx8zznn+AGfTNsGJRb1Xx53wMtxd9BlOT+xcWgX5iSXzXASW7sKgsNrCz3rLT7VR4ba veOQ== X-Forwarded-Encrypted: i=1; AJvYcCUa/1/ZWwqXA52V/DAlDFtiR+cfnbPBeq3kPL+iEek8++F5Fp0t2arNN3GaeNa50xxwyFxRyqBA8xnOHauvV7XWpSTJL3j5ElHdCwajdp6qepvSIfMTyV3cWTZI/kJ3NduZ5uJR1bv2Hau1ClxHMRY413Y+aHIigCM2IGI16ohFKdsBv2gj2pz7 X-Gm-Message-State: AOJu0YyvA3MhkiRrF2b3nOiLQXoiGcnvpPOqzhDUJD4shHswapYkfatQ tHtf83uVPeE/ODiCeW4vE+TsVDUI62ZCtiUHiz0hsj7DnVBNcLOn X-Received: by 2002:a05:6a21:8cc7:b0:1aa:5a22:5eca with SMTP id ta7-20020a056a218cc700b001aa5a225ecamr1934625pzb.31.1713295681372; Tue, 16 Apr 2024 12:28:01 -0700 (PDT) Received: from localhost (dhcp-141-239-158-86.hawaiiantel.net. [141.239.158.86]) by smtp.gmail.com with ESMTPSA id 20-20020a630f54000000b005f75b45c771sm4573406pgp.38.2024.04.16.12.28.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 12:28:01 -0700 (PDT) Sender: Tejun Heo Date: Tue, 16 Apr 2024 09:27:59 -1000 From: Tejun Heo To: Michal =?iso-8859-1?Q?Koutn=FD?= Cc: cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Zefan Li , Johannes Weiner , Jonathan Corbet , Shuah Khan , Muhammad Usama Anjum Subject: Re: [PATCH v4 2/6] cgroup/pids: Separate semantics of pids.events related to pids.max Message-ID: References: <20240416142014.27630-1-mkoutny@suse.com> <20240416142014.27630-3-mkoutny@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240416142014.27630-3-mkoutny@suse.com> Hello, On Tue, Apr 16, 2024 at 04:20:10PM +0200, Michal Koutn? wrote: > diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst > index 17e6e9565156..108b03dfb26a 100644 > --- a/Documentation/admin-guide/cgroup-v2.rst > +++ b/Documentation/admin-guide/cgroup-v2.rst > @@ -239,6 +239,10 @@ cgroup v2 currently supports the following mount options. > will not be tracked by the memory controller (even if cgroup > v2 is remounted later on). > > + pid_localevents > + Represent fork failures inside cgroup's pids.events:max (not its limit > + being hit). It might be useful to be more verbose with the explanation. I'm afraid the above may be a bit difficult to understand if one doesn't already know what it's about. > @@ -379,7 +401,6 @@ struct cgroup_subsys pids_cgrp_subsys = { > .can_fork = pids_can_fork, > .cancel_fork = pids_cancel_fork, > .release = pids_release, > - .legacy_cftypes = pids_files, Hmmm.... doesn't this remove all pids files from cgroup1? Thanks. -- tejun