Received-SPF: pass (google.com: domain of linux-kernel+bounces-147477-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Sender: Tejun Heo <htejun@gmail.com>
Date: Tue, 16 Apr 2024 09:32:45 -1000
From: Tejun Heo <tj@kernel.org>
To: Michal =?iso-8859-1?Q?Koutn=FD?= <mkoutny@suse.com>
Cc: cgroups@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	Zefan Li <lizefan.x@bytedance.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Jonathan Corbet <corbet@lwn.net>, Shuah Khan <shuah@kernel.org>,
	Muhammad Usama Anjum <usama.anjum@collabora.com>
Subject: Re: [PATCH v4 0/6] pids controller events rework
Message-ID: <Zh7SXQSobt9qIQRG@slm.duckdns.org>
References: <20240416142014.27630-1-mkoutny@suse.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240416142014.27630-1-mkoutny@suse.com>

On Tue, Apr 16, 2024 at 04:20:08PM +0200, Michal Koutn? wrote:
> This makes pids.events:max affine to pids.max limit.
> 
> How are the new events supposed to be useful?
> 
> - pids.events.local:max
>   - tells that cgroup's limit is hit (too tight?)
> - pids.events:*
>   - "only" directs top-down search to cgroups of interest

Generally look great to me. If you resend with the couple nits addressed,
I'll apply the rest of the series.

Thanks.

-- 
tejun