Received-SPF: pass (google.com: domain of linux-kernel+bounces-147487-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <6d982d5a-5313-40ff-85b2-aeba5429a47b@amd.com>
Date: Tue, 16 Apr 2024 14:52:55 -0500
User-Agent: Mozilla Thunderbird
Reply-To: babu.moger@amd.com
Subject: Re: [RFC PATCH v3 09/17] x86/resctrl: Introduce assign state for the
 mon group
To: Peter Newman <peternewman@google.com>
Cc: corbet@lwn.net, fenghua.yu@intel.com, reinette.chatre@intel.com,
 tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
 dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
 paulmck@kernel.org, rdunlap@infradead.org, tj@kernel.org,
 peterz@infradead.org, yanjiewtw@gmail.com, kim.phillips@amd.com,
 lukas.bulwahn@gmail.com, seanjc@google.com, jmattson@google.com,
 leitao@debian.org, jpoimboe@kernel.org, rick.p.edgecombe@intel.com,
 kirill.shutemov@linux.intel.com, jithu.joseph@intel.com,
 kai.huang@intel.com, kan.liang@linux.intel.com,
 daniel.sneddon@linux.intel.com, pbonzini@redhat.com, sandipan.das@amd.com,
 ilpo.jarvinen@linux.intel.com, maciej.wieczor-retman@intel.com,
 linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, eranian@google.com,
 james.morse@arm.com
References: <cover.1711674410.git.babu.moger@amd.com>
 <1a6bc747da259e8b3a85de339bc1d6bf94995c53.1711674410.git.babu.moger@amd.com>
 <CALPaoCj_yb_muT78jFQ5gL0wkifohSAVwxMDTm2FX_2YVpANdw@mail.gmail.com>
Content-Language: en-US
From: "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <CALPaoCj_yb_muT78jFQ5gL0wkifohSAVwxMDTm2FX_2YVpANdw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MVRTQVFERHJzc2VFVFFCL2xGd2VaNys1MWh0RVZ6ZXI4UmRtblNhb3hZVzZN?=
 =?utf-8?B?Vm1YSEoyL3hwM2ExcHR5YjhzZFdFYmJObk1hVGRZRmczOEJzYlRCMnpxeXM3?=
 =?utf-8?B?dm1YZUVvODllZVVBd2lNLzZaQ1lFdU8yNk5HdFFFT1JlVVRwVThIQ3lIdmV5?=
 =?utf-8?B?eVdXZzJ1YktDeE1oZUtDbCs5UmlLcG96emp3Zkg4MzVWUHRrUzRydDdRd3Zw?=
 =?utf-8?B?QzQxZ3JkemdSSjJiSE8xTkRXQ1FXZlNzdjNjTU5hZTk2dXJsT20yM1VwUmov?=
 =?utf-8?B?T1g2L3RSaEVLcGV5NkE0OWErM2NMSUJjSG9UMWdSZnBPQ2Rsb2orZjlzbXJV?=
 =?utf-8?B?emFndjlPWUxiT0Z5VHJlc1c3L0x4RVR0SmVKK3FHcm1CRnMxL3g2VllIVzF0?=
 =?utf-8?B?NTQxYzM2ZlQ4R1NybVdQYTBQWEd5ZGJKdE5TWE1odk9qZFQwakthZkdkQXlS?=
 =?utf-8?B?MWphNGY4NnRtQnJhUFFtdUtVUVBhSFYrSXZVUllVL2k2RVoxekNMQ3UxM0Nn?=
 =?utf-8?B?cms2YWxPVlZMMCswZFNhSGI1RnQvRFJrcXVXY1Npbk51ZVdUTXd3aWVpbi85?=
 =?utf-8?B?YUpTbk5nbjJyYjRZOFpMbWd6KzFOY3IwUGsvSFJuNTZwelFzN0kwQ2JROFZv?=
 =?utf-8?B?S0dkdlpWRHJXMnl1Vm11MEhCeWhqbVVvajNocmVodG9QSklGNzFqUklhd294?=
 =?utf-8?B?YUQyd1lPUDVobG1BL29TK0FSNXIzZlhlMEdvR0xMWlNFTCtBY0VsNGhGQmJI?=
 =?utf-8?B?Mk5yK2g0WHBxSkdPYnBwRXh3OS9ZYlYxV2VoRTFDWmh0WXpYbXVadkxjT2lq?=
 =?utf-8?B?R1piaUgyemh3dDZrOForMHFLZFRuVkhlMnV0eGhzeFE0WmNnM29JRmwwQzRi?=
 =?utf-8?B?bnZER01yTURjQzhiMExqaURBQW1naml1UUE4LzIyUG9MWWJVdFB2UjIxMUU5?=
 =?utf-8?B?TVpMWllyNW5zS3pCL3I5N2h3dWdYRkVnZnVkZ0k4SFRNRS9hOW92UlJNZjJW?=
 =?utf-8?B?MDNHNDBlZUNYeWhYc0tieHc0Q0xzZ0JHanJpSWVwWlNJK1ZwZm5lQUdKL2Qx?=
 =?utf-8?B?SWJtSjJkN3FCWWFFT0VXY0ZiMkhsV3BFVTFHWHloeEJPNThsWmNlSlpicDVX?=
 =?utf-8?B?M1UxUHhnNjB5Nzh1aFlPYklVYUZDTlZjb0NzTDhaSDYvSW9yMWp2T0JvV2JR?=
 =?utf-8?B?OFA4T0ltOXJJei9TNndoOFRLUlVqSFQzNm5Xcy9icHRNTmhIL0wyenlnUFpp?=
 =?utf-8?B?SHBOV0dkdnQrYUg2Wm1kaEJtNlFUZUdDSUIvcTZMbHl5cUdYbzJpOURZc3FI?=
 =?utf-8?B?Z2M2VGQ0NTExT0JzakFaenJHa1RmWVM5TGJXcG8wa1dxR1Ura3ZjSlpkbkp4?=
 =?utf-8?B?M2w3dmNLWGJ0TnVSVzM4YXp4aEdaRnRGWmRGSVozQmpMNXE4MEw2anVjRVVO?=
 =?utf-8?B?eTR2NDY4RzB4RlppSnpGTFpDVTRTU1AxcEtxZGs3RVhZYW5iYUpMbmt0ZFJN?=
 =?utf-8?B?c2d0OGdIMlM1K29NWm9VczVjeWFLdzVaMEh3SkEwQlhjbHhDMFJ1UUNYM0x5?=
 =?utf-8?B?TkJ0KzFOMEtxL2Q4c2pyTG9wdjBmL3NjTFVLSVQrK0JmeXFaUHJPUkJMUlli?=
 =?utf-8?B?ZFRwN1FrU1JYZjMxdFBLOUpKNVUrWGdmdEQ5TDZSODFURVFnelFKSkdWY3pL?=
 =?utf-8?B?bTd5VzJ6SDlyL2VtU0l1Y0VFSkN4dGd0NU5Qc0RKNlhOdW1xYzdRajFralBN?=
 =?utf-8?B?RStvMTYxdHpkUTh0VnM2Y29hZ2pGeHRtbXl6MGdXTWk4ek1vNDBwY0JtT3Bh?=
 =?utf-8?B?bWlkeVBBdlArMlYxTVJkTitSNzFUNFpyblV5OC8wNDZsWnhybU5HakRRNmkv?=
 =?utf-8?B?S1Y3Y2dVS2RXMFBZSVd0b3k1RUhxeElVd0p6NVdUbHBsZ09SdCtrSGFCOWlY?=
 =?utf-8?B?dUZVRkovZ2tqQS9uVTdxb2VvT0pUckdMN1VweWxYcytZN2F6ZHdQb1cyVXBK?=
 =?utf-8?B?MHphak9zdVB1N3R5NzhHbUlUb2RnVWNyYVZXY1dKSEVoT1JwSkxCbHhRTS91?=
 =?utf-8?B?VWM4TTFoY0hqZ1pTSmViRys4L1lrUnl2N243WDdJM2phSmJJSjVSRDJaMjJh?=
 =?utf-8?Q?OdUU=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ec03ccd5-cdf6-4419-4149-08dc5e4ed26b
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2024 19:53:01.1599
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Vh1tcC6sz3+QDUVzVAVqkhPxNTpDF6TmGuagFbXC3ljx/gf9F9vFowIX3w7dnlYI
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8375

Hi Peter,

On 4/16/24 13:52, Peter Newman wrote:
> Hi Babu,
> 
> On Thu, Mar 28, 2024 at 6:08 PM Babu Moger <babu.moger@amd.com> wrote:
>>
>> +/*
>> + * monitor group's state when ABMC is supported
>> + */
>> +#define ASSIGN_NONE                    0
>> +#define ASSIGN_TOTAL                   BIT(0)
>> +#define ASSIGN_LOCAL                   BIT(1)
> 
> We already have an enumeration for the monitoring events (i.e.,
> QOS_L3_MBM_TOTAL_EVENT_ID), which should already be suitable for
> maintaining a bitmap of which events have assigned monitors.
> 

/*
 * Event IDs, the values match those used to program IA32_QM_EVTSEL before
 * reading IA32_QM_CTR on RDT systems.
 */
enum resctrl_event_id {
        QOS_L3_OCCUP_EVENT_ID           = 0x01,
        QOS_L3_MBM_TOTAL_EVENT_ID       = 0x02,
        QOS_L3_MBM_LOCAL_EVENT_ID       = 0x03,
};

I think you are referring to this definition. We need just one bit for
each event. The QOS_L3_MBM_LOCAL_EVENT_ID definition(both bit 0 and bit 1
set here) does not work for us here.

I can change the definition to something like this.

+#define ASSIGN_NONE                    0
+#define ASSIGN_TOTAL                   BIT(QOS_L3_MBM_TOTAL_EVENT_ID)
+#define ASSIGN_LOCAL                   BIT(QOS_L3_MBM_LOCAL_EVENT_ID)

Is that what you meant?

-- 
Thanks
Babu Moger