Received-SPF: pass (google.com: domain of linux-kernel+bounces-147494-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 16 Apr 2024 13:03:51 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: Tom Lendacky <thomas.lendacky@amd.com>, Dan Williams
	<dan.j.williams@intel.com>, <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
	<linux-coco@lists.linux.dev>, <svsm-devel@coconut-svsm.dev>
CC: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>, Andy Lutomirski <luto@kernel.org>, "Peter
 Zijlstra" <peterz@infradead.org>, Michael Roth <michael.roth@amd.com>, Ashish
 Kalra <ashish.kalra@amd.com>, Joel Becker <jlbec@evilplan.org>, Christoph
 Hellwig <hch@lst.de>
Subject: Re: [PATCH v3 12/14] fs/configfs: Add a callback to determine
 attribute visibility
Message-ID: <661ed9a781e80_4d56129495@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <cover.1711405593.git.thomas.lendacky@amd.com>
 <e881a70fda1da98882241fc46fd57c3063fde55f.1711405593.git.thomas.lendacky@amd.com>
 <661e10a01f1d8_4d561294d0@dwillia2-mobl3.amr.corp.intel.com.notmuch>
 <7fc4e7d4-dfa8-b626-76c7-1f8993304a2d@amd.com>
 <661ec2968fa55_4d56129470@dwillia2-mobl3.amr.corp.intel.com.notmuch>
 <3cb02504-4854-8bc6-7962-e590e656856d@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <3cb02504-4854-8bc6-7962-e590e656856d@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?t48M1k3mf4LIdWm0lRNKuiXYOE89yyOy+UxkIcvVfYbyXqg+xY5jiuGimhDH?=
 =?us-ascii?Q?9QovGNvgsqVpBZ65UpHvjgJ2pQK8uaOoMLZcuyivrhyZN1fnccV9QdJtYxE1?=
 =?us-ascii?Q?K4NjwV8Tth6ecC+VBABLDUlcu4XKN0TP6g1UZLYJRmJcTcvF3zP/gasTC8vf?=
 =?us-ascii?Q?4ZEFWpuZYhJkw7hrpWpW0OEACeRyA8sPiS0vZRdY8K9s3KeT5vQeMyCdVHVE?=
 =?us-ascii?Q?FspvW0ALxYs2cQP2p0SEgIQHeTITw37go/dm7dnfV+dUbHhvSnXUWbg9/pb4?=
 =?us-ascii?Q?rq6XGdN8RlQhzIjvYzsqYPSwsjtqySZ8TZLDuZ+VJQa6X6tRXN06LOi2i+hX?=
 =?us-ascii?Q?RRQzdpS8XB1aXkNnkvGrz0c8ELK521QAo5aqDn1M4GqpfcmX+gZxK/DQnYIv?=
 =?us-ascii?Q?snEQJvL3rQyTq0HzjeeREKOkhJVoPq1vD1tlijjGIxX/DlUbwtyKyXqeZBno?=
 =?us-ascii?Q?SlRssGpFV0lLJO37MUdrluYk0AN7MZ3OD55rTDU1D+KvIX6ifGQzFQOcLaDQ?=
 =?us-ascii?Q?Cx5hlGlxFE+HBJ9bIv7T7QCM2G40MmEDribUOmiSM9i8HdCCcRHP/QQRu9H6?=
 =?us-ascii?Q?H2aHWGn87Y8sjxR2M0Zc3cT+WHP/EpYPpPEUAVGRdMu1s/Imh0l3o4kB+WJb?=
 =?us-ascii?Q?cprBacVamByo+iLuIjwMf/+7QWdFpLK1YBXS2eHmhqGkwGGTAJKgFzB6yDjm?=
 =?us-ascii?Q?oVLrrzYDlZe/HoJRLGdgjZJ0M/hCC6KqFlLu4Qf0KLuW1p69b1/ynt8jzenS?=
 =?us-ascii?Q?abvCwb8qy5uh4N6NckzXEjuh13/PRRF5qKAvQc7UMlgcxDv0Hdsi/J04xX53?=
 =?us-ascii?Q?lQ8+T7oCQ8sUQEW8H4WlYfH5M5aCLRggBaI5Zvxa8vL0XUfNtFbjlty8IZff?=
 =?us-ascii?Q?QSP8Q01wo53DYyO9nlbjAFaDYVqerl29vGpF1lXOenasSSGEpE9NXKFrzISc?=
 =?us-ascii?Q?NgjAr78q2OpgwxqsswCZOYPoCunY82SEBjm/KEsEH3Jpq/aEApWE0okjAZf7?=
 =?us-ascii?Q?RZns6w1xRqhD+JWLsPWNIcLtQfkGDXiuaCL+CiVkyUeu3UREpck3UF/S6rEY?=
 =?us-ascii?Q?QYGXGtv6UMZ6umwYbWQFyvO/1L/8nNhz1c6tIuEdx4MIMCL9LhaQUwggSu5E?=
 =?us-ascii?Q?On8OxCQhzXOJzgivdwEjd/Q30bRBryXUbvrHd2jTYCvQLDcGn280cn9/2WCM?=
 =?us-ascii?Q?jen3Dgdg4fre93E5FmnS/ccznC4Z5Z+GipmRPqpvH87Mqmgu6h23h5njgY1K?=
 =?us-ascii?Q?eZCftIlXJE/WemyV4YZV6HWXTCoEBU8OlM7GUdzBe3PtaUtnYZT2gemitc8V?=
 =?us-ascii?Q?8CcXZ0wJX1Nq48ZcgYoYdm7Mx6bojuPNmQVkTF0lSRgwhnzoAmml/DaqLolM?=
 =?us-ascii?Q?ThWVzeJ08zHrbynnUrllyqWQOUXaosKNPQfI1dBUJPXM19x4aOuQEDWe/ug4?=
 =?us-ascii?Q?mF6ORh9iMRvkLm1p9HfBv0eH1AYJUnUPiI8KwQgeqkoTp/xasuKncHJK+mYZ?=
 =?us-ascii?Q?pV4mQSUW8H4tFcheLQp+d4BDbJRxA8+M1hQrkvP2JnTU/Lq3RjedrRaJ2Tfl?=
 =?us-ascii?Q?M/5dJd/90xmxH3+O7tRvIHvrxU/DXTzjrqKi4jB6uRLpi687SsMIjhoyFt2a?=
 =?us-ascii?Q?ng=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5eaaae74-3030-4fc6-ab6b-08dc5e5057cc
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2024 20:03:54.4545
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YYEqVlafqR3W6BGjonkpzlhTjkn79HC2G0lRDL7sQcLLoUjkoKDqAS6hd743ssFmYRj4twMZO8UfDpki4+APxLraOKmKX7dmMCt/OzfMx8Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5106
X-OriginatorOrg: intel.com

Tom Lendacky wrote:
> On 4/16/24 13:25, Dan Williams wrote:
> > Tom Lendacky wrote:
> >> On 4/16/24 00:46, Dan Williams wrote:
> >>> Tom Lendacky wrote:
> >>>> In order to support dynamic decisions as to whether an attribute should be
> >>>> created, add a callback that returns a bool to indicate whether the
> >>>> attribute should be display. If no callback is registered, the attribute
> > [..]
> >>>> Cc: Joel Becker <jlbec@evilplan.org>
> >>>> Cc: Christoph Hellwig <hch@lst.de>
> >>>> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
> >>>> ---
> >>>>    fs/configfs/file.c       |   7 +++
> >>>>    include/linux/configfs.h | 111 +++++++++++++++++++++++++++------------
> >>>>    2 files changed, 84 insertions(+), 34 deletions(-)
> >>>>
> > [..]
> >>>> diff --git a/include/linux/configfs.h b/include/linux/configfs.h
> >>>> index 2606711adb18..c836d7bc7c9e 100644
> >>>> --- a/include/linux/configfs.h
> >>>> +++ b/include/linux/configfs.h
> >>>> @@ -116,35 +116,57 @@ struct configfs_attribute {
> >>>>    	const char		*ca_name;
> >>>>    	struct module 		*ca_owner;
> >>>>    	umode_t			ca_mode;
> >>>> +	bool (*is_visible)(const struct config_item *, const struct configfs_attribute *);
> >>>>    	ssize_t (*show)(struct config_item *, char *);
> >>>>    	ssize_t (*store)(struct config_item *, const char *, size_t);
> >>>>    };
> >>>>    
> >>>> -#define CONFIGFS_ATTR(_pfx, _name)			\
> >>>> +#define __CONFIGFS_ATTR(_pfx, _name, _vis)		\
> >>>>    static struct configfs_attribute _pfx##attr_##_name = {	\
> >>>>    	.ca_name	= __stringify(_name),		\
> >>>>    	.ca_mode	= S_IRUGO | S_IWUSR,		\
> >>>>    	.ca_owner	= THIS_MODULE,			\
> >>>> +	.is_visible	= _vis,				\
> >>>>    	.show		= _pfx##_name##_show,		\
> >>>>    	.store		= _pfx##_name##_store,		\
> >>>
> >>> Shouldn't this operation live in configfs_group_operations? That would
> >>> mirror the sysfs organization, and likely saves some memory.
> >>
> >> I suppose it can, but then you lose the grouping of attributes within
> >> the same directory, right? A configfs group will result in moving the
> >> entries into a subdirectory, right? If we go with the group level, then
> >> we will be moving the existing TSM extra attributes and the new TSM SVSM
> >> attributes into new, separate sub-directories.
> > 
> > I am not following the concern about "losing the grouping"? Here is what
> > I was thinking with having the visibility routines in group operations.
> > This is just the broard strokes, it compiles, but still needs the finer
> > detail work to make tdx-guest skip all the attributes that do not apply
> > to it.  Might need to be broken up a bit more, but hopefully conveys the
> > idea. Does this address your grouping concern?
> 
> Yes and no. Basically the is_visible()/is_bin_visible() callback will 
> have to check every index value for a "group" against the passed in 
> value. I was trying to group the values together using an enum in order 
> to make it a bit easier and more readable in the callback. Adding 
> another attribute to the group requires updates in multiple places. But 
> thats just how I was looking at it. I can also see where you might want 
> to selectively hide/show entries and this method works well for that.
> 
> I'll follow this approach (add you as Co-developed-by: or Suggested-by:, 
> whichever you prefer) and submit a v4.

Sure, you can add:

Co-developed-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>

..if you want to reuse any of this sample patch.