Received-SPF: pass (google.com: domain of linux-kernel+bounces-147601-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Sender: Guenter Roeck <groeck7@gmail.com>
Date: Tue, 16 Apr 2024 14:20:24 -0700
From: Guenter Roeck <linux@roeck-us.net>
To: Eddie James <eajames@linux.ibm.com>
Cc: Andi Shyti <andi.shyti@kernel.org>, devicetree@vger.kernel.org,
	conor+dt@kernel.org, alistair@popple.id.au,
	linux-kernel@vger.kernel.org, lakshmiy@us.ibmcom,
	linux-i2c@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
	linux-fsi@lists.ozlabs.org, robh@kernel.org
Subject: Re: [PATCH v2 25/31] i2c: fsi: Calculate clock divider from local
 bus frequency
Message-ID: <6e34260b-7d8e-4c86-9a11-6727f0c83a70@roeck-us.net>
References: <20240226165321.91976-1-eajames@linux.ibm.com>
 <20240226165321.91976-26-eajames@linux.ibm.com>
 <q6bl7sbskt4ukd3mylfgwpo6dmv444umdpycs6xp7ozd2kv335@syeymu62fczb>
 <2474f02c-c835-4691-b531-62c8c747aede@linux.ibm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2474f02c-c835-4691-b531-62c8c747aede@linux.ibm.com>

On Tue, Apr 16, 2024 at 01:09:04PM -0500, Eddie James wrote:
> 
> On 4/15/24 17:11, Andi Shyti wrote:
> > Hi Eddie,
> > 
> > > @@ -689,6 +692,20 @@ static int fsi_i2c_probe(struct device *dev)
> > >   	mutex_init(&i2c->lock);
> > >   	i2c->fsi = to_fsi_dev(dev);
> > >   	INIT_LIST_HEAD(&i2c->ports);
> > > +	i2c->clock_div = I2C_DEFAULT_CLK_DIV;
> > > +
> > > +	lbus = fsi_device_local_bus_frequency(i2c->fsi);
> > > +	if (lbus) {
> > > +		u32 clock = I2C_DEFAULT_CLK_RATE;
> > I don't see the need for initialization.
> 
> 
> Does device_property_read_u32 set clock if the property isn't found? If not,
> it needs to be initialized here. Or I can set it in an else statement from
> device_property_read_u32.
> 
> 
> > 
> > > +
> > > +		if (!device_property_read_u32(dev, "clock-frequency", &clock)) {
> > > +			if (!clock)
> > > +				clock = I2C_DEFAULT_CLK_RATE;
> > > +		}

		if (device_property_read_u32(dev, "clock-frequency", &clock) || !clock)
			clock = I2C_DEFAULT_CLK_RATE;

> > > +
> > > +		// i2c clock rate = local bus clock / (4 * (i2c clock div + 1))
> > You forgot to remove this.
> 
> 
> I actually meant to leave that comment to explain how the clock rate is
> calculated, as the reverse calculation in the code is a little more
> confusing.
> 

Partially that is because you implemented DIV_ROUND_UP() manually.

> 
> > 
> > Andi
> > 
> > > +		i2c->clock_div = (((lbus + (clock - 1)) / clock) / 4) - 1;

				= DIV_ROUND_UP(lbus, clock) / 4 - 1

Guenter