Received-SPF: pass (google.com: domain of linux-kernel+bounces-147639-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 16 Apr 2024 23:23:49 +0200
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Luca Ceresoli <luca.ceresoli@bootlin.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	linux-sound@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/12] ASoC: doc: dapm: various improvements
Message-ID: <20240416212349079fdffc@mail.local>
References: <20240416-dapm-docs-v1-0-a818d2819bf6@bootlin.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240416-dapm-docs-v1-0-a818d2819bf6@bootlin.com>

On 16/04/2024 07:56:06+0200, Luca Ceresoli wrote:
> This series applies various improvements to the DAPM documentation: a
> rewrite of a few sections for clarity, style improvements and typo fixes.
> 
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

> ---
> Luca Ceresoli (12):
>       ASoC: doc: dapm: fix typos
>       ASoC: doc: dapm: fix struct name
>       ASoC: doc: dapm: minor rewording

I'm wondering whether you could improve this patch by not rewrapping the
whole paragraph.

>       ASoC: doc: dapm: remove dash after colon
>       ASoC: doc: dapm: clarify it's an internal API
>       ASoC: doc: dapm: replace "map" with "graph"
>       ASoC: doc: dapm: extend initial descrption
>       ASoC: doc: dapm: describe how widgets and routes are registered
>       ASoC: doc: dapm: fix and improve section "Registering DAPM controls"
>       ASoC: doc: dapm: improve section "Codec/DSP Widget Interconnections"
>       ASoC: doc: dapm: update section "DAPM Widget Events"
>       ASoC: doc: dapm: update event types
> 
>  Documentation/sound/soc/dapm-graph.svg | 375 +++++++++++++++++++++++++++++++++
>  Documentation/sound/soc/dapm.rst       | 178 ++++++++++------
>  2 files changed, 494 insertions(+), 59 deletions(-)
> ---
> base-commit: 8f2c057754b25075aa3da132cd4fd4478cdab854
> change-id: 20240315-dapm-docs-79bd51f267db
> 
> Best regards,
> -- 
> Luca Ceresoli <luca.ceresoli@bootlin.com>
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com