Received-SPF: pass (google.com: domain of linux-kernel+bounces-147744-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: "Brelinski, Tony" <tony.brelinski@intel.com>
To: Erwan Velu <erwanaliasr1@gmail.com>
CC: "Velu, Erwan" <e.velu@criteo.com>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, Eric Dumazet <edumazet@google.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>, "Nguyen, Anthony L"
	<anthony.l.nguyen@intel.com>, "intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>, Jakub Kicinski <kuba@kernel.org>, "Paolo
 Abeni" <pabeni@redhat.com>, "David S. Miller" <davem@davemloft.net>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net] i40e: Report MFS in decimal
 base instead of hex
Thread-Topic: [Intel-wired-lan] [PATCH iwl-net] i40e: Report MFS in decimal
 base instead of hex
Thread-Index: AQHaegg6neZffGD5e0S+FmrljmaqmLFrshmw
Date: Tue, 16 Apr 2024 23:11:48 +0000
Message-ID: <DS0PR11MB8115E4BC956EDCC0EF61DB7B82082@DS0PR11MB8115.namprd11.prod.outlook.com>
References: <20240319141657.2783609-1-e.velu@criteo.com>
In-Reply-To: <20240319141657.2783609-1-e.velu@criteo.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ptnzhPTpFZ+CKZJ2BdTs+JDZgEEwF1sUnkAYm/M5zz1wehb2Vv7udF6PB44C?=
 =?us-ascii?Q?vb8uQEmkDbFMGy+7L1X8ymUNHaPB2UElti0j0nzGNr7CutP2XTG731jRG3Bd?=
 =?us-ascii?Q?4E5xOqO6RSORORxafHxh0G+RdHCb0ufk110IrcrVakGaJH6GDiOX3F04E4SD?=
 =?us-ascii?Q?cMOOb4IF3Ix9SpqccAYg3YgbY0Eb3OuNEoI8CpGLG0GIJ49IG+L8Pu1zNM4V?=
 =?us-ascii?Q?z+L7deN4IgHk5I+5VBAxN9alaa+aj8r2hBwlU1+86Hs8HQP5xWTlD70obP7l?=
 =?us-ascii?Q?K+GkjUXbaUDdDJ8x99TQwhc/vb5lODn6tLQvomTs98VT16Ku5JiS3r9yhoU6?=
 =?us-ascii?Q?pLiMcilo5nuyelU6G9nVWhHthDk1nmyj8FfHti2lrExzxxnFkM7rG3juT1vJ?=
 =?us-ascii?Q?coyVRC6SU4CVI6ObqAgZCMhs+OC//JX/kfxt3cA8g3ci1ojfHAkaZ3yDxUqH?=
 =?us-ascii?Q?RzwAk8dl92My4/n7QD3XmqmHcw1RzKaaJoyjREHfEdNsKPHgLjG8eqwqSEwJ?=
 =?us-ascii?Q?tj4rB+vKQDqAkjV2qPvG06KQddKf9Ad6GM1A+W1fBdjKXHXb2YVMcQXLC4ek?=
 =?us-ascii?Q?LtJ98Y3uFlzMPZmQBxp/2ng/D/tg3gi/Lj44uRhugIAQH+mFp64sMAAx12tH?=
 =?us-ascii?Q?5Uc9Qi1QU2JtX9pI9kkZEXByK+0KjojSAowIXHJJZb/ogUCiUJ3soCy5GKUo?=
 =?us-ascii?Q?yUER743JMZRZkxBnRGdotZhXLIFefALbOjXD+iRIBYQks/iYURD7nrkjTE/B?=
 =?us-ascii?Q?d/jHrBLnSnarSnknV1HOyn9Ya+y4ykNcfX+nZh1ZbdMoi7P5cCZ0vzte0r9m?=
 =?us-ascii?Q?zS8UtF/OAjdC8kbb/w8w22QSmH07YEMLNZCRCUum0J80AzvM/S0nQLVCkRYw?=
 =?us-ascii?Q?sd7Rc0FuqXfUnZzl2/JrsOJqH/CncSvwUN2Ppol5mFl5XpIALWDDD1i1iSxK?=
 =?us-ascii?Q?YBT3EvACUNtvRfhCBfIn/uPIxrtFlzB8y90bl14yLEYv0nVDELQdmZyOa1yx?=
 =?us-ascii?Q?FAqt04ztwvIzHXogQmmbSvz5ZZGyLZADx43EDHYqO754CI2FTyq5wsD10Kj7?=
 =?us-ascii?Q?0DdJ1r9PhB6wMe+4mVbZonVgIH021zPyegTgapdAlayGtXeQpTkgDcwmqok9?=
 =?us-ascii?Q?oTft/VE9ePUG4lGJCZlH05oRh+ertpQJAXipqgDeHkhSAWMhRGfXg5Z1mpFs?=
 =?us-ascii?Q?QMmKvm9MDtC/YtY6UBQDjKCwE7ZvNWCWR5+9j6vwornVCU8iBmBFsEOUq6r9?=
 =?us-ascii?Q?BUNkEE02JIFCl1l4wfACGhUrSDAIwePYIf3ay/UKSLs9Mq8Cn338JED8bkj3?=
 =?us-ascii?Q?iXUzbpju9IcxdhcgZlHI/8AziDWeaRUy8QcLug8MGYhI/M4JEdz0FLZH23P7?=
 =?us-ascii?Q?UFQXu7beU69Cgm1Nx/ZUJeMpaoI3ouS5K5zd3j1PLeIsPonOKPPV4nmCh4QN?=
 =?us-ascii?Q?k3JFoKvk9Bb4y0L36kD4S2RcwgJ1Gno7yUFeeKF0o9DdwSDbmTdCFkMpuKwh?=
 =?us-ascii?Q?4KnHzKnci3paNg6FHopLhLd59vBrQLHoil5yKoOXJxw7zD+P0EZyShJfIk3r?=
 =?us-ascii?Q?IQJUL8WTubAhpYsZNkFLiBNueKVFKf8FUqfhS5AO?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB8115.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 118f9975-ea25-4651-65cf-08dc5e6a97dc
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2024 23:11:48.6926
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Hkh84HHn7oyJHkRj6fNYKPVH2ziXZxLV2VdNm5QNRQPeUuHLqBb51VoHPESRmokkGiAHwAH7IRw7qOYiiBE9agJtdekMroeEzjkH+QF/Mqw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7823
X-OriginatorOrg: intel.com

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Erwan Velu
> Sent: Tuesday, March 19, 2024 7:17 AM
> Cc: Velu, Erwan <e.velu@criteo.com>; linux-kernel@vger.kernel.org; Eric
> Dumazet <edumazet@google.com>; netdev@vger.kernel.org; Nguyen,
> Anthony L <anthony.l.nguyen@intel.com>; intel-wired-lan@lists.osuosl.org;
> Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; David
> S. Miller <davem@davemloft.net>
> Subject: [Intel-wired-lan] [PATCH iwl-net] i40e: Report MFS in decimal ba=
se
> instead of hex
>=20
> If the MFS is set below the default (0x2600), a warning message is report=
ed
> like the following :
>=20
> 	MFS for port 1 has been set below the default: 600
>=20
> This message is a bit confusing as the number shown here (600) is in fact=
 an
> hexa number: 0x600 =3D 1536
>=20
> Without any explicit "0x" prefix, this message is read like the MFS is se=
t to 600
> bytes.
>=20
> MFS, as per MTUs, are usually expressed in decimal base.
>=20
> This commit reports both current and default MFS values in decimal so it'=
s less
> confusing for end-users.
>=20
> A typical warning message looks like the following :
>=20
> 	MFS for port 1 (1536) has been set below the default (9728)
>=20
> Signed-off-by: Erwan Velu <e.velu@criteo.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Tested-by: Tony Brelinski <tony.brelinski@intel.com>