Received-SPF: pass (google.com: domain of linux-kernel+bounces-147752-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <29daff1f-b5da-42bb-a70d-dfc649e22f74@intel.com>
Date: Tue, 16 Apr 2024 16:29:49 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 54/74] x86/cpu/vfm: Update
 drivers/platform/x86/intel/ifs/core.c
To: Tony Luck <tony.luck@intel.com>, Hans de Goede <hdegoede@redhat.com>,
	=?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
CC: Ashok Raj <ashok.raj@intel.com>, <platform-driver-x86@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <patches@lists.linux.dev>
References: <20240416211941.9369-1-tony.luck@intel.com>
 <20240416212223.9681-1-tony.luck@intel.com>
Content-Language: en-US
From: "Joseph, Jithu" <jithu.joseph@intel.com>
In-Reply-To: <20240416212223.9681-1-tony.luck@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WjdxdXBlTG1JVnkyeTVxWW1DeUxoZTVKamZFQUQvaG9ySC9mT2UzcTQ5V21j?=
 =?utf-8?B?a0ZyK1QyTmgyNWd6bVNKUmZCeGFheHVtSFRQQm1YOHYrb00yeWkwWC9JVzF4?=
 =?utf-8?B?ekZDeDUxM1l1Y2g1WlZYZmlDdWVaTGd5VWlmWVFFcnphT2t3UXVkR0FIR3NS?=
 =?utf-8?B?ZWx4RFFmUnlCRFdqbC9MT2NIRndtdFBRNVdrbEI1ZSt5YUZoRFhwcC9qeVpY?=
 =?utf-8?B?eDhHUjBNQTdxSVZkdURKNXZLSHBIZ0JFZ1JBMTNHQ24xcCtVRnp4QUhrUTdN?=
 =?utf-8?B?ZkhWRTE0QTRIV2FqYzJ0ZUsxR1Jka2hkY2ptRElUSDQwL21HaHlmRUhhRkhT?=
 =?utf-8?B?VUszR1pPY0RWYjl5bkpPUnlTMW9kY2NoYmVUL2FUWDN5OXp3cXlYVkloelAy?=
 =?utf-8?B?SHQ0RTlMZGZpcmhucjVTc1dsWkN5RkN0eEQrZTVuY0tQRlpGMlUvdVQ0eVJP?=
 =?utf-8?B?UmJ6RTk2OEdUN21mVE9mVW9sVTZCdVQ1U3FiYk42TllZa21rMW5tWDUwakty?=
 =?utf-8?B?ZHoyNEFaOFZNYlZYVVJiUDBkdTc1dE1JcnlWTThGaXBmMVF6S1psdGp6VmJ3?=
 =?utf-8?B?NnFST3hIN0IzSXBGZ2krQ2MxNVEraWU1TGd4cG9hbGtpbW5wc0lXcmRKM0lY?=
 =?utf-8?B?emx0TWU4a3NTVm1uSlNXeEZtTld4dEdsMlpNL1Q4Zi9rUFEya1QxSjExWXBR?=
 =?utf-8?B?cmVsNmFQaHpkNElFMkJLUWhTL0VVblJKS08xNys0WFJ3azBvWkxubi9Tckxy?=
 =?utf-8?B?aHRhSEkzN0k5SjZEeXpldVN0M2FtOUxzWEJQUjZFNExDbHI1K3VJaWYramdK?=
 =?utf-8?B?bDNkQzhBSzFBbEZlR3VobEpKT3RWUkZMWGV6bml0eGF2ZlRpWEg0ZXNLQnZk?=
 =?utf-8?B?elFXajZsRjdGS0wwd3ZzUjduUmpMRmtMd3lNdm5KaFFxVCs1TURGUkRhT3lD?=
 =?utf-8?B?MVhmUGR3bHZiaEpFaHhJV0duRTI1eVlFanBuWHZuS3pNNjFjb1NadTV2Yytq?=
 =?utf-8?B?dlA3NDQ1bUdvY1dTSExBWDRXQnQzeW8xSWJaZzNaWjBhMk9UUE9mVFFJREhH?=
 =?utf-8?B?SlJ3U2c3bDQ2cXUwNVdId2JQRGhRK1pQQjJxSHdqajY4S0RDRTdzWHNJMkQ5?=
 =?utf-8?B?MzNxL3V0OFpQY2ZabVJqK0JvYjZjS0lqVlJvQjFwTzZyZW82ODVCZ09Zalp1?=
 =?utf-8?B?VlJ0MnNJUCtOeVpGNzVsdE4xUFU4SkpTY1ZWekxEZDJPeVNRTms2c2U3UWlC?=
 =?utf-8?B?clRwT1gwRDVER0NORHY3N2thS1dwMU03S2YyOE03WmtpQTJ6b21NSGMzVjlB?=
 =?utf-8?B?anM0cTNFaHNrTEJCVVk2L2ZadWZBSDZCeC94UnRidmZCNkRjbjNQaEJHT3Nw?=
 =?utf-8?B?cXQyeEptd0dDa0tlckxvZTZXeWFlSGhneS81Q2laRHYrTTRPUUFrWDRQbkx4?=
 =?utf-8?B?ZXNwdGNnbjYwWGFlMWw4RTVUU1J4NXZ2MFhxLzZkVUxyQ3hEcWpiRTdFWWk1?=
 =?utf-8?B?MnVMNERGQjZBNmJhVktLSEhHWkgvT01hclBzQks0Zkh2N0xQNWRXZkx4bHda?=
 =?utf-8?B?WDRqVEd5SCtSVXVWeFIyRnFEcEtSdEFKbk1WS3JYZ3dsRnhLUVR3d2N1Q2F1?=
 =?utf-8?B?SitJaWxvaEZDc2ZsMDNyK2dlWEJJWExPUCtjYkl3RU5SSk1FK1dtd2tXd01l?=
 =?utf-8?B?WkQzN2ZZUVBQamZrM1U1eGRLb3EwWXVWM2VndmQwUmVWVTZ6aFQ5U0xBcTBr?=
 =?utf-8?B?T3E1My9KNitaSWh3b2JxOTJZMHU2QU04L0xvT0drWlZtd2lRZVp5bE9PT1BW?=
 =?utf-8?B?TkNXcXFmMW5mZFRLV29pS1QvSHBQQ2lJN2lOSHpIaWpoQU9IQ3B2ME9uV3J5?=
 =?utf-8?B?WWVxcGNiQncybWVRU0g4WUFrVTNFK1JYN1NvZHRjVjI4LzVpVUNSdHBhcEkr?=
 =?utf-8?B?Q1pSNmY3clBMRDVMUG9yaG1MS0dkOFRyWWVzNE9UYWthOGZpMFdnRkRFeVY2?=
 =?utf-8?B?d2hHL0ZWZ0h1UG5oRTd2cFpZNTJCZG03OXlZUnhadytaYlU2RFg2Zmhwc1BO?=
 =?utf-8?B?Q2doN3d0aWRRNmdaUENrbXpYa3JVbXdaU1BjakpyNmk1ekZJeS9hNTBkbXZ2?=
 =?utf-8?B?cUJqakNrdHNqdnY3T1BkV2h1SG5yWVRDQmV6TU9NMk5GaUUxejFhTy9QVG9h?=
 =?utf-8?B?ZEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5332c19f-bceb-44ab-7600-08dc5e6d1d73
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3768.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2024 23:29:51.9545
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oNzIUqWd8VcXRu+9VzaIwgcfH0853Pvs7ytm5cnlDVG6QODt0Te7FcRQNQfxWoLvHckJ3ox+4/NyLT7GKUJByw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6730
X-OriginatorOrg: intel.com


On 4/16/2024 2:22 PM, Tony Luck wrote:
> New CPU #defines encode vendor and family as well as model.
> 
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---
>  drivers/platform/x86/intel/ifs/core.c | 15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/platform/x86/intel/ifs/core.c b/drivers/platform/x86/intel/ifs/core.c
> index 7b11198d85a1..33412a584836 100644
> --- a/drivers/platform/x86/intel/ifs/core.c
> +++ b/drivers/platform/x86/intel/ifs/core.c
> @@ -11,16 +11,15 @@
>  
>  #include "ifs.h"
>  
> -#define X86_MATCH(model, array_gen)				\
> -	X86_MATCH_VENDOR_FAM_MODEL_FEATURE(INTEL, 6,	\
> -		INTEL_FAM6_##model, X86_FEATURE_CORE_CAPABILITIES, array_gen)
> +#define X86_MATCH(vfm, array_gen)				\
> +	X86_MATCH_VFM_FEATURE(vfm, X86_FEATURE_CORE_CAPABILITIES, array_gen)
>  
>  static const struct x86_cpu_id ifs_cpu_ids[] __initconst = {
> -	X86_MATCH(SAPPHIRERAPIDS_X, ARRAY_GEN0),
> -	X86_MATCH(EMERALDRAPIDS_X, ARRAY_GEN0),
> -	X86_MATCH(GRANITERAPIDS_X, ARRAY_GEN0),
> -	X86_MATCH(GRANITERAPIDS_D, ARRAY_GEN0),
> -	X86_MATCH(ATOM_CRESTMONT_X, ARRAY_GEN1),
> +	X86_MATCH(INTEL_SAPPHIRERAPIDS_X, ARRAY_GEN0),
> +	X86_MATCH(INTEL_EMERALDRAPIDS_X, ARRAY_GEN0),
> +	X86_MATCH(INTEL_GRANITERAPIDS_X, ARRAY_GEN0),
> +	X86_MATCH(INTEL_GRANITERAPIDS_D, ARRAY_GEN0),
> +	X86_MATCH(INTEL_ATOM_CRESTMONT_X, ARRAY_GEN1),
>  	{}
>  };
>  MODULE_DEVICE_TABLE(x86cpu, ifs_cpu_ids);

Looks good to me:

Reviewed-by: Jithu Joseph <jithu.joseph@intel.com>


Jithu