Received: by 2002:a05:6500:1b45:b0:1f5:f2ab:c469 with SMTP id cz5csp301014lqb; Tue, 16 Apr 2024 16:58:56 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWpzX1n1HF5j7fRiSYzpDIDe+t681lLYIgxW3sVUEBV3Qch79Yv80+d4S3PR5ymtby9oKyyxlqFLGyroCP6inp+yLyRHY2v6kenkREloA== X-Google-Smtp-Source: AGHT+IEZntaVvp/ZT+pdbAJqTiLATHqPUCUiQidbp4QC8NrDN2qhetcNGXDvl9KP3Jk925BBtwQr X-Received: by 2002:a05:622a:58f:b0:434:84dc:4593 with SMTP id c15-20020a05622a058f00b0043484dc4593mr17118904qtb.60.1713311936566; Tue, 16 Apr 2024 16:58:56 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713311936; cv=pass; d=google.com; s=arc-20160816; b=QHZjGsqHvo7F901mXEV3ErrfFq2MXvZ7G5CrotuOTafbxEaf8vGaXhX/B7ToH+PvSp 1D4hA2gsDWuyNLZvbhqrPD7G1/M1abf7krLmde4foMk0sUueOOmjlLN6ua46NHK6K2z5 jxy0e5dnaT4lWEQwzCev2PvU9FIY2fXul3RxfVzn+rUkFRujnbUoYMiye5OIVsZuzfJb 6cZLYd6nCBAZFH2MARnpcPPpejGW0BIxzUfzSWldy4uCtEzK6WLqL9TlD1M9H0cFuHrf OF3/by3aHbL4/EC5N0C6hSNUBRFnWFPidIK6RI0veFynO6miaTqUJQ0iKxwdRJ8Qh84T UCxQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from; bh=GG731+4eSOI1wPpxOZEPfivD97cs9fSCExb8Ty/FLIM=; fh=EaVNV8gKHS73tSa0PfwfCJhAdPfizlMjT2zacFzFq/Y=; b=ILJhRa2QWycpn0MDHj2dU1cbcXdv34idL4x3mmuTg9no9DJvO10O6jgY3AXnD7afcY swL/yVZRWizl8Cu/XsmPd8q6AViOM4GmGTXbVvSxkcpbgM1S2yzwib4mjlD6e1GNmikx BWdHpQj4BsHsHBY1ERvuHuliksbGHJctuLI5wAUNQfyiivMmyxDaKV2TYzBgoilLaAEx f2V6bzhzhmuEFCJAyniK4FW2LKfA3lkIi2OTBKyxqVKTWBEgHyVT9V9U0diG3KcCWYYi /BDcw3qPIER+epfES4wMk/bMK0WKeU25vZGdbMcedBpir4arxaOhSa6+1owjDL4VzONX hROQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=somainline.org); spf=pass (google.com: domain of linux-kernel+bounces-147775-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-147775-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id p14-20020a05622a13ce00b0043663404342si13632251qtk.705.2024.04.16.16.58.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 16:58:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-147775-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=somainline.org); spf=pass (google.com: domain of linux-kernel+bounces-147775-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-147775-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 45FCB1C22037 for ; Tue, 16 Apr 2024 23:58:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 51B5A13C686; Tue, 16 Apr 2024 23:57:55 +0000 (UTC) Received: from relay06.th.seeweb.it (relay06.th.seeweb.it [5.144.164.167]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74AB213C3E7 for ; Tue, 16 Apr 2024 23:57:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=5.144.164.167 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713311874; cv=none; b=HZsZTfoJwWTlBBH7IEjsScXFUsgo2QB0rH6Y7zdotI2b8vIoW0rD1eEQpuiNXi7khYpG3FaEaTGX6dC4CtGeuP6HM+8mYXmfpsQJtdPn3DuHjdwy/NE1Dz/tHpMN+aDUQz/eKSc+hnvbE0PIcbugG5nYa9gqMt0zm7mTFw+lzAo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713311874; c=relaxed/simple; bh=va9fPRtJ0SkXGycOhlB8Ezr85RrN/MriF/E14uxzkS0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=h9i+DjFCw+kgR4gTgc7x+wbovs6QMdJUXFBOMsEqFnbvpGMSKluHrUUseeQxMay7wJ5lTQfBpwpkqSJaxf4u+w/tiynDuaddc2phGbSVBrW88bcYvbZqUwbb4sQhre8Eogz6fHW2m4e5LPYQVV1Ra7jCSOVU87GuLheLtreZbLI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=somainline.org; spf=pass smtp.mailfrom=somainline.org; arc=none smtp.client-ip=5.144.164.167 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=somainline.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=somainline.org Received: from Marijn-Arch-PC.localdomain (94-211-6-86.cable.dynamic.v4.ziggo.nl [94.211.6.86]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id EB4833F0E3; Wed, 17 Apr 2024 01:57:50 +0200 (CEST) From: Marijn Suijten Date: Wed, 17 Apr 2024 01:57:47 +0200 Subject: [PATCH 7/7] drm/msm/dpu: Rename `ctx` parameter to `intf` to match other functions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240417-drm-msm-initial-dualpipe-dsc-fixes-v1-7-78ae3ee9a697@somainline.org> References: <20240417-drm-msm-initial-dualpipe-dsc-fixes-v1-0-78ae3ee9a697@somainline.org> In-Reply-To: <20240417-drm-msm-initial-dualpipe-dsc-fixes-v1-0-78ae3ee9a697@somainline.org> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Archit Taneja , Chandan Uddaraju , Vinod Koul , Sravanthi Kollukuduru Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jordan Crouse , Rajesh Yadav , Jeykumar Sankaran , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Marijn Suijten X-Mailer: b4 0.13.0 All other functions in dpu_hw_intf name the "self" parameter `intf`, except dpu_hw_intf_setup_timing_engine() and the recently added dpu_hw_intf_program_intf_cmd_cfg(). Clean that up for consistency. Signed-off-by: Marijn Suijten --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c index 965692ef7892..34d0c4e04d27 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c @@ -96,11 +96,11 @@ #define INTF_CFG2_DCE_DATA_COMPRESS BIT(12) -static void dpu_hw_intf_setup_timing_engine(struct dpu_hw_intf *ctx, +static void dpu_hw_intf_setup_timing_engine(struct dpu_hw_intf *intf, const struct dpu_hw_intf_timing_params *p, const struct dpu_format *fmt) { - struct dpu_hw_blk_reg_map *c = &ctx->hw; + struct dpu_hw_blk_reg_map *c = &intf->hw; u32 hsync_period, vsync_period; u32 display_v_start, display_v_end; u32 hsync_start_x, hsync_end_x; @@ -118,7 +118,7 @@ static void dpu_hw_intf_setup_timing_engine(struct dpu_hw_intf *ctx, /* read interface_cfg */ intf_cfg = DPU_REG_READ(c, INTF_CONFIG); - if (ctx->cap->type == INTF_DP) + if (intf->cap->type == INTF_DP) dp_intf = true; hsync_period = p->hsync_pulse_width + p->h_back_porch + p->width + @@ -223,7 +223,7 @@ static void dpu_hw_intf_setup_timing_engine(struct dpu_hw_intf *ctx, DPU_REG_WRITE(c, INTF_FRAME_LINE_COUNT_EN, 0x3); DPU_REG_WRITE(c, INTF_CONFIG, intf_cfg); DPU_REG_WRITE(c, INTF_PANEL_FORMAT, panel_format); - if (ctx->cap->features & BIT(DPU_DATA_HCTL_EN)) { + if (intf->cap->features & BIT(DPU_DATA_HCTL_EN)) { /* * DATA_HCTL_EN controls data timing which can be different from * video timing. It is recommended to enable it for all cases, except @@ -518,10 +518,10 @@ static void dpu_hw_intf_disable_autorefresh(struct dpu_hw_intf *intf, } -static void dpu_hw_intf_program_intf_cmd_cfg(struct dpu_hw_intf *ctx, +static void dpu_hw_intf_program_intf_cmd_cfg(struct dpu_hw_intf *intf, struct dpu_hw_intf_cmd_mode_cfg *cmd_mode_cfg) { - u32 intf_cfg2 = DPU_REG_READ(&ctx->hw, INTF_CONFIG2); + u32 intf_cfg2 = DPU_REG_READ(&intf->hw, INTF_CONFIG2); if (cmd_mode_cfg->data_compress) intf_cfg2 |= INTF_CFG2_DCE_DATA_COMPRESS; @@ -529,7 +529,7 @@ static void dpu_hw_intf_program_intf_cmd_cfg(struct dpu_hw_intf *ctx, if (cmd_mode_cfg->wide_bus_en) intf_cfg2 |= INTF_CFG2_DATABUS_WIDEN; - DPU_REG_WRITE(&ctx->hw, INTF_CONFIG2, intf_cfg2); + DPU_REG_WRITE(&intf->hw, INTF_CONFIG2, intf_cfg2); } struct dpu_hw_intf *dpu_hw_intf_init(struct drm_device *dev, -- 2.44.0