Received-SPF: pass (google.com: domain of linux-kernel+bounces-147777-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID:
 <MA0P287MB2822D66AFB826428DB13E527FE0F2@MA0P287MB2822.INDP287.PROD.OUTLOOK.COM>
Date: Wed, 17 Apr 2024 08:00:28 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/3] dt-bindings: mmc: sdhci-of-dwcmhsc: Add Sophgo SG2042
 support
To: Conor Dooley <conor@kernel.org>, Chen Wang <unicornxw@gmail.com>
Cc: adrian.hunter@intel.com, aou@eecs.berkeley.edu, conor+dt@kernel.org,
 guoren@kernel.org, inochiama@outlook.com, jszhang@kernel.org,
 krzysztof.kozlowski+dt@linaro.org, palmer@dabbelt.com,
 paul.walmsley@sifive.com, robh@kernel.org, ulf.hansson@linaro.org,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-mmc@vger.kernel.org, linux-riscv@lists.infradead.org,
 chao.wei@sophgo.com, haijiao.liu@sophgo.com, xiaoguang.xing@sophgo.com,
 tingzhu.wang@sophgo.com
References: <cover.1713258948.git.unicorn_wang@outlook.com>
 <032c06642b01f06c86ba8bcd2108d18c005b57eb.1713258948.git.unicorn_wang@outlook.com>
 <20240416-pretext-cognitive-295526072596@spud>
From: Chen Wang <unicorn_wang@outlook.com>
In-Reply-To: <20240416-pretext-cognitive-295526072596@spud>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: MA0P287MB2822:EE_|PN2P287MB1455:EE_
X-MS-Office365-Filtering-Correlation-Id: d57cae31-fcdb-4ecf-c60c-08dc5e716694
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	8sudoPhejsCiyen+dYIAbGqKo5shvPfSQORoUbvOMDqlhR2id/n62a3p70de1+47w1KkAfdTDGjo1PqJ47YOwCJNi2R8P8t22TzUcPQIXPNtmWXm8GKgWdUpqwKnxVlFVi1HQdFBugZbYr0KOgUTC3+XGS0W5gmmB/37IjPgHVXxcvX6Vlqj2O4Iu+F97NezI0pqod6V6fHcL/ewMinI35bo147UFBNNpRkJCqhrGgJUuu7HWnF8lVl7coJ+5CoJOTEPjiaIEQJO8RoQGqUtLpsxmPI8S2TVxRKhG0EHm/u95aKZN9e00ETm3kaJXak/zEgPs5SH32ey4OJhQad6lZrbo5DtbE+dwpP71clczH2EizK1+M3JgT+4f2MsIBZDqTU55R3jXL2vM9RzFkAtdX5EDxn1Rg1rmwunsnY1uKQQAY0eIZJ0KeLyRonztOuD5aVMBOD5TQmI6mHLu8LlU06hg5k/AAEMwJvAoTr2yap1PE6XkxIbfbkYHebLqXPzZp/SL2Fne6GIiwrrI9ejIDir03x1GDB/1lwes1Bl17jWBos+pmjSPYEjKMEX5cw9
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bkN1eWd5azJ1TGxtWnppL1ZuQ3hSNXZVSXgzQlNmRjlWQjQzeXdxRGxRMDQx?=
 =?utf-8?B?TGpESmxQVjExYkczOTBhS3h4UVlla0xZaDlQdGFBZUFiUlhQOCtvMmNkazlN?=
 =?utf-8?B?TFZ4Q2RXaHU1QjcvOUdoTEdVR0dBTk9xZ1NjZVVyeTBrRU5xZzh4cURjbUdW?=
 =?utf-8?B?M3lBMmNlQkV6RXhKRWNwS2RwR3BDSnljdXU2VGdiU0RBU3l1cVZlVnZJWXoz?=
 =?utf-8?B?VDE4R2EzVXFWYklZUHk4TE13TEg1WUw3cUFveU91RUF3ZXJuVHlQNmlrQ1hi?=
 =?utf-8?B?U3JLWlh6VUs3TkhnVXh4SnhlNjY2QklGWjRXTWMzS1AxUTY5SGpyT0hWcCtS?=
 =?utf-8?B?YXlVOHJ5MVYwdWRySUF3MnFyLzU5SU40Vjk1Z1VQVkxIbjNhQlRyNkh3TFh6?=
 =?utf-8?B?MFdTbXZNNEpwdFpqQzhCN1JuQ1ViWFZqWEZFcUF5NmQ1bEJnL2tZa3NpVGJK?=
 =?utf-8?B?NDRSSFRhUXl0c0VINHBZVlFhcTB3WGNENlRXbEd2ZXNKbFA1WC8zcitnS1Av?=
 =?utf-8?B?N3VpbkkydlNnZ3pSenNMZXB1dlhBdzBHMVQ3SEQ3Zm90YnhiQnN2SklsQmlE?=
 =?utf-8?B?S3BzWHpjS2hHTU12NVV0M0ZpamRsSmtSSFFuUWpzL2pRNWxFeGFodk13TUxo?=
 =?utf-8?B?Y0hkQXlRTDdRc0FYWVJvZmtCa0cybmg5bGNPekhacm9ORktsWGxJVE0zQnpB?=
 =?utf-8?B?RXdBZlQ1QklKMmZPU1Q4aUpXWGc0UkREQ3JKd1pZTHFSUlVieU1wTVEwdHJU?=
 =?utf-8?B?TnI2dE1sSjhPSUYvOXhwK1Jod3pGZTNZbEdpUTJlK3ZmQk82TXhpUlNTQjJ0?=
 =?utf-8?B?cUZWeEQ3Nysrc0ZRQVJERW5ITmROa1ZINHdHMDk2d3dKM014d202K2k1RWtE?=
 =?utf-8?B?d2E5angzc3V5a211RzlkckloblNUL1pHRUc5OUswSjFqQjhOMXJzMG1mOHA3?=
 =?utf-8?B?TVBUQTVkN0tqdGxqYlVMNEMyMStNa1RWM0RMYWwyYi94UWd5YVhGTyt5V1hR?=
 =?utf-8?B?VFFEclBiYTkzZ1JYRFFGVERUT1JFRGVYL0Uvd0xrZFV5czVPOXdpU0I3SVp0?=
 =?utf-8?B?WkJiaFNFek1qTDhvVW04ZXNMQ05TT3BremNZdEFuOCtaV1BHMmZ4Ym8yZENk?=
 =?utf-8?B?WktMTW5wN0FMbWlYeVp6NjQ1c3l0cDRRWkJvT0xoeXlzNWMzaUlMSm8wcVdH?=
 =?utf-8?B?SGJBUUhVZE1lQ2JqRWg4Qm04WklXSWJqeThqVnJiMjBnZjBmQm1xMFpZTHUy?=
 =?utf-8?B?UmVscFR0WkIxWThzZm44TTJZVTNQWWt6ZXZ3TTQrNDdybE0wLy9vQzBzWXJH?=
 =?utf-8?B?RlpuVjBSNHIvMEVzV2tBaWhHZU5jM0IyKzZTV2JabzRvL2QzeWtsdHE5bytX?=
 =?utf-8?B?WGNDZXNydjMyZm9Ud1JtRkNSdGt4dlErY1doeEdaTXBYMmlqN0tvVUhZb0xw?=
 =?utf-8?B?a0ljbU1ZR3drRzhaMTBpdWdCVWVxb1VCTkxad0NjMTF2T3d0c2QzWHhtb01j?=
 =?utf-8?B?dENEQkRuSW1nK2RiWGNOVDA3cFprdlVpdzZPTFc3a1VRVm9FTkltZU1uVVN3?=
 =?utf-8?B?MVpwYmNHbFdrMCs1STlFMDFuNXpWdUZaRW00Y0ZDTHhiZEQ5QzJsNnVXM0lt?=
 =?utf-8?B?bXR3eGVYb0duaFhKRmpJc3hVRnFIVzBuU24xQmhlRVhYbEZTeXNHNy9DNk1M?=
 =?utf-8?Q?UkWHycfN7INId+w8xLbh?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d57cae31-fcdb-4ecf-c60c-08dc5e716694
X-MS-Exchange-CrossTenant-AuthSource: MA0P287MB2822.INDP287.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2024 00:00:32.7793
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN2P287MB1455


On 2024/4/17 0:44, Conor Dooley wrote:
> On Tue, Apr 16, 2024 at 05:50:37PM +0800, Chen Wang wrote:
[......]
>> +    anyOf:
>> +      - minItems: 1
>> +        items:
>> +          - description: core clock
>> +          - description: bus clock for optional
>> +          - description: axi clock for rockchip specified
>> +          - description: block clock for rockchip specified
>> +          - description: timer clock for rockchip specified
>> +
>> +      - minItems: 1
> I don't think this minItems is needed, this is for one device which has
> all 3, no?
Yes, SG2042 requires all the 3 clocks presented,  I will remove this 
minItems.
> I also think this combination should only be permitted for the sg2042,
> since it is not valid for the existing devices.
Yes, I will add condition to allow this combination only for sg2042, 
thanks.
> Cheers,
> Conor.

[......]