Received: by 2002:a05:6500:1b45:b0:1f5:f2ab:c469 with SMTP id cz5csp314465lqb; Tue, 16 Apr 2024 17:31:48 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVPAlRB4lLJiT5Qdc9Sz/Buv94xtSt5p5CtDrr+rhtdHxzYaoat33+rVEKfmB9fmyHxSdzZ1psjLnrcwTyT9EEzMmntUN39I5Rjv+SK8w== X-Google-Smtp-Source: AGHT+IFx2DOeE4n9JYzOTqEzmYSYNLF+r/Phtv2Lo7yqPvyCoE2eTQT3J88OpXhdAODgH3TqGQrU X-Received: by 2002:a17:907:1709:b0:a51:d7b1:daa5 with SMTP id le9-20020a170907170900b00a51d7b1daa5mr9039201ejc.65.1713313908133; Tue, 16 Apr 2024 17:31:48 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713313908; cv=pass; d=google.com; s=arc-20160816; b=1BOlqbFb6Gju2Kl1pbfvZv5LJtGan8ifHSvG0+b/6KxuwJdCIbZRziYTX2+FmCurkg j0Mgd9NhSdOv+459FqTw9hnO4Emw5+yxamagVsD00yYoZdl91elmLM/EqFKVhyJWlalk I8tffEreApuW+bRE7hhVkTCrDlGtqb/8fg8d1/3Sh7u4rP+8WivHTt4W5ws5BPb8WGbP +F7Xe7SOQkTthMIam1kSzRuVjHa4QzRweDubybTAfV+4z8k+CL485pADLJLVzku4+3GA njrHdRxYK6UFrwUXCWBkl4/HmJHey6iGTs0CBfM0pGwKy9z33N6yCMFzbOuXx+oF6x39 NdHg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=CvfKII9Ey67SD+8qh7yMsDVcRpvNqlMhWe2P/D6dDSQ=; fh=Qc0bkhec2f8DfTTPuSAXBp/pqWv4YY3VaK3QbodyFVw=; b=eM7opzzagmTo4znAG32gEbnnvoXbuSLF4gkXHatZcHZlJtUXEztL+LUxzFOv7ykq7F VMyggi5f06nKfJI7xiCy4ubd24wSLN7ddhZtJWD3J6pTU3C8l9DS1v2Z3gukXID/ECsU YsP3xnpFsUZ7V05s4Itx4nqH2RNqabHk9lChR1sKm+4D4DCmTq3oYLifafXKVcDPeg+3 toAORdd8/E+ZppQpda7TGVsdnIAhqAXA91QUgEgF7SNuLaA5tYbOqSVh5aMzUYBcUtNz iBpdpRiFKiG0Nx505w8QBga3apRO4wKSayt9acX+o0vybyYD73VMvb46JaHFyCj8cGvl IjxA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=MeZrTq7d; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-147540-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-147540-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id gf1-20020a170906e20100b00a43db2d8b90si6174407ejb.325.2024.04.16.17.31.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 17:31:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-147540-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=MeZrTq7d; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-147540-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-147540-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 5C4001F229EC for ; Tue, 16 Apr 2024 20:55:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8FD496BB4B; Tue, 16 Apr 2024 20:54:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="MeZrTq7d" Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38EE05A4D8; Tue, 16 Apr 2024 20:54:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713300875; cv=none; b=QJ05PsZ+pB3/UhwOjurEObKJJevfbgbdC28XfD3lPsFK4CTH7q94SgNLyBRT7cZ5l5qXlIhfH/dA4RpaOYaynjXEiCL1lm4dLeHffwnHaCblFYnZtPG0aMfr1wSu9zZiL4JwFZsCnIx6yNK8XHIPNpODqXU5T1ETk1yso72Aub0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713300875; c=relaxed/simple; bh=znt09ZKf/WSyDQZxpbQsoP4CergUzZbVINbdKDx3s4k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PrD9E5qyvLMeaTRwCLzi8anKs/zfe7rUufI8w65HbmYMfVfX9FxDVlRc8CKT8tmG/p/x1NQDnYO0GTOkWefRReMFiLqgpzoIQE/nWHiwd7FKDl2jGB8qb/CrS7MhvhGV+cyOY6V85Fsn8P69204FqBeSENhnu91B0tPEighXwus= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=MeZrTq7d; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=CvfKII9Ey67SD+8qh7yMsDVcRpvNqlMhWe2P/D6dDSQ=; b=MeZrTq7dInM0fW1d4LyApMradW diRVdeeO0287HG7lWB08jMShf06reiRYo6cQXffE+rHrAMCkn52vV9rcs/rMSoiBdQr/Ek+ws/3Kj nUuOPSxy3MBHZjJQgaT+4uqXcXiuVpVymhp9M7I4sCcOk789C3LKz02aK8WBtuxZOVCkCE+5eSeMa z31e0OtWV0T8rXKhEqznvlezTzD0YWbfI21SDNJ4E08jsIzRslNWZ/0mcn5w+7lvsSuGAIYy9PsWL 9YSb0glxtmA4yR/KzKYB4I//Tkz0NkzU3fv/gQOj0TSg8Qe7NTWTLhjSappGg9728TN0X/lNjDGOm WowEWrJw==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwpmk-00000001OPN-2QDc; Tue, 16 Apr 2024 20:52:10 +0000 Date: Tue, 16 Apr 2024 21:52:10 +0100 From: Matthew Wilcox To: Sourav Panda Cc: corbet@lwn.net, gregkh@linuxfoundation.org, rafael@kernel.org, akpm@linux-foundation.org, mike.kravetz@oracle.com, muchun.song@linux.dev, rppt@kernel.org, david@redhat.com, rdunlap@infradead.org, chenlinxuan@uniontech.com, yang.yang29@zte.com.cn, tomas.mudrunka@gmail.com, bhelgaas@google.com, ivan@cloudflare.com, pasha.tatashin@soleen.com, yosryahmed@google.com, hannes@cmpxchg.org, shakeelb@google.com, kirill.shutemov@linux.intel.com, wangkefeng.wang@huawei.com, adobriyan@gmail.com, vbabka@suse.cz, Liam.Howlett@oracle.com, surenb@google.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, weixugc@google.com Subject: Re: [PATCH v10] mm: report per-page metadata information Message-ID: References: <20240416201335.3551099-1-souravpanda@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240416201335.3551099-1-souravpanda@google.com> On Tue, Apr 16, 2024 at 08:13:35PM +0000, Sourav Panda wrote: > +++ b/include/linux/mmzone.h > @@ -217,6 +217,10 @@ enum node_stat_item { > PGDEMOTE_KSWAPD, > PGDEMOTE_DIRECT, > PGDEMOTE_KHUGEPAGED, > + NR_MEMMAP, /* Page metadata size (struct page and page_ext) > + * in pages > + */ This is not how we write comments in the kernel ...