Received-SPF: pass (google.com: domain of linux-kernel+bounces-147812-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 17 Apr 2024 09:52:41 +0900
From: Mark Brown <broonie@kernel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: djakov@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, matthias.bgg@gmail.com, lgirdwood@gmail.com,
	keescook@chromium.org, gustavoars@kernel.org,
	henryc.chen@mediatek.com, linux-pm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, kernel@collabora.com,
	wenst@chromium.org, amergnat@baylibre.com
Subject: Re: [PATCH v1 5/6] regulator: mtk-dvfsrc-regulator: Refactor and add
 MT8192/MT8195 vregs
Message-ID: <Zh8dWdE8V8-GhNlF@finisterre.sirena.org.uk>
References: <20240416153805.431118-1-angelogioacchino.delregno@collabora.com>
 <20240416153805.431118-6-angelogioacchino.delregno@collabora.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="whh3nrJglfd7igwd"
Content-Disposition: inline
In-Reply-To: <20240416153805.431118-6-angelogioacchino.delregno@collabora.com>


--whh3nrJglfd7igwd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 16, 2024 at 05:38:04PM +0200, AngeloGioacchino Del Regno wrote:
> This driver never worked, and never got even compiled, because it was
> missing the DVFSRC driver entirely, including headers it relies on!
>=20
> Perform a full (or nearly full) refactoring of the MediaTek DVFSRC
> controlled Regulators driver: this retains support for the MT6873,
> MT8183 and MT8192 SoCs, and adds MT8195.
>=20
> As part of the refactoring, this driver is now probed using its own
> devicetree compatible, as this is a child of the main DVFSRC driver
> and gets probed as a subnode of that.

Given what you're doing this would probably be easier to review as
two commits, one removing the existing driver and another adding the new
code.

--whh3nrJglfd7igwd
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmYfHVgACgkQJNaLcl1U
h9DwsQgAgK6OWXJu6ieNWkutjauhJjUe5+l5WxV0KrzASn7I8CFbXNeSgxtx8AZ/
Wv1MYw70APANEtgwkVwwwzu9dxHg+NCPglVwkhmhCevxOvAx8klLFChvsfzjCvmq
pvke+sh5Y/A+8ryIisIA7btD1obFfxLXFQm17W4JggKi47e+QDiah3sQqVzpfDPr
G17pX6KxNc/S+YzkT/BmWcT9uGKucU10R082NScoBU5lsdrAyGnowwhJVNcL5N4J
tUJJXB1VnSi1Q4fOXB4wpxihXwGDZnwb2kgLp2hgRAMXaQv2BbCfk0IAy8DE69yr
lEi56TB4d1sxHrvVO/RTnarkSfcfMQ==
=+F1c
-----END PGP SIGNATURE-----

--whh3nrJglfd7igwd--