Received-SPF: pass (google.com: domain of linux-kernel+bounces-147839-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 16 Apr 2024 19:15:17 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: Kory Maincent <kory.maincent@bootlin.com>
Cc: "David S. Miller" <davem@davemloft.net>, Eric Dumazet
 <edumazet@google.com>, Paolo Abeni <pabeni@redhat.com>, Jonathan Corbet
 <corbet@lwn.net>, Luis Chamberlain <mcgrof@kernel.org>, Russ Weight
 <russ.weight@linux.dev>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 "Rafael J. Wysocki" <rafael@kernel.org>, Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley
 <conor+dt@kernel.org>, Oleksij Rempel <o.rempel@pengutronix.de>, Mark Brown
 <broonie@kernel.org>, Frank Rowand <frowand.list@gmail.com>, Andrew Lunn
 <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>, Russell King
 <linux@armlinux.org.uk>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
 netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-doc@vger.kernel.org, devicetree@vger.kernel.org, Dent Project
 <dentproject@linuxfoundation.org>, kernel@pengutronix.de, Maxime Chevallier
 <maxime.chevallier@bootlin.com>
Subject: Re: [PATCH net-next v8 10/17] net: pse-pd: Add support for PSE PIs
Message-ID: <20240416191517.65c63e21@kernel.org>
In-Reply-To: <20240414-feature_poe-v8-10-e4bf1e860da5@bootlin.com>
References: <20240414-feature_poe-v8-0-e4bf1e860da5@bootlin.com>
	<20240414-feature_poe-v8-10-e4bf1e860da5@bootlin.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Sun, 14 Apr 2024 16:21:59 +0200 Kory Maincent wrote:
> +/**
> + * of_pse_match_pi - Return the PSE PI id of the device node phandle
> + * @pcdev: a pointer to the PSE controller device
> + * @np: a pointer to the device node
> + */
> +static int of_pse_match_pi(struct pse_controller_dev *pcdev,

There's new nitpick from kernel-doc - if the function returns something
the kdoc needs to document Return:  ..

Sorry I missed this check failing because the fact that the series is
17 patches lights it up as red in patchwork :( I'll apply the first
3 patches to make v9 smaller.

> +			   struct device_node *np)
> +{
> +	int i;
> +
> +	for (i = 0; i <= pcdev->nr_lines; i++) {
> +		if (pcdev->pi[i].np == np)
> +			return i;
> +	}
> +
> +	return -EINVAL;
> +}
> +
> +/**
> + * psec_id_xlate - translate pse_spec to the PSE line number according
> + *		   to the number of pse-cells in case of no pse_pi node
> + * @pcdev: a pointer to the PSE controller device
> + * @pse_spec: PSE line specifier as found in the device tree
> + *
> + * Return 0 if #pse-cells = <0>. Return PSE line number otherwise.

here missing ":"

> + */
> +static int psec_id_xlate(struct pse_controller_dev *pcdev,
> +			 const struct of_phandle_args *pse_spec)