Received: by 2002:a05:6500:1b45:b0:1f5:f2ab:c469 with SMTP id cz5csp349577lqb; Tue, 16 Apr 2024 19:20:45 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVXYU+2moE3BNU5p3uTCRtAQV6HOlp1ycXqqdjW2tpWtW4xD1tb/KknCjUHH+S6LUQ16xsoXAylEzr616rZRlvcSPNTi7demQBHMj4mSg== X-Google-Smtp-Source: AGHT+IH0onhOsWclWP+1zlpklL9QBGoMcTV//UhC+xXCsSnZ7AKZccXScihEg2gWAssXKl2/Xae2 X-Received: by 2002:a17:906:f2d7:b0:a52:5789:9c5d with SMTP id gz23-20020a170906f2d700b00a5257899c5dmr5577647ejb.39.1713320445598; Tue, 16 Apr 2024 19:20:45 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713320445; cv=pass; d=google.com; s=arc-20160816; b=odD+E45ciGR8QxZNNKDfWkSwbjKVw0FDU1mkXJ4T3pJyH72e/irVSfVlyZqiyLjogH p+kZtwd/TZet8rJIWTs0ga94F0O70xfW9ydKKij6BxcpTBWZnmwX1g+ZSiXmbUgzmNpB MhnO4at2QA4Yjeg8qVYC8fnAPqtt/+aP/J42kH6WJ8LVZYOvKrDwD5CqJf7+QFIlYl2+ NDWGUyaSnkNQRfm163M2qIrSLy3VuY87VFJtNCStNBSjS9TaMlySFQJLnLIEadwZsT3i 18S7184uB/eJHQd70XlNntYlfJSPWHYp425/nanV/UB5HjY8IabrXKLpmB8jRSN7rbqY f1BA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:dkim-signature:date; bh=3y5F04Fl5zfvkzhj2El1MuWEnqWlT8gtSPmgfEeDlh4=; fh=md2kVIsEU7q/zkmNauO0psAe7KGpSwAVgu0ObQLKXes=; b=rZKFOWuW0w1puLf+m6VIcl8sbS72ImAc3GpaLpF6MmfOfRJK8XhcwPGf5S6NHXxW2H Qqoo82MdOflKB1xCZYezVruTmA59YqamWA1xpDX/oLhMzOuyhcf7iB/nrDP8voZ965nv YyZ2fPjSC4zsPFROJeCaHC4+iFs8J46lnkWjr62pB554G08oLMhL7rqyJfovhwltYVcn omdz41Pc4z/RIm73XmkdfwYEKmRwzA2kPwJrHgMu6U2wXBfT3iwpOPB98cv7l6qwJa6y r8wPrO7kaO/xmP+KaySXAyY4aNzIlrcKfE61VBLjuvV+mWDILFRgncWvcKVVKz4nmGek lrZw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=RdVIjrNC; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-147847-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-147847-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id dn16-20020a17090794d000b00a525c60b08asi3587310ejc.723.2024.04.16.19.20.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 19:20:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-147847-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=RdVIjrNC; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-147847-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-147847-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 54AEF1F22239 for ; Wed, 17 Apr 2024 02:20:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0FDF8566A; Wed, 17 Apr 2024 02:20:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="RdVIjrNC" Received: from out-187.mta0.migadu.com (out-187.mta0.migadu.com [91.218.175.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CCCB4428 for ; Wed, 17 Apr 2024 02:20:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.187 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713320439; cv=none; b=M2MNnt0maOSP/6Yn5hi2Nj5ME2WJ36F3/JTyZP9nkZHj5626aurOYs9CF7XJP/k+XJB1rcgl0y8aB9+IJjPGvzKxRDyj1mUebrHDkOnxFr7kMdChtzntfTA0tIKlIzMjLP0hOs2GBhiO6TihYVGvPvAZoJV9upEngZ8U1geUWhw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713320439; c=relaxed/simple; bh=JEO0ng65nZp0QZ6p164cReYxFc0+aDojLhQDMPMJqNg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=He0ldz6XNCt8lAx2pPSzvfLMILTj3XotBGA9r8+2DW13+ibOUZGYgmxbPABNC9EKyyKEbRXEx2CodKA1p06+lZ4pD4UTvdrFs9BAOlURSC6UAHVy6pMCQOHkVg6q4TDQS9lXBxwccYER516hm75elmay39DJU8EQ9DroCL4DV94= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=RdVIjrNC; arc=none smtp.client-ip=91.218.175.187 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Date: Tue, 16 Apr 2024 22:20:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1713320434; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3y5F04Fl5zfvkzhj2El1MuWEnqWlT8gtSPmgfEeDlh4=; b=RdVIjrNCwkFFpawDWlb5p/go3q8DWIsZxC/YZY6MzTAeJ9IL48Qu3AuiR3aPgFsmJpOsSD Pk3IzGg+83ESHtVTL5NscGWI3YxbAUeyoTlR25/gHeuJtzCDSpwVmKZS3JKKi8v8vm8V2N R6DPONrgcXKRMroYaiolgtAP1mr2+Tc= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Youling Tang Cc: linux-bcachefs@vger.kernel.org, linux-kernel@vger.kernel.org, Youling Tang Subject: Re: [PATCH] bcachefs: Align the display format of `btrees/inodes/keys` Message-ID: References: <20240417015448.84294-1-youling.tang@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240417015448.84294-1-youling.tang@linux.dev> X-Migadu-Flow: FLOW_OUT On Wed, Apr 17, 2024 at 09:54:48AM +0800, Youling Tang wrote: > From: Youling Tang > > Before patch: > ``` > #cat btrees/inodes/keys > u64s 17 type inode_v3 0:4096:U32_MAX len 0 ver 0: mode=40755 > flags= (16300000) > ``` > > After patch: > ``` > #cat btrees/inodes/keys > u64s 17 type inode_v3 0:4096:U32_MAX len 0 ver 0: > mode=40755 > flags= (16300000) This would print a newline for keys that don't have a value...