Received: by 2002:a05:6500:1b45:b0:1f5:f2ab:c469 with SMTP id cz5csp352532lqb; Tue, 16 Apr 2024 19:31:59 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXQorj5o+yBsC7G3FzxexGQL44ndyTwK+Aflump0rJxlmcm1WOd/j2r5i+J7e7gs/GOiHSenFsZptyh2pnte1jb/RPWiJoT1ukzG9kiLA== X-Google-Smtp-Source: AGHT+IEuZPJCLBoj7cUUMDTBjUzGqE+V+By3udRM9kzF3HSTMYr7TAr6ZUWklfsmfRCpQdJUK0M1 X-Received: by 2002:a17:906:eb43:b0:a52:6d2b:e8f7 with SMTP id mc3-20020a170906eb4300b00a526d2be8f7mr4123327ejb.12.1713321119562; Tue, 16 Apr 2024 19:31:59 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713321119; cv=pass; d=google.com; s=arc-20160816; b=qbbzC+TUzUXTxZpIPrc3uFHMyy3CGqZOciOKwAFld+CiJzpUZULOw932RgKupjF0wO /nlv2dgp2bxEVJ+UWrwvtcMDigR6ADG3Yho/M9NRRw4Nuw3X/nKJcc+JCI9i/w8FB0is 0RyewifPvBNJIH55Qpm9G/W4XJiuYVhuU7kMY3jk0dskRedFm3VKdgOheiGyU2LYAowa zo9JEXj3pX0bQVP9SoVZdPA4tRe6n7+tk3yjG/9NwOTSNSxn1rEGhJzwLgmIRVZLAi9E FanKP8JpQFDmMlqijnAS+kEbCOPDzhjaEJqPfHNBtgA97lG8P9B0Z+B9HSi8BuedE+aY GWHg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=782CHxRs4s96D8WQBK+VdiCYc7VC1bzSWy8buAAx/nc=; fh=GaSqQ6/Dp/N45Z3eHyi7L3C8AAz/D4ziEC7Rm0co4IM=; b=pbV+7MaUUpDNCWbHnBLLLYyTHrvclZX0MFkodlWvodaICvphkcCgakcElAlhza94qV JhZQrCzLdy7RwphuEPTrqVsQnFme0Xjq5joIAow/yYBQgMyiuMWHtFHrkklVshzR0XWh WoEudmZmfAyNKMaOibpJysP7r7i1QNx/Cch+xFGKtK6QXRcw7nM3f6i5m0Bkyj/0A+OF t3V8wifY0qGo4K+/ce424+PJVx3dFa01A83O7GwiXmDWr5esOm8d8FlhWym9IQGrKbt0 HYfejpB3fVOw2Tgzl6yqvj5Ld4ddgeOqAQSvnWjqMMXx8v1O30yVc0mxnw9svtR5ZH7+ KXvw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=k5vzLal0; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-147851-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-147851-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id w13-20020a17090633cd00b00a553240ce9bsi1942001eja.892.2024.04.16.19.31.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 19:31:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-147851-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=k5vzLal0; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-147851-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-147851-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 4A1381F23E62 for ; Wed, 17 Apr 2024 02:23:16 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A179C7470; Wed, 17 Apr 2024 02:23:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="k5vzLal0" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6D544685; Wed, 17 Apr 2024 02:23:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713320585; cv=none; b=WHLk5h+jwT0oH8eIo5bTuFioohG7bRGIocc5XKLKD98HUas6ZfAbnW2z9SjmOGfIAczY1ldIXTj+b2xqMDdHbaUgZs7MPLi8/J5/Wa9xwFxNdfVyv01Q0WGw6S+unuiZ8LCRfLoaMSUkVwcUowR+aFDUJRQgh2Xzv8qaLoltbk0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713320585; c=relaxed/simple; bh=46aRmITiOUVBynMBETaAGe/3vLl0jA+4t6Miv67/OSU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=sJWZKKEYoiScu/PTqjs9x4LsGXmowoM9vhbBMxPdq0rasjo4hsWxJliyfRuT8jWcFrxxIKuiPiykiYoTRCMhWskYLBwJ63BRIj/Y/gCpmQLgwFydsbM87Td5adVqMhnM3BB9apIXC3XNhL6EZyrFhAe12ZFWGeMpE1mMxe9Wrvc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=k5vzLal0; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0098C113CE; Wed, 17 Apr 2024 02:23:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713320585; bh=46aRmITiOUVBynMBETaAGe/3vLl0jA+4t6Miv67/OSU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=k5vzLal0dkLpUT57JnJ1eUDaPSfH7ufjYabxE47W5BNOqCYEC9JIxVZdl0aDEUXS4 C9hvvN6Uk2H1I/Yf5zaAfmUaM/1kjWlRpnOcsH4l6/pZfpW/TyJf/s7acQgwxOe/3x FxLq9flUjWO4S/UMdeuZ3g6JwtjDH/M7HBvYR5EImzIr0MmG7AlOkpZaXncOkzblX+ VUxCVLyYK17U7uIryJ5YpctQwBs4IR8oXmZL+yrqKPEGlXAI1WTT6oQkfX7zlx1UOs l6aJG6Te0XojLRV+2BaxP5ygkPxQ2cQbrktJED2ptOZfq4lm/OrfMYfAVpRHMheaej efQrPfWN/1pEA== Date: Tue, 16 Apr 2024 19:23:02 -0700 From: Jakub Kicinski To: Kory Maincent Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Jonathan Corbet , Luis Chamberlain , Russ Weight , Greg Kroah-Hartman , "Rafael J. Wysocki" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Oleksij Rempel , Mark Brown , Frank Rowand , Andrew Lunn , Heiner Kallweit , Russell King , Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org, Dent Project , kernel@pengutronix.de, Maxime Chevallier Subject: Re: [PATCH net-next v8 06/17] net: ethtool: pse-pd: Expand pse commands with the PSE PoE interface Message-ID: <20240416192302.72b37f09@kernel.org> In-Reply-To: <20240414-feature_poe-v8-6-e4bf1e860da5@bootlin.com> References: <20240414-feature_poe-v8-0-e4bf1e860da5@bootlin.com> <20240414-feature_poe-v8-6-e4bf1e860da5@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 14 Apr 2024 16:21:55 +0200 Kory Maincent wrote: > + !(pse_has_podl(phydev->psec))) { > + NL_SET_ERR_MSG_ATTR(info->extack, > + tb[ETHTOOL_A_PODL_PSE_ADMIN_CONTROL], > + "setting PoDL PSE admin control not supported"); > + return -EOPNOTSUPP; > + } > + if (tb[ETHTOOL_A_C33_PSE_ADMIN_CONTROL] && > + !(pse_has_c33(phydev->psec))) { nit: unnecessary parenthesis around the function call