Received-SPF: pass (google.com: domain of linux-kernel+bounces-147855-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Wed, 17 Apr 2024 02:31:47 +0000
From: Wei Yang <richard.weiyang@gmail.com>
To: Mike Rapoport <rppt@kernel.org>
Cc: skseofh@gmail.com, robh@kernel.org, saravanak@google.com,
	akpm@linux-foundation.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Daero Lee <daero_le.lee@samsung.com>
Subject: Re: [PATCH] memblock: add no-map alloc functions
Message-ID: <20240417023147.ybefdy6fn5drvq5w@master>
Reply-To: Wei Yang <richard.weiyang@gmail.com>
References: <20240415142448.333271-1-skseofh@gmail.com>
 <Zh1HP8IWWjexAUKN@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Zh1HP8IWWjexAUKN@kernel.org>
User-Agent: NeoMutt/20170113 (1.7.2)

On Mon, Apr 15, 2024 at 06:26:55PM +0300, Mike Rapoport wrote:
[...]
>> +	
>
>This changes behaviour of internal function, what effect will it have on
>the users?
>
>>  	if (!base)
>>  		return -ENOMEM;
>>  
>>  	*res_base = base;
>>  	if (nomap) {
>>  		err = memblock_mark_nomap(base, size);

Mike

One question may not directly relevant to this thread.

NOMAP doesn't apply to all arch? I took a look into the direct mapping
function on x86, memory_map_top_down(). It seems iterate all available pfn
instead of skipping NOMAP range. 

>> -		if (err)
>> -			memblock_phys_free(base, size);
>>  	}
>>  
>>  	kmemleak_ignore_phys(base);
>
>-- 
>Sincerely yours,
>Mike.

-- 
Wei Yang
Help you, Help me