Received-SPF: pass (google.com: domain of linux-kernel+bounces-147867-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <66ecea56-e4d3-4241-a1dc-378d70555321@linux.dev>
Date: Wed, 17 Apr 2024 10:50:10 +0800
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PATCH] bcachefs: Align the display format of
 `btrees/inodes/keys`
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: linux-bcachefs@vger.kernel.org, linux-kernel@vger.kernel.org,
 Youling Tang <tangyouling@kylinos.cn>
References: <20240417015448.84294-1-youling.tang@linux.dev>
 <toosz4pt2la6wf2575vwe6efebcbzsy735cq7exmlqhzrgicrf@s7g3rrbvge2l>
Content-Language: en-US, en-AU
From: Youling Tang <youling.tang@linux.dev>
In-Reply-To: <toosz4pt2la6wf2575vwe6efebcbzsy735cq7exmlqhzrgicrf@s7g3rrbvge2l>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi, Kent
On 17/04/2024 10:20, Kent Overstreet wrote:
> On Wed, Apr 17, 2024 at 09:54:48AM +0800, Youling Tang wrote:
>> From: Youling Tang <tangyouling@kylinos.cn>
>>
>> Before patch:
>> ```
>>   #cat btrees/inodes/keys
>>   u64s 17 type inode_v3 0:4096:U32_MAX len 0 ver 0:   mode=40755
>>     flags= (16300000)
>> ```
>>
>> After patch:
>> ```
>>   #cat btrees/inodes/keys
>>   u64s 17 type inode_v3 0:4096:U32_MAX len 0 ver 0:
>>     mode=40755
>>     flags= (16300000)
> This would print a newline for keys that don't have a value...
The original intention was to make the display of the printed content in
'__bch2_inode_unpacked_to_text ()' consistent, without considering other 
callbacks.

Or just modify it in the following way?
--- a/fs/bcachefs/inode.c
+++ b/fs/bcachefs/inode.c
@@ -534,6 +534,8 @@ int bch2_inode_v3_invalid(struct bch_fs *c, struct 
bkey_s_c k,
  static void __bch2_inode_unpacked_to_text(struct printbuf *out,
struct bch_inode_unpacked *inode)
  {
+       prt_newline(out);
+
         printbuf_indent_add(out, 2);
         prt_printf(out, "mode=%o", inode->bi_mode);
         prt_newline(out);


Thanks,
Youling.