Received-SPF: pass (google.com: domain of linux-kernel+bounces-147868-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <8ff7df9e-9ca7-47d3-a1b0-4997a0713341@amperemail.onmicrosoft.com>
Date: Wed, 17 Apr 2024 09:54:03 +0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 2/3] hwmon: (max31790): Support config PWM output
 becomes TACH
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
 Chanh Nguyen <chanh@os.amperecomputing.com>, Jean Delvare
 <jdelvare@suse.com>, Guenter Roeck <linux@roeck-us.net>,
 Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, Justin Ledford
 <justinledford@google.com>, devicetree@vger.kernel.org,
 linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
 OpenBMC Maillist <openbmc@lists.ozlabs.org>,
 Open Source Submission <patches@amperecomputing.com>
Cc: Phong Vo <phong@os.amperecomputing.com>,
 Thang Nguyen <thang@os.amperecomputing.com>,
 Quan Nguyen <quan@os.amperecomputing.com>
References: <20240414042246.8681-1-chanh@os.amperecomputing.com>
 <20240414042246.8681-3-chanh@os.amperecomputing.com>
 <79bef664-b191-4905-896c-afab341b982b@wanadoo.fr>
 <9bc38f67-01e0-4a38-8db8-4086a215b474@amperemail.onmicrosoft.com>
 <3a4e0543-fc40-41dc-8aaa-19811b96f1cb@wanadoo.fr>
Content-Language: en-US
From: Chanh Nguyen <chanh@amperemail.onmicrosoft.com>
In-Reply-To: <3a4e0543-fc40-41dc-8aaa-19811b96f1cb@wanadoo.fr>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Vm8zUTNiOUQvZWp2U21xZXgrZXBvWEVZdklJazdlV1ZaZnJDWCtESGhUN1Rl?=
 =?utf-8?B?aHY3ZEp1NXp4OEtFUTFtRnRQSnZwNVd3TnMwYzhEclNxQWhvRWpaZFJRQkgx?=
 =?utf-8?B?Rm0ybGI4OVpUakpidlVQbmRVUmMweXNBdTlUK0RETXFWQlFWSzlDVUg3K3pv?=
 =?utf-8?B?ZmNBUm04NWZkVVVuSytiUDNrcCtrS2JpaTJnQWZVaHkxSmVJVFhCenRFdHJr?=
 =?utf-8?B?NkdVdmlrVThhWlkxcTNJbk53N1pnai9yNDMvR1pDK1BlN3prbnRDbG5HVXBB?=
 =?utf-8?B?M202UDQrR2lyeFZTTmxpNzBQeHVONTJydFpLb2tuUmVkRFBsNkc4aWlRcXpx?=
 =?utf-8?B?K3JPVTFGc0dsYitadkRWRTBNUlEzNnFPZ3B6MFZUNDM0cGZxcWFZbVE4OWFu?=
 =?utf-8?B?dEppUDBCWkxZSEVhVk5YMDJ5ZWJtdmM3dUIxV2JyajhiQllVUmZwUEVaSjBs?=
 =?utf-8?B?cUoyVmQ5SW5jRFNaYktmVGV5RER3Qy9JQkpWbWg0NzlmMlQ2UEVyOEF0UmJR?=
 =?utf-8?B?dEdEd0lUMW1RSUhHcmJCNkhnRUswakQxUkdIWkRQMk5kZlpFNGZSbkdQZ1RK?=
 =?utf-8?B?TDA3bmdSREEzSmFoSmI0dTJBYjVuaDI0Uk9rQWRRRGdURU80SExtZStsK3Bu?=
 =?utf-8?B?ZysyclhZUE00aGhHZU9WOUJVOW9PTWc3d2NiTjJDejNnSWY4VE0rVXZsbG1G?=
 =?utf-8?B?Rm9DR1pyelhMbFdFeFFINDFSMnlzNXkvYkZXNDM2RUFUeU5WeEpMNzUzb29w?=
 =?utf-8?B?bW5UZzkwSUZxeFhSZXhQY1NIaytXa2NaS3VBVUdseDZMalFSdGl3WjFuMzNw?=
 =?utf-8?B?aDl0dFR1MzdzWW1wazZJUVpFY3dONjBobE9oQ0NoWkxzRGdlT3hDTTFJK1Fh?=
 =?utf-8?B?emJhQXdWMjlQWUZXNWVKL25mak9OTDJPSDduWUlqMXUwWTE5WVVWTmhiVUhj?=
 =?utf-8?B?ajRkZTdIN0dDdGJyaFZXbDFFT21vaU9BMHlUQ0tMa3c3ZzR6UnJCaDlLTE9Q?=
 =?utf-8?B?LzNBcm9Hd1ROVXA0ajJJa0pGOStLNml1ZDU2Sm5kYnAvTjNRQi9ieHI1SG9K?=
 =?utf-8?B?c0VhcituNTlRWnZTWE1jVmJOelBZTVBnUkZJVWIyL0Rjcm9DbndiTyt1WnhC?=
 =?utf-8?B?V1FQakJSOVZaYzhwb3ZUVFR4TnhsVjhDTnZJOXdLZG96cENWS1hkOWtwUXBH?=
 =?utf-8?B?d0Q3dFJpVFZLSzBTUjcxRlhDVGlHUnVoMHYzRm8yK3gwVitJSGJEYW8waGtl?=
 =?utf-8?B?UkVYZXV0RUlxMndkRkEwVkJaZkZGS2cyaWVqOGt1ZVlPM2c5azYwRXNkcGhY?=
 =?utf-8?B?UHNoTm44cGcwMjhnSmFCUEplSnVsL01GSkErWjZ6UHlJZHhXdkgyclhCR1BK?=
 =?utf-8?B?WGZ2TE5TeTdWZ1pMSEhyV1RZUVRHbzJOVEg2Z2NkMVIxNWErVnNlZjFKKzlZ?=
 =?utf-8?B?aXlLRGQ4d0Y4bHMrWU5ZTVhMbmNKZjVBWloyWXhieUZscVdPbVNIQkk1dGVQ?=
 =?utf-8?B?NDdJWW1LNmp1cWNWRkJYTzZHZnBmZmNWVlZJUWdQMTQ0eVY5SlFjZmFUa1VQ?=
 =?utf-8?B?U3hGT3E3S3AvbFRqRHlFNWt5TXJ1VllHNWhRcnF3REk0ek0yUUI3TGl1Y01T?=
 =?utf-8?B?RTFjUXhFSWFDMjExQ0JzNGViUC96WDE1TWhYdTR2RnNCR09wY2V2WTJNb25o?=
 =?utf-8?B?TEdnZkF5L1E0d1VqMTcxa2pHTUNrb0NkTmRwUzVKeDRDYlVqS00xWFNKeHFN?=
 =?utf-8?B?cTNseTIyWEVpQWtWYWVyZDd0cFlvaWRiVG5WS21KV2dnMXBjNUJiVG42MkRi?=
 =?utf-8?B?cVBaeEdoNzhlSThRcFZlV3llN1pLREpxdFNaSGlVSmdKRlRFY1dFRy9EQis5?=
 =?utf-8?B?NVZDZ21IbUhJN3FUQm5OVm5yK1Z5cEZ0ZkF4TFBPTUlDNWZuT2R6Mk9kMkpF?=
 =?utf-8?B?K2xjT0dOVDZFRHRvTCtnaDJOT0I3dlFTR0RmUkxGdC8waUIrUnFhb0R0OUpt?=
 =?utf-8?B?bUlsZXRXcnBqYjNPS2lhQWRnOUFhS1k4MGgzQ1RsNXg1RWlWaXp6N05HSk5l?=
 =?utf-8?B?TjIrSHNOK0svOUdxTFJJaytlelpZbC9jYkk0T1BNUnFneFkwQ1BVQmYxNkdp?=
 =?utf-8?B?Smp2dmdTSG9vbUZQMDd6L2RUZURxakJZeC8xSVhkOHgvbWZDcmtsL1BETXFN?=
 =?utf-8?Q?pCm1zO85pvW9iWP/xku84gU=3D?=
X-OriginatorOrg: amperemail.onmicrosoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c7955e9-f49f-49db-1b39-08dc5e89abac
X-MS-Exchange-CrossTenant-AuthSource: BY5PR01MB5938.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2024 02:54:19.0810
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: x508rOswtbkkDVyeqcDKO5fYEWpIjkG7hwxGlB+Pinmnwrreuvvq4inf1vU//zJI3tdcKMIq/DKDwVWakyxGxWoWuK8Ifli6ytF8SE25EgWgBVBLfb+fqcb9+Zq5hWAM
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR01MB7168


On 17/04/2024 00:39, Christophe JAILLET wrote:
> Le 16/04/2024 à 07:27, Chanh Nguyen a écrit :
>>
>>
>> On 14/04/2024 15:03, Christophe JAILLET wrote:
>>> Le 14/04/2024 à 06:22, Chanh Nguyen a écrit :
>>>> PWMOUT pins on MAX31790 can be configured as a tachometer input pin by
>>>> setting bit[0] in the Configuration Register. When the bit[0] of a 
>>>> channel
>>>> is set, the PWMOUT pin becomes the tach input pin for the channel 
>>>> plus six.
>>>>
>>>> This commit allows the kernel to set those pins when necessary if the
>>>> maxim,pwmout-pin-as-tach-input DT property exists.
>>>>
>>>> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
>>>> ---
>>>> Changes in v2:
>>>>   - Update the vendor property name to 
>>>> "maxim,pwmout-pin-as-tach-input"   [Rob]
>>>
>>> ...
>>
>> Hi CJ, what does it mean?
> 
> Hi,
> just a shortcut of my name : Christophe Jaillet.
> 

Thank CJ! It's a pleasure to see your comments. I'm happy to meet your 
review in the next patches.

Best Regards,
Chanh Ng

> CJ
> 
>>>
>>>> @@ -528,6 +532,33 @@ static int max31790_probe(struct i2c_client 
>>>> *client)
>>>>       if (err)
>>>>           return err;
>>>> +    if (device_property_present(dev, 
>>>> "maxim,pwmout-pin-as-tach-input")) {
>>>> +        err = device_property_read_u8_array(dev, 
>>>> "maxim,pwmout-pin-as-tach-input",
>>>> +                            pwmout_to_tach, NR_CHANNEL);
>>>> +        if (err) {
>>>> +            /* The maxim,pwmout-pin-as-tach-input is an array of 
>>>> six values */
>>>> +            dev_warn(dev, "The maxim,pwmout-pin-as-tach-input 
>>>> property exist but malform");
>>>
>>> Nit: exists
>>> Nit: malformed or "is malformed"
>>>
>>
>> Thank CJ,
>>
>> I'll update that in the patch v3
>>
>>> CJ
>>
>>
>