Received-SPF: pass (google.com: domain of linux-kernel+bounces-147912-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 17 Apr 2024 12:03:15 +0800
From: Chao Gao <chao.gao@intel.com>
To: Reinette Chatre <reinette.chatre@intel.com>
CC: <isaku.yamahata@intel.com>, <kvm@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <isaku.yamahata@gmail.com>, Paolo Bonzini
	<pbonzini@redhat.com>, <erdemaktas@google.com>, Sean Christopherson
	<seanjc@google.com>, Sagi Shahar <sagis@google.com>, Kai Huang
	<kai.huang@intel.com>, <chen.bo@intel.com>, <hang.yuan@intel.com>,
	<tina.zhang@intel.com>
Subject: Re: [PATCH v19 086/130] KVM: TDX: restore debug store when TD exit
Message-ID: <Zh9KA/BjAEZamEAo@chao-email>
References: <cover.1708933498.git.isaku.yamahata@intel.com>
 <b7a96654fa46593417afa6153959b2989a507842.1708933498.git.isaku.yamahata@intel.com>
 <9785680f-1c30-456f-af49-b6d26dd38fdf@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <9785680f-1c30-456f-af49-b6d26dd38fdf@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oRVorRd7LGgnBgz4tImzfV7y4kjBM2e8200Ag0efxOodEaKRN8+RthooeSJI?=
 =?us-ascii?Q?jtaUx783+KvZg2xv+DwJtrt//I/yvZNeNMIRVfqiATa+Dhj92X9raXrGRvXg?=
 =?us-ascii?Q?o/2N60d5rXmhtTkQz31lmHXuf5tJeCNhTx1H/V2zHC9mYncRVxVt9HLMOyTs?=
 =?us-ascii?Q?aoHh7MVoKCFsQpkRSJ3i8HJQPxLMStbk1lTZLWGgCLA8SnIYQxZOXkMXwO0q?=
 =?us-ascii?Q?B7CwXzopadWP8V052ek4EwMaOsD2w14xf381ijFi5ZquWcldXHyS/OIIdwEH?=
 =?us-ascii?Q?D1+lzL9baem+E+4lYqYGh/8Iw8+MBE1zrM0MgiJDVbF9VoMtggT5YPdG9ePs?=
 =?us-ascii?Q?VhvK/iLLxvWskpMozurHRv4/2Zg/Udw9XUSfL/sdJowdB8fP6MYO6wY9LxzB?=
 =?us-ascii?Q?vdAEqzJRd4wwpeq8OGXwL6F5RuphxBHurnZg4obCqXX4QnRMBosPMYXwnGsi?=
 =?us-ascii?Q?jQAoV66Xhd4JUWmM60DHBcnEKOMfEuOU4SYeAgr7iOMpIh8YrbRr7cgHcf6y?=
 =?us-ascii?Q?cDAhABQ350tpJMn9FR+hZ9YH1a5FCXEFM5dzS3UDchI8oKBWgPYe1DXphEtD?=
 =?us-ascii?Q?ZarbvM6NNG+meblJJtYS25AAXlRii+/AGL59hDQb1zdYMdCVs35ASLEurweu?=
 =?us-ascii?Q?mdgCpFUMaSa+3npN8cjNKXcdCqg7HdIXWjc8hQVBMRYM5BbYn8UBUFc0bX3P?=
 =?us-ascii?Q?O26vxvhrkvkNLFwxbIFzJK5Q2S2iblKolkD+4m3ZuO9Scif9r/2GZmUyO1As?=
 =?us-ascii?Q?8+FFFxNt9ov0qPa73mCdZiYc/xboofZapvZb+GLxHz/NE9HM1kfNTWLpBpVQ?=
 =?us-ascii?Q?GB3cjX5T4JvZbVzo34L2fZGmVJE/Eq/NZVyMSFHUeAhx6+2iO4twj3i+4+5P?=
 =?us-ascii?Q?WPVmRN9q3SFjW7a9oy9H1Avpow83xjlY9y4KltebOtkS+pM2Yc6hiSxfz+s8?=
 =?us-ascii?Q?bTI1IQKDSnWLo7/UpfxwyKZ5AQ32Mj1PfgQfzXp3g5fxmxhv3Zl606Emql2I?=
 =?us-ascii?Q?MO1PUaEsgW7bTlp7qKkqAYBjYE/87yadA5Lq8OLbB3Ic0FenV3l5452lu0VA?=
 =?us-ascii?Q?surLYJBV64Vv3kVwTMcWKFq+0kSgGk9o9BWl9zBX9e+RXPU0T4Y8LEyh9MzB?=
 =?us-ascii?Q?ZK9/te3Gv4/DXFP/LcIT31T/uDjCAj4bPvM8OIzR0IdLSUHdY5AJ5c5u8jk3?=
 =?us-ascii?Q?gwDjK8ygsMOxEDEdWSggpbp7Pf8w35mPsMyJTjkqJMSDyTWLr19hhc6IznIS?=
 =?us-ascii?Q?zdZNeCbiNBxTHBcTlvaCvGtfrDrYfcmx0+45rVG1rUjwU7C7UGyjnX80erpF?=
 =?us-ascii?Q?FhBJRHldhH/u4uCiyY9GpeNar4iLwvf8PKeu3sPwrp5XdVoIvML31GpZyMno?=
 =?us-ascii?Q?uq/HD+SydTWFSqOObouxicBbtrXa9LTr0wTy+Ihcje+P4q4obz6B7cI1lEgp?=
 =?us-ascii?Q?xBJc4yGUCDSuMx0AyxQ7k/hexvj8y0Se5JTagh8BEjsPEErUopmoFI4rPkCg?=
 =?us-ascii?Q?U0YkrsAZbkHOzKN9WBmPrY5bagW6/Lo9g0SRYg9kkIRvmRyL8r5JlJOeabbs?=
 =?us-ascii?Q?oIj2hoJJFXtPZ+JvujXZ0gr6lhUIp+OqAJ2rU9j3?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c26d405-5862-4599-7ee2-08dc5e9354af
X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB8660.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2024 04:03:25.4823
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pMkSS2OJ45TUOi+zg712RMyx7aLjpg9HZDzSI/PU70dKPS5YR9Gai0oJrAJ/kxed9CRSvoZbe3Rl6eFN33QI9A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7396
X-OriginatorOrg: intel.com

On Tue, Apr 16, 2024 at 11:24:16AM -0700, Reinette Chatre wrote:
>Hi Isaku,
>
>On 2/26/2024 12:26 AM, isaku.yamahata@intel.com wrote:
>> From: Isaku Yamahata <isaku.yamahata@intel.com>
>> 
>> Because debug store is clobbered, restore it on TD exit.
>> 
>
>I am trying to understand why this is needed and finding a few
>places that seem to indicate that this is not needed.
>
>For example, in the TX base spec, section 15.2 "On-TD Performance
>Monitoring", subsection "15.2.1 Overview":
> * IA32_DS_AREA MSR is context-switched across TD entry and exit transitions.
>
>To confirm I peeked at the TDX module code and found (if I understand this
>correctly) that IA32_DS_AREA is saved on TD entry (see [1]) and restored on 
>TD exit (see [2]).

Hi Reinette,

You are right. I asked TDX module to preserve IA32_DS_AREA across TD transitions
and they made this change. So, this patch can be dropped now.