Received-SPF: pass (google.com: domain of linux-kernel+bounces-147913-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 17 Apr 2024 11:05:00 +0700
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Luca Ceresoli <luca.ceresoli@bootlin.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>, Jonathan Corbet <corbet@lwn.net>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Mao Zhu <zhumao001@208suo.com>, Ran Sun <sunran001@208suo.com>,
	Xiang wangx <wangxiang@cdjrlc.com>,
	Shaomin Deng <dengshaomin@cdjrlc.com>,
	Charles Han <hanchunchao@inspur.com>,
	Attreyee M <tintinm2017@gmail.com>,
	Linux Sound System <linux-sound@vger.kernel.org>,
	Linux Documentation <linux-doc@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 07/12] ASoC: doc: dapm: extend initial descrption
Message-ID: <Zh9KbP0BUDUT3cKi@archie.me>
References: <20240416-dapm-docs-v1-0-a818d2819bf6@bootlin.com>
 <20240416-dapm-docs-v1-7-a818d2819bf6@bootlin.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="b7GZU7fJlI7GZVHh"
Content-Disposition: inline
In-Reply-To: <20240416-dapm-docs-v1-7-a818d2819bf6@bootlin.com>


--b7GZU7fJlI7GZVHh
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 16, 2024 at 07:56:13AM +0200, Luca Ceresoli wrote:
> diff --git a/Documentation/sound/soc/dapm.rst b/Documentation/sound/soc/d=
apm.rst
> index cab40a6b4c96..3a2fde1d31bf 100644
> --- a/Documentation/sound/soc/dapm.rst
> +++ b/Documentation/sound/soc/dapm.rst
> @@ -17,9 +17,27 @@ recompiling are required for user space applications t=
o use it. DAPM makes
>  power switching decisions based upon any audio stream (capture/playback)
>  activity and audio mixer settings within the device.
> =20
> -DAPM spans the whole machine. It covers power control within the entire
> -audio subsystem, this includes internal codec power blocks and machine
> -level power systems.
> +DAPM is based on two basic elements, called widgets and routes:
> +
> + * a **widget** is every part of the audio hardware that can be enabled =
by
> +   software when in use and disabled to save power when not in use
> + * a **route** is an interconnection between widgets that exists when so=
und
> +   can flow from one widget to the other
> +
> +All DAPM power switching decisions are made automatically by consulting =
an
> +audio routing graph. This graph is specific to each sound card and spans
> +the whole sound card, so some DAPM routes connect two widgets belonging =
to
> +different components (e.g. the LINE OUT pin of a CODEC and the input pin=
 of
> +an amplifier).
> +
> +The graph for the STM32MP1-DK1 sound card is shown in picture:
> +
> +.. kernel-figure:: dapm-graph.svg
> +    :alt:   Example DAPM graph
> +    :align: center
> +
> +DAPM power domains
> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> =20
>  There are 4 power domains within DAPM:
> =20
> @@ -48,12 +66,6 @@ Stream domain
>        Enabled and disabled when stream playback/capture is started and
>        stopped respectively. e.g. aplay, arecord.
> =20
> -All DAPM power switching decisions are made automatically by consulting =
an audio
> -routing graph of the whole machine. This graph is specific to each machi=
ne and
> -consists of the interconnections between every audio component (including
> -internal codec components). All audio components that affect power are c=
alled
> -widgets hereafter.
> -
> =20
>  DAPM Widgets
>  =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>=20

The wording LGTM, thanks!

Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>

--=20
An old man doll... just what I always wanted! - Clara

--b7GZU7fJlI7GZVHh
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZh9KbAAKCRD2uYlJVVFO
o0m+APwMHE1k0TJ9ucDIKEakmToYvHcKnjrWJmxuigR6GgEZJQD8D46fkvIO6nwE
IClRwzNZSt8vlPLDGZdHcBs9SP3uVgQ=
=PQFt
-----END PGP SIGNATURE-----

--b7GZU7fJlI7GZVHh--