Received-SPF: pass (google.com: domain of linux-kernel+bounces-147925-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Wed, 17 Apr 2024 11:33:12 +0700
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Luca Ceresoli <luca.ceresoli@bootlin.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>, Jonathan Corbet <corbet@lwn.net>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	linux-sound@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/12] ASoC: doc: dapm: improve section "Codec/DSP Widget
 Interconnections"
Message-ID: <Zh9RCMdihgSyZqTw@archie.me>
References: <20240416-dapm-docs-v1-0-a818d2819bf6@bootlin.com>
 <20240416-dapm-docs-v1-10-a818d2819bf6@bootlin.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ljvRn32hn8AsjPHI"
Content-Disposition: inline
In-Reply-To: <20240416-dapm-docs-v1-10-a818d2819bf6@bootlin.com>


--ljvRn32hn8AsjPHI
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 16, 2024 at 07:56:16AM +0200, Luca Ceresoli wrote:
> -Each input in this example has a kcontrol associated with it (defined in=
 example
> -above) and is connected to the output mixer via its kcontrol name. We ca=
n now
> -connect the destination widget (wrt audio signal) with its source widget=
s.
> -::
> +Each input in this example has a kcontrol associated with it (defined in
> +the example above) and is connected to the output mixer via its kcontrol
> +name. We can now connect the destination widget (wrt audio signal) with =
its
> +source widgets.  ::
> <snipped>...
> -Interconnections are created with a call to:
> -::
> +Interconnections are created with a call to::
> =20

Not strictly related to this patch, but for consistency, I'd like
to write remaining literal block markers at the end of previous
paragraph:

---- >8 ----
diff --git a/Documentation/sound/soc/dapm.rst b/Documentation/sound/soc/dap=
m.rst
index f76fc97dd16219..e4c44d08c8380b 100644
--- a/Documentation/sound/soc/dapm.rst
+++ b/Documentation/sound/soc/dapm.rst
@@ -180,15 +180,13 @@ Path Domain Widgets
 -------------------
=20
 Path domain widgets have a ability to control or affect the audio signal or
-audio paths within the audio subsystem. They have the following form:
-::
+audio paths within the audio subsystem. They have the following form::
=20
   SND_SOC_DAPM_PGA(name, reg, shift, invert, controls, num_controls)
=20
 Any widget kcontrols can be set using the controls and num_controls member=
s.
=20
-e.g. Mixer widget (the kcontrols are declared first)
-::
+e.g. Mixer widget (the kcontrols are declared first)::
=20
   /* Output Mixer */
   static const snd_kcontrol_new_t wm8731_output_mixer_controls[] =3D {
@@ -244,8 +242,7 @@ Virtual Widgets
=20
 Sometimes widgets exist in the codec or machine audio graph that don't hav=
e any
 corresponding soft power control. In this case it is necessary to create
-a virtual widget - a widget with no control bits e.g.
-::
+a virtual widget - a widget with no control bits e.g::
=20
   SND_SOC_DAPM_MIXER("AC97 Mixer", SND_SOC_NOPM, 0, 0, NULL, 0),
=20
@@ -316,7 +313,7 @@ For example the WM8731 output mixer (wm8731.c) has 3 in=
puts (sources):
 Each input in this example has a kcontrol associated with it (defined in
 the example above) and is connected to the output mixer via its kcontrol
 name. We can now connect the destination widget (wrt audio signal) with its
-source widgets.  ::
+source widgets::
=20
 	/* output mixer */
 	{"Output Mixer", "Line Bypass Switch", "Line Input"},
@@ -347,8 +344,7 @@ Machine Widget Interconnections
 Machine widget interconnections are created in the same way as codec ones =
and
 directly connect the codec pins to machine level widgets.
=20
-e.g. connects the speaker out codec pins to the internal speaker.
-::
+e.g. connects the speaker out codec pins to the internal speaker::
=20
 	/* ext speaker connected to codec pins LOUT2, ROUT2  */
 	{"Ext Spk", NULL , "ROUT2"},

Thanks.

--=20
An old man doll... just what I always wanted! - Clara

--ljvRn32hn8AsjPHI
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZh9RCAAKCRD2uYlJVVFO
o6WpAQDqeQVtGKQFGdD1X92culQ6ywquZCZjyL1KTr2mheywigEA8mh479ZKhKPs
GpSKPy9F/aEyiG2pG89/J2bGkXHVtwY=
=i9o4
-----END PGP SIGNATURE-----

--ljvRn32hn8AsjPHI--