Received-SPF: pass (google.com: domain of linux-kernel+bounces-147951-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Sai Krishna Gajula <saikrishnag@marvell.com>
To: Simon Horman <horms@kernel.org>
CC: "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com"
	<edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        Hariprasad Kelam
	<hkelam@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>
Subject: Re: [net-next PATCH] octeontx2-pf: Add ucast filter count
 configurability via devlink.
Thread-Topic: [net-next PATCH] octeontx2-pf: Add ucast filter count
 configurability via devlink.
Thread-Index: AQHakIaWlkZ9Gh8L9EajC5AeXoKhZA==
Date: Wed, 17 Apr 2024 05:17:49 +0000
Message-ID: 
 <BY3PR18MB47071C9FB7E516063668825EA00F2@BY3PR18MB4707.namprd18.prod.outlook.com>
References: <20240414105830.678293-1-saikrishnag@marvell.com>
 <20240416102236.GH2320920@kernel.org>
In-Reply-To: <20240416102236.GH2320920@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?An6QCV09SQKZGWSyTq287fNuVXaJCNgfOGBw2Q/bGqr8T1cVpRq+fWQWAjCp?=
 =?us-ascii?Q?DQvMQgP+l26NRJDzTk8WY3x2inEOynKjVikelmnAoLB6krZdYRHMtEJ1mg0d?=
 =?us-ascii?Q?HUhfdlIxMrMoZct6rJY/AYCmLexevB2ZQ4drph7OeLC7WVqNDJtEKjzFNbgZ?=
 =?us-ascii?Q?gRfnatIw3VP67FZpwfp1P5akf21myZuvL4c+5GGf1HZmqKW8waVSMeTD1hh9?=
 =?us-ascii?Q?KDx5HPGHvicIjkAoTak9Qf/ttttydzWCSlN7+oSK1frAFGFEutYm/1bIsr5D?=
 =?us-ascii?Q?S1rG2Fa/xFM5edvrUIrq8+vZxCKFZpoVXPleuvQo5MEnABH5OAoI80Mh+OTh?=
 =?us-ascii?Q?bPS7ac/cWLc6JIAX0aQPTZSye+xRwF2fy4/9zM+g7zzC1Qk37Fgi7FoSLIvd?=
 =?us-ascii?Q?Itc/49PqlVlhnF6JlahAiXR794JZ0f+S8ZG4W+B6FFZwnMuX5UIu3q/5HfLe?=
 =?us-ascii?Q?ilYvv/G2sxLn+q6PCUaczu+5BiLsJvzpKPBjjeUBRDpxCJvnK8YW/XRDAMIR?=
 =?us-ascii?Q?GXMNwQtk8PG2mKc+t1GWmnxSe/k7DQtFle05prH1LoipMFSlyFVqANYyrh/B?=
 =?us-ascii?Q?SsAoxgmQRW0JwQ6VEPilpN2NU2E15hcJlS0CzU8E/njxlKSifs4dLjPRRdJ4?=
 =?us-ascii?Q?3SycNmK76XUZD4bRMS8+1o3pcpvM/DRJUuFNa5fo87xOkYgjNoIXN65El3Ye?=
 =?us-ascii?Q?WRGsyjvburOi1qpQZHZVpHXmTCnduaruZqkLbCtkLaso0zw6vRGY35/QiZki?=
 =?us-ascii?Q?EeYKrfeOLHOfC7z/8lGEhE/EADf3il4A/fO14EwubuJ/xA/1bJYgZ72joEMG?=
 =?us-ascii?Q?QlzYKsERLoyYIoweU/PI6zBBvhodoxqSxukkuYhZu/tNXQmnO1VgsGWV9pI6?=
 =?us-ascii?Q?aKNbWZwZKzvBMBkrppR3vBt+cxmB8gYOaD29MlHyEIY0/B3ULQH/cZpxXpTR?=
 =?us-ascii?Q?O6dvfRJbON8KaRZ5vb7bgg4/gB2lJFGJwxxBWM+k4uXk4QumJoJFDHPkO218?=
 =?us-ascii?Q?WJ/G27WNHzXAR/vl6AhCnkodgFxbOL0wNx48rLHmK7W7B80nZ1loghY/LYMG?=
 =?us-ascii?Q?pTyOHX06xqHQnw2BrwqBmUrmh2S4luLrSOZn2a2S+bSegHsr6MwI341xjPgV?=
 =?us-ascii?Q?jYh99d7r0Vtzs8k1GZnLPiZzIlOo2ThmYUDiE4IGX9zbap1zoOovEvpefG20?=
 =?us-ascii?Q?v6u7Ba3pOoHZY96ATiVGCahWqkSlj02ayf6mFO1bWYIp72ZxJg+H3wJGDwsr?=
 =?us-ascii?Q?A8pKlpHj+wrd+EhIso4dsm180/7R8Ws5GFkWpdhAbS9UkmvgY03W78sSWDwR?=
 =?us-ascii?Q?fTPpjvLCTeyHBnsRr5u3Nd3YCc2qn+xxPHdY6lOg/lFnoOSjR/nGUkZ8Wt3T?=
 =?us-ascii?Q?GGcXEuRbdUfzfj0fzUlwY5H25qpsqzYUfd9GHZxjPcGZF/nCaajcyAX5mkMh?=
 =?us-ascii?Q?2gV33SUORkk5ghowoMXLFk5uvogrwxmoYvwGDjq5bUbH//YUTFA8S8y59W7N?=
 =?us-ascii?Q?uf2RRB8fZTOYZ/lhPEBqDFhg4PjFAHc8qNs7Ycbd2fD2GZRvsNrhj5Niu5aK?=
 =?us-ascii?Q?U7ohn7/qFmREpzp0pchZi75NPdFqghz9v4J334vx?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY3PR18MB4707.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 33a7f982-dfdf-4e17-9fe8-08dc5e9db949
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Apr 2024 05:17:49.0978
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: IVa/X++mTw6LrHHOd07DqzPUDbAznkth73XXIgQZWUeesdIg/+U7IjAjCZCuCP8JMwZqqFBZleMZ2yQ8R6IDzg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB5815
X-Proofpoint-GUID: Z6b7AvIeGQrXprujbyjV8tQOWn94CTN_
X-Proofpoint-ORIG-GUID: Z6b7AvIeGQrXprujbyjV8tQOWn94CTN_
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-17_04,2024-04-16_01,2023-05-22_02


> -----Original Message-----
> From: Simon Horman <horms@kernel.org>
> Sent: Tuesday, April 16, 2024 3:53 PM
> To: Sai Krishna Gajula <saikrishnag@marvell.com>
> Cc: davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
> pabeni@redhat.com; netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
> Sunil Kovvuri Goutham <sgoutham@marvell.com>; Geethasowjanya Akula
> <gakula@marvell.com>; Hariprasad Kelam <hkelam@marvell.com>; Subbaraya
> Sundeep Bhatta <sbhatta@marvell.com>
> Subject: Re: [net-next PATCH] octeontx2-pf: Add ucast filter
> count configurability via devlink.
>=20
> On Sun, Apr 14, 2024 at 04:28:30PM +0530, Sai Krishna wrote:
> > Added a devlink param to set/modify unicast filter count. Currently
> > it's hardcoded with a macro.
>=20
> Hi Sai,
>=20
> I think it would be nice to provide a sample devlink command in the patch
> description, as you did for:
>=20
> 2da489432747 ("octeontx2-pf: devlink params support to set mcam entry
> count")
>=20
> > Signed-off-by: Sai Krishna <saikrishnag@marvell.com>

Ack, yeah.. missed to add example command. Will do in patch v2.

>=20
> ...
>=20
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_devlink.c
> > b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_devlink.c
>=20
> ...
>=20
> > +static int otx2_dl_ucast_flt_cnt_get(struct devlink *devlink, u32 id,
> > +				     struct devlink_param_gset_ctx *ctx) {
> > +	struct otx2_devlink *otx2_dl =3D devlink_priv(devlink);
> > +	struct otx2_nic *pfvf =3D otx2_dl->pfvf;
> > +
> > +	if (!pfvf->flow_cfg) {
> > +		ctx->val.vu8 =3D 0;
> > +		return 0;
> > +	}
> > +
> > +	ctx->val.vu8 =3D pfvf->flow_cfg->ucast_flt_cnt;
>=20
> nit: perhaps this could be more succinctly expressed as follows
>      (completely untested!):
>=20
> 	ctx->val.vu8 =3D pfvf->flow_cfg ? pfvf->flow_cfg->ucast_flt_cnt : 0;

Ack, Will submit changes with patch V2.

>=20
> > +
> > +	return 0;
> > +}
>=20
> ...