Received: by 2002:a05:6500:1b45:b0:1f5:f2ab:c469 with SMTP id cz5csp407990lqb; Tue, 16 Apr 2024 22:40:23 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWbZEUawKhv7SyXDKaAsSEzmrJ3uFKD02jmLgQNFJ36POIxhnPeUEMb1yQB6lqkD5jEB7cgk8kcpiq8to8pm0c5gaLUp4TMEPk16QrLTg== X-Google-Smtp-Source: AGHT+IFipc/mepSj5CSdcdOfIalmdULvkpeaxOlD/8DYl/PA9mnhsOQbZAkYvFE9cHkAAmuS6CzP X-Received: by 2002:a05:6a20:9683:b0:1a7:9b0e:ded3 with SMTP id hp3-20020a056a20968300b001a79b0eded3mr4948162pzc.11.1713332423168; Tue, 16 Apr 2024 22:40:23 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713332423; cv=pass; d=google.com; s=arc-20160816; b=Hklw4+dIpC+xfEl+BfzsCpreEgbw5rnjXCWtUHwsyYWs4lOHkrYuJPEyEVWElSmwm5 0KyfUo1t4fEhPbKf5riBznGDI5AO2wFTP1cNd6MaLaI0TZX9LkM8QIwmhL7S84oW7H+D rDwDLjqxd8LoXCdyHEmPZ8TmpyACi9TfyiRCUBiikuEGA5GlP2ZRR5UK2fFEPMl0ObHY 4KMnXuItD4SR9kzPsadtZ5o5HVQe520w2ExZORQRyKtdnpiG3GlsP+ddJtphHlMfHPix 6ijth4foknm1eQClwjQRyDrCPInJjK+AV0x725tfvTCa/tWO8erQO9qJ33LNvPNHUJjz mbjw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=Tja13tUxWujBeBowvLyZF3D1C9kFN64gKj+s8+p2K80=; fh=PwK/oPHy5EcJUcn09tqRSF6bDW8OKWves4R/1As/jCk=; b=M+chXd+ScJ81BttDpXGTmKRyEhi7rZsWYYs9nIth1+Q1ZPzcErt/e62ggyzbDRH+eI twuIAToEnlgGhfTySVael3CRNj19Q7661nLahehPr1t32201Q/jJ2Ptyi/COq9eiw97P jcamDhtIykxgWAwZmbD1VY6ak+Ck7QVK2V2o9l3mkBIrDRhhtSFlLNAvmXwe/qTAOSFJ jZ6HK1XSR4qPtGigJM4WJXjHB/Wj8NfTdPcwfC0ygqOtuKPpkqGsy4Y8iSZ/de3yGXyw HT6aWEPqFm4IKPletBYBy3B9ChTWSlBz0PuJf9iWZibRfa6vR8mPpEqh7LNM0zZwDOY2 sAHA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=easystack.cn dmarc=pass fromdomain=easystack.cn); spf=pass (google.com: domain of linux-kernel+bounces-147966-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-147966-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=easystack.cn Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id s22-20020a056a00179600b006ea8c975ef0si11181407pfg.398.2024.04.16.22.40.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 22:40:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-147966-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=easystack.cn dmarc=pass fromdomain=easystack.cn); spf=pass (google.com: domain of linux-kernel+bounces-147966-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-147966-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=easystack.cn Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id A33DEB21E28 for ; Wed, 17 Apr 2024 05:40:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2CBA052F83; Wed, 17 Apr 2024 05:40:11 +0000 (UTC) Received: from mail-m6032.netease.com (mail-m6032.netease.com [210.79.60.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90803374D1; Wed, 17 Apr 2024 05:39:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.79.60.32 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713332410; cv=none; b=VBmu9zkwFkpyhm5B1XBj44SEHnkMgZEfqEufNd4wJr+g8qWqKvoaJe7Bq1FW0PxRKo7TuI0k5IYBVKbNbb0ZFDK59urzCeU18y9x7RzY0CnmM12u+c0gm2ihaJsA0qg0/OM4TDeWXtUWMilhEcK5Ka4V1b+AisVWHdyAJVTC62Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713332410; c=relaxed/simple; bh=Ltslny75LkzlJPbQlvxP8LqFwrA/4+HYUrJy8OCDhcM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=q1cFk9pH2v6q8GC5HZgvYMTw4F6xrs8AKGUOJ3z66kldJE0Ew/BECXJ0Ja9X+bRSidS+EW0SJnv4pcw2ooaK4+Ycfgo+3MLHDJyl/Sv0ILZmcTh9oBYJGmOrMzGI/z7XswAs1yMi6CtUTH1lR0qXK4eaSKdTgTqal0M5tDpMvc8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=easystack.cn; spf=pass smtp.mailfrom=easystack.cn; arc=none smtp.client-ip=210.79.60.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=easystack.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=easystack.cn Received: from localhost.localdomain (unknown [110.185.170.227]) by smtp.qiye.163.com (Hmail) with ESMTPA id 79C865601D6; Wed, 17 Apr 2024 12:20:48 +0800 (CST) From: "jun.gu" To: echaudro@redhat.com Cc: dev@openvswitch.org, jun.gu@easystack.cn, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH net-next v3] net: openvswitch: Check vport net device name Date: Wed, 17 Apr 2024 12:20:31 +0800 Message-Id: <20240417042031.157008-1-jun.gu@easystack.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <27644212-924C-4AB2-88F6-D209E2586E82@redhat.com> References: <27644212-924C-4AB2-88F6-D209E2586E82@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFJQjdXWS1ZQUlXWQ8JGhUIEh9ZQVlCH0IZVk0aSkNPQk8dTxlJTlUZERMWGhIXJBQOD1 lXWRgSC1lBWUpKS1VKQ05VSkxLVUlJTFlXWRYaDxIVHRRZQVlPS0hVSk1PSUxOVUpLS1VKQktLWQ Y+ X-HM-Tid: 0a8eea493018023dkunm79c865601d6 X-HM-MType: 1 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6PyI6Iyo5FTcrQiEWDxcqDwIV FFYKCQFVSlVKTEpISElMTU9CSkpPVTMWGhIXVREOFVUcDjseGggCCA8aGBBVGBVFWVdZEgtZQVlK SktVSkNOVUpMS1VJSUxZV1kIAVlBSkNDQjcG Check vport net device name to ensure the provided name is not one of its aliases. This can avoid that ovs userspace create and destroy vport repeatedly. Signed-off-by: Jun Gu --- net/openvswitch/vport-netdev.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/openvswitch/vport-netdev.c b/net/openvswitch/vport-netdev.c index 903537a5da22..7003e76b8172 100644 --- a/net/openvswitch/vport-netdev.c +++ b/net/openvswitch/vport-netdev.c @@ -78,7 +78,10 @@ struct vport *ovs_netdev_link(struct vport *vport, const char *name) int err; vport->dev = dev_get_by_name(ovs_dp_get_net(vport->dp), name); - if (!vport->dev) { + /* Ensure that the device exists and that the provided + * name is not one of its aliases. + */ + if ((!vport->dev) || strcmp(name, ovs_vport_name(vport))) { err = -ENODEV; goto error_free_vport; } -- 2.25.1