Received-SPF: pass (google.com: domain of linux-kernel+bounces-147989-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240414045124.3098560-1-dmitrii.bundin.a@gmail.com>
 <Zh0ZhEU1xhndl2k8@krava> <CANXV_Xwmf-VH5EfNdv=wcv8J=2W5L5RtOs8n-Uh5jm5a1yiMKw@mail.gmail.com>
 <Zh4ojsD-aV2vHROI@krava> <ddc0ac5b-9bd4-f31a-a7ec-83f7a10e6ab1@iogearbox.net>
In-Reply-To: <ddc0ac5b-9bd4-f31a-a7ec-83f7a10e6ab1@iogearbox.net>
From: Dmitrii Bundin <dmitrii.bundin.a@gmail.com>
Date: Wed, 17 Apr 2024 09:26:03 +0300
Message-ID: <CANXV_XwGhdV7v05Xjjp-g9yW4E0FjA=84M8jZ6bcf7yuooDkig@mail.gmail.com>
Subject: Re: [PATCH] bpf: btf: include linux/types.h for u32
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: Jiri Olsa <olsajiri@gmail.com>, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, 
	haoluo@google.com, sdf@google.com, kpsingh@kernel.org, 
	john.fastabend@gmail.com, yonghong.song@linux.dev, song@kernel.org, 
	eddyz87@gmail.com, andrii@kernel.org, ast@kernel.org, martin.lau@linux.dev, 
	khazhy@chromium.org, vmalik@redhat.com, ndesaulniers@google.com, 
	ncopa@alpinelinux.org, dxu@dxuuu.xyz
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 16, 2024 at 5:47=E2=80=AFPM Daniel Borkmann <daniel@iogearbox.n=
et> wrote:
> Please add the error description as motivation aka "why" into the commit
> description, otherwise it's not really obvious looking at it at a later
> point in time why the include was needed.

Doesn't the comment /* for u32 */ following the include explain the
purpose? I thought the include was actually missing since relying on
indirect declaration of u32 is relatively fragile.