Received-SPF: pass (google.com: domain of linux-kernel+bounces-147990-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Wed, 17 Apr 2024 09:28:44 +0300 (EEST)
To: Mohamed Ghanmi <mohamed.ghanmi@supcom.tn>
cc: "Luke D. Jones" <luke@ljones.dev>, Hans de Goede <hdegoede@redhat.com>, 
    corentin.chary@gmail.com, platform-driver-x86@vger.kernel.org, 
    LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: asus-wmi: add support for vivobook fan
 profiles
In-Reply-To: <Zh6oooU-DL2IXLg9@laptop>
Message-ID: <e61ddc4f-5e55-248c-72fa-3c15d6316961@linux.intel.com>
References: <20240413202112.37729-1-luke@ljones.dev> <dccc5701-f533-e80e-09f8-199f232f447f@linux.intel.com> <Zh6oooU-DL2IXLg9@laptop>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323328-1066009640-1713335324=:1007"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-1066009640-1713335324=:1007
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Tue, 16 Apr 2024, Mohamed Ghanmi wrote:

> On Tue, Apr 16, 2024 at 03:51:03PM +0300, Ilpo J=E4rvinen wrote:
> > On Sun, 14 Apr 2024, Luke D. Jones wrote:
> >=20
> > > From: Mohamed Ghanmi <mohamed.ghanmi@supcom.tn>
> > >=20
> > > Add support for vivobook fan profiles wmi call on the ASUS VIVOBOOK
> > > to adjust power limits.
> > >=20
> > > These fan profiles have a different device id than the ROG series.


> > > and different order.
> >=20
> > Fix grammar.
>=20
> my grammar is not the greatest so i'm finding it hard to know what is
> the error you're referring to but I think that 'add'
> should become 'adds' ?

That's not what I was referring to, you've a dangling/broken "sentence"
right in front of my reply:=20

"and different order."

Please fix that. Perhaps you just want to remove the stop (".") from=20
the previous sentence to join the sentences together?

--=20
 i.

--8323328-1066009640-1713335324=:1007--