Received-SPF: pass (google.com: domain of linux-kernel+bounces-147997-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 17 Apr 2024 06:36:10 +0000 (UTC)
From: Prasad Pandit <pjp@fedoraproject.org>
Reply-To: Prasad Pandit <pj.pandit@yahoo.in>
To: Joe Perches <joe@perches.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, 
	Dwaipayan Ray <dwaipayanray1@gmail.com>, 
	Lukas Bulwahn <lukas.bulwahn@gmail.com>, 
	Andy Whitcroft <apw@canonical.com>, 
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>, 
	Dan Carpenter <dan.carpenter@linaro.org>
Message-ID: <776311640.119588.1713335770163@mail.yahoo.com>
In-Reply-To: <a582c379f1bc2bc0d16b46ece9211bac40b4b7cf.camel@perches.com>
References: <20240330033858.3272184-1-ppandit@redhat.com> <1568855168.5949322.1713251087824@mail.yahoo.com> <2024041627-overgrown-ripping-2348@gregkh> <edf23b1b-303a-46eb-b455-8c766c84ddf1@moroto.mountain> <a582c379f1bc2bc0d16b46ece9211bac40b4b7cf.camel@perches.com>
Subject: Re: [PATCH] checkpatch: error if file terminates without a new-line
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Tuesday, 16 April, 2024 at 03:25:18 pm IST, Joe Perches wrote:=C2=A0
>There's an existing check for this. Fix that instead.
>
># check for adding lines without a newline.
> =C2=A0 =C2=A0 =C2=A0 =C2=A0if ($line =3D~ /^\+/ && defined $lines[$linenr=
]
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&& $lines[$linenr] =3D~ /^\\ No =
newline >at end of file/) {
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (WARN("MISSING_EOF_NEWLINE",
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"add=
ing a line without newline at end of file\n" . $herecurr) &&
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0$fix) {
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0fix_delete_line($f=
ixlinenr+1, "No newline at end of file");


Okay, will check; Thank you.
---
=C2=A0 -Prasad