Received: by 2002:a05:6500:1b45:b0:1f5:f2ab:c469 with SMTP id cz5csp432067lqb; Tue, 16 Apr 2024 23:55:43 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXoQnYf+v6Knv8wu/oStWbDwk+q+taq3379Z3gM9i56C70/EpeYeXOpGzPzTU9f2/lGR5zpjjdO/XJ4t9LLEyaSVhL0JsszdQ1H2/YosQ== X-Google-Smtp-Source: AGHT+IFDeEy5HBBGhv8rFTmdmWoVWcyvkORMJ3x12GAdCpOE6hErLNRkUH4gt4wqB1PiF3H12xuv X-Received: by 2002:a17:90a:b00d:b0:2a7:8794:bd9d with SMTP id x13-20020a17090ab00d00b002a78794bd9dmr8951583pjq.39.1713336943659; Tue, 16 Apr 2024 23:55:43 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713336943; cv=pass; d=google.com; s=arc-20160816; b=haIfRaYaOo4evnn6UtZffVcYtSdAWFWNUWTqeymfD/Bx6ZuR4Eqgc9Sux6oUUc5Lxl Ng78A57fsvpfeQQiUbxlXf06fmkUT95NfrtMZ0vMN3t2ZGkq1udDp1yEnKiaWtWFobEJ nBdez7EUm+H/pwyW5R3mkmBC5SnwK0E8P6YklV4zGgUeI0EqjVdJA4d1noqSP1Us2eWS 6VuXla6863g2bGJP5JTwtRoKyIaq+Vyh1cxo6YMyteZXSscQLtiPbqIuaBiqgtds7lAN f1fH/vQz4ZA2rSxBpY0oKGbzDI82doJ9jkgj1I+S/L9wxdoZAc2nJz/nCMgBGSJsiUU/ KHiQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=sZGbmlRk8OYQ6Kpz+Jg/xu+IlJYAq+3AXIsG/wFcBY0=; fh=f9vV5zJs781COG25EYEwfV+S/1qNM27hdbnAHOS4NFg=; b=hMcHsv5D6KR3Fn2ijN58GBzqnceNlXPUCEN578l7JHuMo9mIdH0LbHDTFuF5Hfa5sg hyBrMDK9NdDP7FtOEW67eeL30Xwl1LnFLwARhEu6SN7y3R6VourzKlqQh7M1v/t7mw+0 422xuXIzP5fAJGBNtlFJeZrz+tXhkZkmYs++olEXLK0TVNNzLcpttw1WxMF8CQc1SR+n qlws4arxnBxOzJvcrJd/rCUblimQVqPDtKpjmq0OZlfDdyadu3uyv3pAYLm5iei9i6+Y J5up7rpNz1dgMrb9deYR+DjebwC1U2zPBIqvSq5I+NGYzhskjNoECzZ7ahUzQVLThzqi 7/Qg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@ventanamicro.com header.s=google header.b=TVsER2kn; arc=pass (i=1 spf=pass spfdomain=ventanamicro.com dkim=pass dkdomain=ventanamicro.com); spf=pass (google.com: domain of linux-kernel+bounces-148014-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-148014-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id i6-20020a17090ad34600b002a2a70f148bsi783547pjx.69.2024.04.16.23.55.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 23:55:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-148014-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@ventanamicro.com header.s=google header.b=TVsER2kn; arc=pass (i=1 spf=pass spfdomain=ventanamicro.com dkim=pass dkdomain=ventanamicro.com); spf=pass (google.com: domain of linux-kernel+bounces-148014-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-148014-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 36B742814E2 for ; Wed, 17 Apr 2024 06:55:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BE8526A037; Wed, 17 Apr 2024 06:55:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="TVsER2kn" Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AC6465E02 for ; Wed, 17 Apr 2024 06:55:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713336936; cv=none; b=EjiA1tfYgl5mggUpJ5PoyywXopTLizf42uO+9gcT7150wKzyQYjOVLLPXs0ArQVhjK7zf8jM55hxWsllZu9uxA0KjiWuNbip053PMfWIg5wHip0I9fkq594qUHhoDNJznqZhYwSwyDHwE/F6Z6540ULCgk9p5DL9Uc8DNbpfGWc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713336936; c=relaxed/simple; bh=J/5WdNXiH+xHiAy5PvoJmYo9TGP4hl9SHOTN5CBH+b4=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=Y6of5TOT6+01ZNq2k/PfuCj4LAXBocVe5wNiDevncVlzBPpewcbPtrpvJmaE8aM1+agDc3XbOZmjSmi6yHYyr4gARIea+S3QYLrMYGnDHDIWF19W4mgWhRG+41WZyK6xT3FsnqQVb0WrJChLZFuqyLcHxULl7aMA0L300zsmeUk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com; spf=pass smtp.mailfrom=ventanamicro.com; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b=TVsER2kn; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ventanamicro.com Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-518a56cdc03so4547707e87.1 for ; Tue, 16 Apr 2024 23:55:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1713336933; x=1713941733; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=sZGbmlRk8OYQ6Kpz+Jg/xu+IlJYAq+3AXIsG/wFcBY0=; b=TVsER2knIM6Cl/nrl/4UK7g05JsFLstuf9zJ/0xVgrVuF2oE6mLDi65/XvSfS2hWMa 4tsNP4UM93HikvF6qrqU6B/TcvCWFOPfstw74Lr+vRlNCyjXziRrpdzl/lc24saK8odj X6TMfTVZDsf/15pTt+yJkgeRW9/PSymOe1O2z7zD765tJcp9dSj2WZWW4IiEZpZp2YV3 NpiuNQGk8ezjvXtOdiRFkM/45Zo1RP7ihElBryG0ib2plZVaqqSPG2hv1qdzHr8/K8OS G6YgngjJLrBNXIpCTBk/a7sYNiduEQ/kuijZeQqkFw1CKqfXv3bAvaZ5esjQXx/ASiXA GiLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713336933; x=1713941733; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sZGbmlRk8OYQ6Kpz+Jg/xu+IlJYAq+3AXIsG/wFcBY0=; b=nQARO4laIaLbynh0CZ1WjWEZ1wT8N1JatfYULFGy2v/2GhHZYWjCLhp32MJSyW2a3X er1EeiQ9iiNnbIvWFeBadZvlQ82WH/p+vjaIBAF0NXx7J0fp3mOj5dnVvJpz8XKugwOG vXzSvJdu1RL1+oiOTqrrmAemTrgxWNXMV6CCRDFTCsejNT0LC/limjt+87AFObKp7Z50 iscfV95VGz8+P+rLK3g1C6NSzoYGI1kxFKnMFZ4BisZqwr7FRcz5pfB658suWspSxjsm GAWg1ABxLMFNV4NBBbn5E5O1Cgq30oP03PcpVMH2mkDWpj9w5nZuPPwuXRNoXonM0Lc2 3wKA== X-Forwarded-Encrypted: i=1; AJvYcCUp6OXznqYjOCvnKqXoBL9fx5xtKLY0l1lLaiNXQSabueWN8TAQnRiw5rT1GWIk4QME1psTQWwBgqWo2Dm34WBj+Osm2HmFn3dPMWvY X-Gm-Message-State: AOJu0YwDAnN5aI4R3x8x4Gk0w5Tl/5+j1JmJ6RV/HXRE4mumnEWVN4LY MnlgfBsLaR9dObRimY7XbY/RlSPcnwNF8Kl4MGTKYh7gqITjo0G3oKhTQgIlN8vomQp0tYeQ27K QU2zgRGQpP13hUoVhpmoKShx5JINziH1BhWI40g== X-Received: by 2002:a2e:8049:0:b0:2d9:f7f8:3e88 with SMTP id p9-20020a2e8049000000b002d9f7f83e88mr7913210ljg.33.1713336933078; Tue, 16 Apr 2024 23:55:33 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240413091942.316054-1-apatel@ventanamicro.com> <20240416141049.GA2148267-robh@kernel.org> In-Reply-To: <20240416141049.GA2148267-robh@kernel.org> From: Anup Patel Date: Wed, 17 Apr 2024 12:25:20 +0530 Message-ID: Subject: Re: [PATCH v2] of: property: Add fw_devlink support for interrupt-map property To: Rob Herring Cc: Saravana Kannan , Palmer Dabbelt , Paul Walmsley , Atish Patra , Andrew Jones , Sunil V L , Anup Patel , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Apr 16, 2024 at 7:41=E2=80=AFPM Rob Herring wrote= : > > On Sat, Apr 13, 2024 at 02:49:42PM +0530, Anup Patel wrote: > > Some of the PCI controllers (such as generic PCI host controller) > > use "interrupt-map" DT property to describe the mapping between > > PCI endpoints and PCI interrupt pins. This the only case where > > the interrupts are not described in DT. > > > > Currently, there is no fw_devlink created based on "interrupt-map" > > DT property so interrupt controller is not guaranteed to be probed > > before PCI host controller. This affects every platform where both > > PCI host controller and interrupt controllers are probed as regular > > platform devices. > > > > This creates fw_devlink between consumers (PCI host controller) and > > supplier (interrupt controller) based on "interrupt-map" DT property. > > > > Signed-off-by: Anup Patel > > --- > > Changes since v1: > > - Updated commit description based on Rob's suggestion > > - Use of_irq_parse_raw() for parsing interrupt-map DT property > > --- > > drivers/of/property.c | 58 +++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 58 insertions(+) > > > > diff --git a/drivers/of/property.c b/drivers/of/property.c > > index a6358ee99b74..67be66384dac 100644 > > --- a/drivers/of/property.c > > +++ b/drivers/of/property.c > > @@ -1311,6 +1311,63 @@ static struct device_node *parse_interrupts(stru= ct device_node *np, > > return of_irq_parse_one(np, index, &sup_args) ? NULL : sup_args.n= p; > > } > > > > +static struct device_node *parse_interrupt_map(struct device_node *np, > > + const char *prop_name, int= index) > > +{ > > + const __be32 *imap, *imap_end, *addr; > > + struct of_phandle_args sup_args; > > + struct device_node *tn, *ipar; > > + u32 addrcells, intcells; > > + int i, j, imaplen; > > + > > + if (!IS_ENABLED(CONFIG_OF_IRQ)) > > + return NULL; > > + > > + if (strcmp(prop_name, "interrupt-map")) > > + return NULL; > > + > > + ipar =3D of_node_get(np); > > + do { > > + if (!of_property_read_u32(ipar, "#interrupt-cells", &intc= ells)) > > + break; > > + tn =3D ipar; > > + ipar =3D of_irq_find_parent(ipar); > > + of_node_put(tn); > > + } while (ipar); > > No need for this loop. We've only gotten here if 'interrupt-map' is > present in the node and '#interrupt-cells' is required if > 'interrupt-map' is present. Ahh, okay. I will update. > > > + if (!ipar) > > + return NULL; > > + addrcells =3D of_bus_n_addr_cells(ipar); > > + of_node_put(ipar); > > + > > + imap =3D of_get_property(np, "interrupt-map", &imaplen); > > + if (!imap || imaplen <=3D (addrcells + intcells)) > > + return NULL; > > + imap_end =3D imap + imaplen; > > + > > + sup_args.np =3D NULL; > > + for (i =3D 0; i <=3D index && imap < imap_end; i++) { > > + if (sup_args.np) { > > + of_node_put(sup_args.np); > > + sup_args.np =3D NULL; > > + } > > + > > + addr =3D imap; > > + imap +=3D addrcells; > > + > > + sup_args.np =3D np; > > + sup_args.args_count =3D intcells; > > + for (j =3D 0; j < intcells; j++) > > + sup_args.args[j] =3D be32_to_cpu(imap[j]); > > + imap +=3D intcells; > > + > > + if (of_irq_parse_raw(addr, &sup_args)) > > + return NULL; > > + imap +=3D sup_args.args_count + 1; > > + } > > Doesn't this leak a ref on the last time the function is invoked? For > example, if we have 2 entries and index is 2. We'll get index=3D1, but > then exit because imap=3D=3Dimap_end. We need a put on index=3D=3D1 node. Okay, I will update. > > Look at my next branch where I've converted things to use __free() > cleanups. I don't see it helping here as-is, but maybe when it is > correct. > Okay, I will check your next branch. Thanks, Anup