Received-SPF: pass (google.com: domain of linux-kernel+bounces-148029-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240415123941.1527938-1-github.com@herrie.org> <1158f240-ea6b-4ac7-9697-a30d27311c50@linaro.org>
In-Reply-To: <1158f240-ea6b-4ac7-9697-a30d27311c50@linaro.org>
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Date: Wed, 17 Apr 2024 10:10:05 +0300
Message-ID: <CAA8EJpoAawTDCED3A4mNj0FkyQddxvaiUeY8R4KXmPQncufUOQ@mail.gmail.com>
Subject: Re: [PATCH] mfd: pm8xxx: add support for PM8901
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Herman van Hazendonk <github.com@herrie.org>, andersson@kernel.org, benwolsieffer@gmail.com, 
	chris.chapuis@gmail.com, Lee Jones <lee@kernel.org>, linux-arm-msm@vger.kernel.org, 
	linux-kernel@vger.kernel.org, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Content-Type: text/plain; charset="UTF-8"

On Mon, 15 Apr 2024 at 22:31, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
>
>
> On 4/15/24 14:39, Herman van Hazendonk wrote:
> > Add support for the pm8901 PMIC used by msm8660.
> >
> > Signed-off-by: Herman van Hazendonk <github.com@herrie.org>
> > ---
> >   drivers/mfd/qcom-pm8xxx.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mfd/qcom-pm8xxx.c b/drivers/mfd/qcom-pm8xxx.c
> > index 8b6285f687da..9cca14d54d8d 100644
> > --- a/drivers/mfd/qcom-pm8xxx.c
> > +++ b/drivers/mfd/qcom-pm8xxx.c
> > @@ -501,6 +501,7 @@ static const struct pm_irq_data pm8821_data = {
> >   static const struct of_device_id pm8xxx_id_table[] = {
> >       { .compatible = "qcom,pm8058", .data = &pm8xxx_data},
> >       { .compatible = "qcom,pm8821", .data = &pm8821_data},
> > +     { .compatible = "qcom,pm8901", .data = &pm8xxx_data},
> >       { .compatible = "qcom,pm8921", .data = &pm8xxx_data},
>
> Please refrain from adding this new compatible, instead add a new,
> generic one and modify the dt-bindings such that we go like:
>
> compatible = "qcom,pm8901", "qcom,pm8xxx-ssbi-pmic"

I'd suggest against this. These PMICs were similar by nature, but not
fully compatible. Also we should not be using wildcards in compatible
strings.
I think the proposed string is fine.

Herman, I see that these patches are not properly threaded. Please
consider using the 'b4' tool for preparing and sending patches.
See https://b4.docs.kernel.org/en/latest/contributor/prep.html and
https://b4.docs.kernel.org/en/latest/contributor/send.html


-- 
With best wishes
Dmitry