Received-SPF: pass (google.com: domain of linux-kernel+bounces-148065-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 17 Apr 2024 09:36:07 +0200
From: Joel Granados <j.granados@samsung.com>
To: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <linux@weissschuh.net>
CC: Luis Chamberlain <mcgrof@kernel.org>, Kees Cook <keescook@chromium.org>,
	Eric Dumazet <edumazet@google.com>, Dave Chinner <david@fromorbit.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 00/11] sysctl: treewide: constify ctl_table argument
 of sysctl handlers
Message-ID: <20240417073607.nuhuj2we4jln2b2j@joelS2.panther.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha512";
	protocol="application/pgp-signature"; boundary="a5ycuyf4ogpwtr2p"
Content-Disposition: inline
In-Reply-To: <25166edb-4443-421f-abba-38914db2fac4@t-8ch.de>
CMS-TYPE: 201P
References: <CGME20240323154426eucas1p12a061ae721193083fd0ed29016277017@eucas1p1.samsung.com>
	<20240323-sysctl-const-handler-v2-0-e80b178f1727@weissschuh.net>
	<20240328210016.33wqcpwatamupxyw@joelS2.panther.com>
	<cd60f573-ea02-4834-8bb9-9fef24088cfc@t-8ch.de>
	<20240408085928.dhvexnhvvugfvjkt@joelS2.panther.com>
	<a90e9483-f27b-4448-9fae-b768d8139ead@t-8ch.de>
	<20240416161819.prjyozfkvy3nddzh@joelS2.panther.com>
	<25166edb-4443-421f-abba-38914db2fac4@t-8ch.de>

--a5ycuyf4ogpwtr2p
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 16, 2024 at 09:32:24PM +0200, Thomas Wei=DFschuh wrote:
> (+Cc LKML to at least get the conversation into the archives)
>=20
> Hi Joel,
=2E..
>=20
> > Not only that, but it also breaks tools like lei and b4. I have configu=
red b4 to
> > look at https://lore.kernel.org/all to handle patches coming from contr=
ibutors.
> > If the change is not public it breaks my command (`b4 am -o - MESSAGE_I=
D | git
> > am -3`).
>=20
> Understood, as mentioned above the trimming went to far.
>=20
> FYI:
> b4 can do the `git am` itself with `b4 shazam MESSAGE_ID`.
> Use the config `b4.shazam-am-flags` for the `-3` flag.

Thx for the tip.

>=20
> > I do not know who spooked you but I suggest you just remove this person
> > from the to:/cc: of your patches and leave the rest as it is. Like I
> > did with Mathew Wilcox after he asked me to do so here
> > https://lore.kernel.org/all/ZZbJRiN8ENV%2FFoTV@casper.infradead.org/.
> > Please resend the patchset including the relevant kernel mailing lists =
and
> > maintainers but excepting the person that sent you the private e-mail.
>=20
> In addition to the complaint I also got guidance from Thomas Gleixner to
> reduce the scope of recipients.
>=20
> What do you think about the following:
>=20
> You do a review of v2 and give feedback on that and I'll incorporate
> that feedback and afterwards send a v3.
This will *not* work and this is why:
1. I will not be able to use b4 to gather SOBs (and the like) because
   there is no original mail
2. The review would be confusing in public as the original message will
   not have existed.
3. I will most likely forget to add relevant recepients.

Please resend the patch. `b4 send --resend [vN]` should work after you
have added the additional CCs.

> In addition to the recipients of v2 I'll add LKML, Greg and Andrew Morton.
It will just get lost in LKML. If you are *not* going to add all the
maintainers themselves, at least add the relevant kernel lists. These
are the lists that I propose (from running get_maintainers.pl on your
11/11 patch):

linux-fsdevel@vger.kernel.org
netdev@vger.kernel.org
linux-arm-kernel@lists.infradead.org
linux-s390@vger.kernel.org
linux-kernel@vger.kernel.org
linux-riscv@lists.infradead.org
linux-mm@kvack.org
linux-security-module@vger.kernel.org
bpf@vger.kernel.org
linuxppc-dev@lists.ozlabs.org
linux-xfs@vger.kernel.org
linux-trace-kernel@vger.kernel.org
linux-perf-users@vger.kernel.org
netfilter-devel@vger.kernel.org
coreteam@netfilter.org
kexec@lists.infradead.org
linux-hardening@vger.kernel.org
bridge@lists.linux.dev
lvs-devel@vger.kernel.org
linux-rdma@vger.kernel.org
rds-devel@oss.oracle.com
linux-sctp@vger.kernel.org
linux-nfs@vger.kernel.org
apparmor@lists.ubuntu.com

Its a long list because that patch touches everything :)


> =20
> > This also goes for your "[PATCH] sysctl: treewide: constify ctl_table_h=
eader::ctl_table_arg"
> > which is also not public.
>=20
> Thanks for this pointer, too.
> I'd like to handle it the same way as proposed above.
>=20
>=20
> Sorry for all the back-and-forth,
> Thomas

Best

--=20

Joel Granados

--a5ycuyf4ogpwtr2p
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmYfe+YACgkQupfNUreW
QU/COQv/WohiPj50zIl6EmTY6PVKv6tWKl9ldmCzg41gqQ12NzrTYkWN9hwHW0HE
Xz+n/vD2427ZEZ1oLv2IaUcpDsBtRa7s2JicOtVrcD/yjPzwgdBS6P+UFDYb40SZ
NszqoSMW5VPv73RHNt9kTwYmyhNCypHAf8B8E6Re/Nu1oFh1mGO+CkltYSOjur4I
Ec0qquVYjPNucF14eBcuMBjhXsxvqD9Y+FqWdvHPRAOnH4M32ZYEro6kQsV4Eb3R
erU1yo++ATQtz+W/Q0eFDNBIW6j+AF8d72d4xADZRfcsu4qgfJPLxkWoGoFO/1+A
GlK8OOgTliSZdkboDUCQCxhmrT04tnoah0vMX11GAyH9la9NzmIvvvU8jE/rtoki
y1u9IWxC4wVsEeFyfvXNDYAWXGOveDJJP1yC0TxVVrbaP/JhUUeeMpnwh03m59XH
oHwx41tyrjtA2Pk0J311HR8Fkq+xpJAe481wNmBWpX2E/Un6FnR2QwPku5tzjVxb
x3CkuYCr
=eMi3
-----END PGP SIGNATURE-----

--a5ycuyf4ogpwtr2p--