Received-SPF: pass (google.com: domain of linux-kernel+bounces-148089-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <d97c6518-b434-42da-bd12-88cf432d1163@amd.com>
Date: Wed, 17 Apr 2024 13:29:53 +0530
User-Agent: Mozilla Thunderbird
Reply-To: nikunj@amd.com
Subject: Re: [PATCH v8 05/16] x86/sev: Cache the secrets page address
From: "Nikunj A. Dadhania" <nikunj@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, thomas.lendacky@amd.com, x86@kernel.org,
 kvm@vger.kernel.org, mingo@redhat.com, tglx@linutronix.de,
 dave.hansen@linux.intel.com, pgonda@google.com, seanjc@google.com,
 pbonzini@redhat.com
References: <20240215113128.275608-1-nikunj@amd.com>
 <20240215113128.275608-6-nikunj@amd.com>
 <20240416144542.GFZh6PFjPNT9Zt3iUl@fat_crate.local>
 <c08e7493-2fde-4624-9395-d1b8b5ab47c7@amd.com>
Content-Language: en-US
In-Reply-To: <c08e7493-2fde-4624-9395-d1b8b5ab47c7@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?R05OcDVwTkx0SkM3dHhvdGhNZnowK2g0aXJJSHpYMHpRSjJreE1mVE11RVRv?=
 =?utf-8?B?cCtnbmVaQnVGWlluWnFmTHZmVEYzcERnV2YreDU2aUwzTGFjeFNzaDJmM2Vt?=
 =?utf-8?B?SU0yaTAzdWsyMUwwL2EwbkFZckdWQkdoa05odjFtTTlzYmQrVXY1bGxXT3Ju?=
 =?utf-8?B?b1pEQjhRMXl2NXpNdStPYnpTeFBGeUMxN3FaMjAwK2I3KzdjK056blZXYlcw?=
 =?utf-8?B?V3FCbk0wWXJKWVhucEVHUldWWURES09vL2NzZjRqVURsdnV1cURBWGhpWktp?=
 =?utf-8?B?OW5LRDZWK2IrakgydFVPYUJmT2orbGJKMEh5dndMNHg3OTRjYlNkN2d6cExL?=
 =?utf-8?B?NEZ3MGdZaUpSNlBGaTFERTUzSWVFYmRpYnFhdkdCcFZBL1BRLzhleGRLNnJv?=
 =?utf-8?B?L1NiZEpOMVZkL0N5VkRCZ0NpNE1CNU4ySUpVa2h0UGtYWUVLUkY5emh0azUr?=
 =?utf-8?B?L3loOXJMVk85blUrYVA4N3MxSzY3Wnc0Nkl0TGdTNXhFLzFNYkFBUkU4WkFm?=
 =?utf-8?B?LzIreTBjSVJWTEtWQ29rcFlhcFdOZGZvYTdGREozdGRRa21jRTlmVnp6a1pC?=
 =?utf-8?B?L0c2N1RSS0wyUFRPbjBpaDkyR25OYUREdVYwK1I5T3JORlBndWpRaDM1cWFr?=
 =?utf-8?B?b3Nrc0pjS090N054cWt2QldDM2hxb21rajhkTDJJdnkvdXNqa05wQStGWjNH?=
 =?utf-8?B?TW5WNVh0ZXhNVktSRXVKSFFJNmlMakNUbmdDcHBwSklvaVhhWUlKODRnUkg3?=
 =?utf-8?B?ZmR0K3BSY3RBU0V1VkhRay9ualp1SFZneG9oeVl0UVlPa2Y5V1BGSUVwVS9E?=
 =?utf-8?B?WUtINEZxQzRMWVc2eitjdnFVZVNDbUdkbGQrZk85UGlPMEVRUVBKVXkyL3Z0?=
 =?utf-8?B?WFphY25QSVk0c2k2T1hIM0FiMFdYQUtxZm1EYVpvSCtSQWE4WlNCQWcwUk81?=
 =?utf-8?B?Mk9hN2xjNlhyRkhQb2ZtN1JSQm50WkZ0aTVJQmVndHduK0s1OXNYZk5qN09u?=
 =?utf-8?B?VGMyRkJmanNtVXdIanUwUS9TeExJV1NPTnFydXZuRHZ5SXNTYTBJbzV3dFFM?=
 =?utf-8?B?VEo4a1BtZGcwVXMwdC9zZXNsdkpUN3ZyL0RxVGthc2RIWDhPTkdIeEpiVytz?=
 =?utf-8?B?NnRrUVgwWUl1dzJhZ213REhZOW5BeDc3SStKNXJLbU5hQmVsb2JtRVNzMHlv?=
 =?utf-8?B?RnVTMXpXZlhhc2VvbStYL2d0TE01ek9CT2M5ZkQ0MTZXUitUVEVGVmxJZVdR?=
 =?utf-8?B?RXZqM0R3WWFQR3hDME1WVGhMWnZodStiSDUwa3puZWNkd0MrSWo5alc2Zlpn?=
 =?utf-8?B?elVENDJVNVdHUkJkWTNGRTN4TTB3aTBYUTVWL0ptQjhIajN0VGJXbUVlYnhO?=
 =?utf-8?B?cWZYNXkzQWhIdXE0N3dCYnN0b3ZXcXFGS1ptSktRSGV6czBZV0o5bW9Sb0tq?=
 =?utf-8?B?TnFjOURNaHAxb04vSW9DSGtlYzUvdURYaWNrdzFKYkp5aGlLNTI3Zjlaaks2?=
 =?utf-8?B?QUhCRDJhbGlOUzhsSUFVa0ZVcjBOVTJTL251RFJLbk9GaXVSZ2QycjcxdGcz?=
 =?utf-8?B?Rldsa1l5VDdTdzZzakdMVEVHc0xndVYrZFBxckh2aG9mR0ZETTBQVlV4QS92?=
 =?utf-8?B?eGFCUGY3QmVESmFZY2VLOXpValZnVjJTVFBIWlV3YS9rZnlPTXJTVmdKQnlj?=
 =?utf-8?B?eHhCc1BmN0t2Nkp3UEI1RTFreURyV0dwUzlMeXY2QzRqUXU1NjNST2JpTHBM?=
 =?utf-8?B?aThRQUgreXdISjNpckxFbS9qREE0ZEhYby94TGFLYXl5RGQ0bCt1WXRqR05D?=
 =?utf-8?B?M1RjcngyMnRVdmR4TWZkMjMrdUFJTjVsTm5YVVVxZVFMektEblU5bkFuQVVP?=
 =?utf-8?B?dXRLa2UrWkZEMHp6NW4xY0RXelJRSm9FbU9yY3NyNDVyMVhTYXNrbk5BRUti?=
 =?utf-8?B?UUJmN2x5QVo4anhZN0s1VkJuMy9oK1JxMTdDNzY1cFRmVW4wRWlYb0JxclFt?=
 =?utf-8?B?UHQvQ0tEbVRvVUN3N0E0c1J5NVVBWXl6UTkrWk9rWnNBUEJoNXhkQkRkcm91?=
 =?utf-8?B?c2pkS2x3aHd1UGtEMkJoUytpU3NDcmswZ0RoalJQN29tWlM2Qy9vcENjU25i?=
 =?utf-8?Q?RkgjIsO0ccQkgPUTf9fC8uQDk?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eefeafca-5d38-4d5a-6a0d-08dc5eb464c7
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6309.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2024 08:00:06.1834
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uzUGprrUsfVt+zx/ECR2WICFbpcVEgdLrppkdXwiqTi5a/Kghf9fxj49qThpHqH/vc36AGPBXPM0UYN+b4VxwQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7575

On 4/17/2024 10:57 AM, Nikunj A. Dadhania wrote:
> On 4/16/2024 8:15 PM, Borislav Petkov wrote:
>> On Thu, Feb 15, 2024 at 05:01:17PM +0530, Nikunj A Dadhania wrote:
>>> +/* Secrets page physical address from the CC blob */
>>> +static u64 secrets_pa __ro_after_init;
>>
>> Since you're going to use this during runtime (are you?), 
> 
> Yes, this is used during runtime, during initial boot will be used by Secure TSC and later by sev-guest driver.
> 
>> why don't you put in here the result of:
>>
>> 	ioremap_encrypted(secrets_pa, PAGE_SIZE);
>>
>> so that you can have it ready and not even have to ioremap each time?
> 

> @@ -2118,6 +2083,14 @@ bool __init snp_init(struct boot_params *bp)
>  	if (!cc_info)
>  		return false;
>  
> +	if (cc_info->secrets_phys && cc_info->secrets_len == PAGE_SIZE) {
> +		secrets_page = ioremap_encrypted(cc_info->secrets_phys, PAGE_SIZE);

ioremap_encrypted() does not work this early, snp guest boot fails, will debug further.

Regards,
Nikunj