Received: by 2002:a05:6500:1b45:b0:1f5:f2ab:c469 with SMTP id cz5csp471941lqb; Wed, 17 Apr 2024 01:40:32 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUO3quwTU2AAcOhY69Vp6P1Ixg8gHKCKfTkb4EQ4UJYckS3z5Z8oXA80AZhVYCc2vmZV7IwB2lmKnEJFYDbzhmjqYQ72b1s26pwFtOsPA== X-Google-Smtp-Source: AGHT+IG8ldmkqEcYDLVWqD0vsGrIXjhpEAjB2BJJpQL8HiiXjWskKXhWgkM++zqD9yRn2ERlaB8z X-Received: by 2002:a9d:68d0:0:b0:6eb:7e60:6028 with SMTP id i16-20020a9d68d0000000b006eb7e606028mr8950680oto.30.1713343232456; Wed, 17 Apr 2024 01:40:32 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713343232; cv=pass; d=google.com; s=arc-20160816; b=Q+lD3IGtxwrXfLOU3Pg2CIPPW4qCDyq6L+HUbd2OyRdUuzN/nQXVHaq11ydyPVcPLi B9IqDQVJ5gNgDufYB3f1g9GSp7tfMKmweF8EMTwbhadi4WcMJrfGWVknpJgehox7q26Z PNvp1DGHPC3UQ5mhhkNxOoNEFHzVAp56vAQ24y/LNC5WEpGiYQUz8TOaRp79kGLH+gbT Ocpd38UzKXr2d/EpvHNuyJdUcVmY3/JpsNz6Db0SAYxe5a4SFD3l4/EWOtKegTbc1/4L jpHY/AfXgdF1PEN3DxB6E7L8BsRnCB0Oq+f96kPVTgyKbqPuiDtFtFoOFe9gsoh0GVf4 3Zxg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=pAaQ7cjzlK+Bm1UBVjas8I1zjPaGD885EjEZ6xg1Vrs=; fh=FB8jekzPk1tYp6HDSjFpwyxeHBQ0ZCQ1WzADxmL/pB8=; b=FDfZ7CscXcoPOLCfFUaF0KVGwnbkV0MlzE9jeDMHhqDRJnPAVnNEXsuAw/D7dv6zvq 8cb3QQH9TvAzEEzvlzUnf1891QYyr4PxEI4BeaGS6CvtRdu79e9vGGhXiIJobQ8cJ3ek uA/rIMoUV8hZ/hrm25dMCvtqdLDP4EGQhbSgvjDHxRVA8r5wx0zFwJeONaWmpjXhJ8jV 29mNhhyKtEubc9pUn5m2d+H0uU+cW2J7Fp1+WPiRMGGEAAlMV11pNs9YoaFjqRjBWd8j 5hzjiEUbXuffr0G5EgM3dILi5+Bz5O6OCneAZp+EDxcCvSySSmWR8H9zdLgnqNrrXnDG iiCw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=nfschina.com); spf=pass (google.com: domain of linux-kernel+bounces-148140-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-148140-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id a21-20020a634d15000000b005dbcf612461si11308448pgb.416.2024.04.17.01.40.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Apr 2024 01:40:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-148140-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=nfschina.com); spf=pass (google.com: domain of linux-kernel+bounces-148140-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-148140-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 6790EB22E94 for ; Wed, 17 Apr 2024 08:28:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 02EA680626; Wed, 17 Apr 2024 08:27:53 +0000 (UTC) Received: from mail.nfschina.com (unknown [42.101.60.195]) by smtp.subspace.kernel.org (Postfix) with SMTP id 88FF36CDA8; Wed, 17 Apr 2024 08:27:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=42.101.60.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713342472; cv=none; b=JSK+vNlQWvp2Mkvj/H3ChGucSEIDh63A52k2+Ac/wWczdoMhjfJZHLB3USI/kAqFzfk7k5xOGcwd4U/wkvikQL6ulPfZ32yH4RJf91ssu2mZ92jPR9NW7SM3/NDzVhVFKaVGRajsKykhnyEHSJ+spkDQcOvzxvIx48S9/eFEWec= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713342472; c=relaxed/simple; bh=CtQMNvV+gUrG6qOniXmLWrED15xV7xKGBBCUUCjRea8=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=HXh+V65edHhGcMu9QH448WEVtVMgkUdzm/oE720BmTqMYNGN7ekJe9nMLZzxNkDvRhbXbosEzRgLYZRZANV6j+69DO6p4LHvqDVXR5OOMk3co4jQU4fLLl0tCuVdQVGPcBQ6CcgGfMSSdwGn3xcOgc67voXa4p02uUYq7VYVBhQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nfschina.com; spf=pass smtp.mailfrom=nfschina.com; arc=none smtp.client-ip=42.101.60.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nfschina.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nfschina.com Received: from localhost.localdomain (unknown [180.167.10.98]) by mail.nfschina.com (Maildata Gateway V2.8.8) with ESMTPSA id 8304B6061879B; Wed, 17 Apr 2024 16:27:30 +0800 (CST) X-MD-Sfrom: suhui@nfschina.com X-MD-SrcIP: 180.167.10.98 From: Su Hui To: njavali@marvell.com, GR-QLogic-Storage-Upstream@marvell.com, jejb@linux.ibm.com, martin.petersen@oracle.com, nathan@kernel.org, ndesaulniers@google.com, morbo@google.com, justinstitt@google.com Cc: Su Hui , rhicksted@marvell.com, hare@suse.de, himanshu.madhani@oracle.com, qutran@marvell.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, kernel-janitors@vger.kernel.org Subject: [PATCH] scsi: qla2xxx: edif: Fix an error code problem in qla24xx_sadb_update() Date: Wed, 17 Apr 2024 16:27:01 +0800 Message-Id: <20240417082700.2238557-1-suhui@nfschina.com> X-Mailer: git-send-email 2.30.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Clang Static Checker (scan-build) Warning: drivers/scsi/qla2xxx/qla_edif.c:line 1568, column 3 Value stored to 'rval' is never read. Return the error code rather than zero to dismiss this warning. Fixes: dd30706e73b7 ("scsi: qla2xxx: edif: Add key update") Signed-off-by: Su Hui --- drivers/scsi/qla2xxx/qla_edif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_edif.c b/drivers/scsi/qla2xxx/qla_edif.c index dcde55c8ee5d..6f1aac36a144 100644 --- a/drivers/scsi/qla2xxx/qla_edif.c +++ b/drivers/scsi/qla2xxx/qla_edif.c @@ -1836,7 +1836,7 @@ qla24xx_sadb_update(struct bsg_job *bsg_job) bsg_job_done(bsg_job, bsg_reply->result, bsg_reply->reply_payload_rcv_len); - return 0; + return rval; } static void -- 2.30.2