Received-SPF: pass (google.com: domain of linux-kernel+bounces-148243-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 17 Apr 2024 17:34:44 +0800
From: Inochi Amaoto <inochiama@outlook.com>
To: michael.opdenacker@bootlin.com, Rob Herring <robh@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Chen Wang <unicorn_wang@outlook.com>, Inochi Amaoto <inochiama@outlook.com>, 
	Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, 
	Albert Ou <aou@eecs.berkeley.edu>
Cc: devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, 
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/2] riscv: dts: sophgo: add initial Milk-V Duo S
 board support
Message-ID:
 <IA1PR20MB49539A380E44459ACE19DEB6BB0F2@IA1PR20MB4953.namprd20.prod.outlook.com>
References: <20240417065311.3881023-1-michael.opdenacker@bootlin.com>
 <20240417065311.3881023-3-michael.opdenacker@bootlin.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240417065311.3881023-3-michael.opdenacker@bootlin.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: IA1PR20MB4953:EE_|LV8PR20MB7291:EE_
X-MS-Office365-Filtering-Correlation-Id: eb2929bd-97f1-4f3a-87e8-08dc5ec18fc2
X-MS-Exchange-SLBlob-MailProps:
	O8uo9vZ0QHVDqkOSoPIz5M4S+SNCRCoczudaXIXvZARoSselLtDteamBMRpJpUrcWwOznszVsQ8PXKplet5AmHrTWR4PoIJ6pzUQfd9ZrSjiHcU+cibdITSP/YzmEzqBftJ8wtlAy4JpJpxNluj1r0L0pS2UiBrL3e7aa3kKNOgqYlEFzn0IzXdzqNTqIDB5AFNL3JxgK/IYi8S9YVzWKrY5LkC8jy1FHoXKJ87WQQqS92JIgjSgp6Da0JfWxoBvV6QbwV/+v3O//cza8X/O3h8aN1W6BF4HZUuNsBqeSih62AE8orw9bEgwmEhmJwHOMASlIELXurDiGZgYP+5NtpLXIG5AoYqDpMOGWHUoMRVGTMBPE9SD7s6u0WjPb2d9CFf2xffpeO9KBpcE63AVRQBA4kgzfLRPsvMYDgiuKU2f8cKl7U4tlHMOGRN5klH6vZAzeivdhefFtCcmkJ/mXb3UKOvZDewcI9kgglHpeljMUUW+hlkUmAp/PT1wMPtd9KBnvmvJEMOh4DTfkPeYHAtJ2+AuLjqBfdeK5Ck/HXWZTmswOPVTHC7O8mtMXbSgMevdOTfMZDLjEkWiFtz/zc4qq0bsdC/PLq+7OflF6NaeiX1K/GpO/kqjRLTqpLLqp4hP1qQS+Pe3BidL28XWbIBnwZZjSbgkAirnzojx04MdMKn4xlKzRboN/bMk7wFcAUSQHmixnAGM3SSmmOzmwhxEuK74kMJeD1dTs5QVURk4tS7TLEy/SWAW9MLn2+2jEUBjkJU8IiftTphpmZwZ2u9UG9zEAqhaWhV/fpd/tc9Opro6GdxvkiboHr/i/GQdcIP3ahnCqe8oEYqZ/qURlKP/1/NKl7jb3JnQ718CTGDa75sUUipe1XOEqUaBOMGJTj3Ebve5L2F4kkSuz+HDpQ==
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	kX+ubGFjd7lMpWr4AlAfq98nNpKi7WBj7Gu3pvVR9CvUbl8wHIEu5DGs7utLwyzeUq2kIOMl2GkCuvmbyBixj2fMdLsFpk6YZr516c0KYojv2uWqO88N0FbA7xZbhpMQfYcVMZsTeoP117QufnE76e3SYD1MO7qz7AhTavpbsa/WU0XCH/PuzsCwKJLwnY6XfNJDG6hMSOWhG5XHpkjB5l3Y5w5hhC8vzkiIcvgyZlyTwhr6oj8ltqwdDYSG1CCV8hwgZ4Lap+FjvYrNgFJjiTw0UECH64PdeeKGGX9HdahM3ZnoYQS3Ho6NvHlERvJlrr2KjMSujiSNRd0Kt9WcLd/2o1X7l5sDWAc8arwe10C2RTl9JAQes7Bk5ENnxO7+lV4+h9P1R8tMsnaoQOzpf+w2XfLiaLXNCXPVuG+qglsuKjYMEomx8jZCt2wCsbgMkKVPR1JH24kJrcQSbDXk5NF2w1lCTwppdag4xYrqHoPsGjPNQ2ejs+KcYnCLdhllcMAh4h8QfH2aqwUMDMe21oE3iQHCUKiQcoHpdW22JaqhiQcZ1e2dxdqzffeyYstMZEEG3LHrZsYHuEm7pPRHc6yzx3Yt9c7wHT/nsxPgiWYmGFGkXNXqmuymrYhsIyALlr7FZ3W+ftf/Fg9+rKtD2MqYPEtHFNqZA/HSzlHw+64kult+kaPUqatuu4bIClo8TVXlDQoR9XTyX/5ytWSnvg==
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?kc1jkS5I1YXgIWQPTuAfjNn/9xCh5y2ZjrwBrxCO7kDy5rZRCCFmhoxhgJiF?=
 =?us-ascii?Q?5nME4tUKURCZHSacfyk9h5i5Nq4qUDZOaXxU+koCvN8tWDSzAZFtW09qzY83?=
 =?us-ascii?Q?0QkpX7DuqvkEZocXI7KGtCkloVteEpMbzL5EjqkckxLc0k8tns8NmcQInGFE?=
 =?us-ascii?Q?7QGUoIM77cOshUYXhuw31NyXHVqu7Xkk4jP68tnsUiuwwrmJDgJqakkP5FEU?=
 =?us-ascii?Q?rfuFw7VCZ5OWOZBdSkzVJlKjohY9iuDcjmZ3E3jZmnVqvsHLgXRAr/cJcL/L?=
 =?us-ascii?Q?rJk2p+s4JdiG+5N1lmuVgD3d5+Kjakqqj0Z0KODJCc7s8KKj9p9JjuuR671+?=
 =?us-ascii?Q?19Ds6XF3ZiCFU4i4FMC88njfOpZRAapj6VTghlZZz5DXxmsj2sLdUpMmLagp?=
 =?us-ascii?Q?u19+VlJWref8gE6B/D2zED7Sj2xwxxFZmPxL0n8nbCZH6pnxKC6/hSq5hHdL?=
 =?us-ascii?Q?7IKbKlWTObvNls3mtvOXVtAJaU/UofSrpMrOgY6l9WIUrhXZr0QWeboktFxJ?=
 =?us-ascii?Q?5ObQMBTO7PUaADBUhJF7Rl+QJUrlXYl4iNba5RWxgvDJjsKR6aGfLZYafdd3?=
 =?us-ascii?Q?q0CZ0vhC4Nt0ZN+vBXaSFSZcre5GOrHnCYH4nM5pbP2wxgfo+HjrVvOVwmu4?=
 =?us-ascii?Q?/xeuTStLYu8MY5mfo8zF/zvXRRuYzLfdNj6XxiG/H5ijKAYzGl2wohV6lAtS?=
 =?us-ascii?Q?gJrLc9qPyLgA1eeZBXi2hF3Qn+hHU9X7OsGOHXxiCvK8jClInfKEThhT5kYp?=
 =?us-ascii?Q?8ea1gB/lM7mVvdQiAlwjAA6sPQlFJxYbO7/G0zdgCAGH+QUCTM+Qr5wdKsNX?=
 =?us-ascii?Q?69eRUzmA36mvCaZNOfPY8Id6L5n+vyvCJojvSgP2DjGFDJgfFcCMAFECIy1e?=
 =?us-ascii?Q?SXrAayuEru1873vFy5JiLcpYzeOS9nKUY36jnDl8lYD4S/n6MNfwi8qpvmro?=
 =?us-ascii?Q?C4Pu5oESva/le+4wokdk218Y5OF4ptIBg1IXyyZMlI1Lra00Jzb+nIVY8HbF?=
 =?us-ascii?Q?19A5nhR75GLA6w8zGyOwNdtwnR0QOLQCpOiG5SF3JW2iMx5g9eTbftxuLiUZ?=
 =?us-ascii?Q?UYhzhvQI3SWbcl80l8ZbCHCjk0JDyWQ0kQs5Coojc1mEdSsXxbb3On2yhRzU?=
 =?us-ascii?Q?DIGxnjkeGgt3kcYlexZeB6FY/6W5XarYRhIQksOelipthxmaFrm9BqNnmDkk?=
 =?us-ascii?Q?AhshGVzmrzh3UadL8CAnt7RAy8mzMS3r2xtLTpze8Q5Lj0U0LswPixeFsDau?=
 =?us-ascii?Q?HNpPtQhRcHPTSeScOEfG?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eb2929bd-97f1-4f3a-87e8-08dc5ec18fc2
X-MS-Exchange-CrossTenant-AuthSource: IA1PR20MB4953.namprd20.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2024 09:34:21.4868
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR20MB7291

On Wed, Apr 17, 2024 at 08:53:11AM GMT, michael.opdenacker@bootlin.com wrote:
> From: Michael Opdenacker <michael.opdenacker@bootlin.com>
> 
> This adds initial support for the Milk-V Duo S board
> (https://milkv.io/duo-s), enabling the serial port,
> making it possible to boot Linux to the command line.
> 
> Link: https://lore.kernel.org/linux-riscv/171266958507.1032617.9460749136730849811.robh@kernel.org/T/#t
> 
> Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
> ---
>  arch/riscv/boot/dts/sophgo/Makefile           |  1 +
>  .../boot/dts/sophgo/sg2000-milkv-duos.dts     | 34 +++++++++++++++++++
>  2 files changed, 35 insertions(+)
>  create mode 100644 arch/riscv/boot/dts/sophgo/sg2000-milkv-duos.dts
> 
> diff --git a/arch/riscv/boot/dts/sophgo/Makefile b/arch/riscv/boot/dts/sophgo/Makefile
> index 57ad82a61ea6..e008acb5240f 100644
> --- a/arch/riscv/boot/dts/sophgo/Makefile
> +++ b/arch/riscv/boot/dts/sophgo/Makefile
> @@ -1,4 +1,5 @@
>  # SPDX-License-Identifier: GPL-2.0
>  dtb-$(CONFIG_ARCH_SOPHGO) += cv1800b-milkv-duo.dtb
>  dtb-$(CONFIG_ARCH_SOPHGO) += cv1812h-huashan-pi.dtb
> +dtb-$(CONFIG_ARCH_SOPHGO) += sg2000-milkv-duos.dtb
>  dtb-$(CONFIG_ARCH_SOPHGO) += sg2042-milkv-pioneer.dtb
> diff --git a/arch/riscv/boot/dts/sophgo/sg2000-milkv-duos.dts b/arch/riscv/boot/dts/sophgo/sg2000-milkv-duos.dts
> new file mode 100644
> index 000000000000..c1ecf97d5e93
> --- /dev/null
> +++ b/arch/riscv/boot/dts/sophgo/sg2000-milkv-duos.dts
> @@ -0,0 +1,34 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +/*
> + * Copyright (C) 2024 Michael Opdenacker <michael.opdenacker@bootlin.com>
> + */
> +
> +/dts-v1/;
> +
> +#include "cv1812h.dtsi"
> +
> +/ {
> +	model = "Milk-V Duo S";
> +	compatible = "milkv,duos", "sophgo,cv1812h";
> +
> +	aliases {
> +		serial0 = &uart0;
> +	};
> +
> +	chosen {
> +		stdout-path = "serial0:115200n8";
> +	};
> +
> +	memory@80000000 {
> +		device_type = "memory";
> +		reg = <0x80000000 0x20000000>;
> +	};

Add a cpu specific file, and move this to it.

> +};
> +
> +&osc {
> +	clock-frequency = <25000000>;
> +};
> +
> +&uart0 {
> +	status = "okay";
> +};
> -- 
> 2.34.1
> 

Add necessary DT node in the cpu specific file. (clint, 
plic and clk). You also need to rebase your patch based
on sophgo/for-next.