Received-SPF: pass (google.com: domain of linux-kernel+bounces-148288-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Wed, 17 Apr 2024 06:05:37 -0400
From: Kent Overstreet <kent.overstreet@linux.dev>
To: Hongbo Li <lihongbo22@huawei.com>
Cc: Youling Tang <youling.tang@linux.dev>, linux-bcachefs@vger.kernel.org, 
	linux-kernel@vger.kernel.org, Youling Tang <tangyouling@kylinos.cn>
Subject: Re: [PATCH] bcachefs: Align the display format of
 `btrees/inodes/keys`
Message-ID: <fihmieyqam3ubckmmjlcrsjucahc3yb6m24sjt34cpsw6zii6i@n4atsknjqmkv>
References: <20240417015448.84294-1-youling.tang@linux.dev>
 <toosz4pt2la6wf2575vwe6efebcbzsy735cq7exmlqhzrgicrf@s7g3rrbvge2l>
 <66ecea56-e4d3-4241-a1dc-378d70555321@linux.dev>
 <fpvnushjgr5txyduvpihevvghv64sdso4p6t3nhhddcjimqh2k@ehzpswsmnxin>
 <d17de3df-a3f2-4317-92cc-1fd02641328b@huawei.com>
 <29d5ea19-21b5-4076-9acc-8286a050c33f@huawei.com>
 <63d9540f-61bc-4eba-819c-c05d2e486bdb@linux.dev>
 <72e1b795-7219-41dd-83f2-10a3be2680b2@huawei.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <72e1b795-7219-41dd-83f2-10a3be2680b2@huawei.com>

On Wed, Apr 17, 2024 at 05:49:41PM +0800, Hongbo Li wrote:
> 
> 
> On 2024/4/17 13:51, Youling Tang wrote:
> > Hi, Kent & Hongbo
> > On 17/04/2024 11:21, Hongbo Li wrote:
> > > 
> > > 
> > > On 2024/4/17 11:16, Hongbo Li wrote:
> > > > 
> > > > 
> > > > On 2024/4/17 10:59, Kent Overstreet wrote:
> > > > > On Wed, Apr 17, 2024 at 10:50:10AM +0800, Youling Tang wrote:
> > > > > > Hi, Kent
> > > > > > On 17/04/2024 10:20, Kent Overstreet wrote:
> > > > > > > On Wed, Apr 17, 2024 at 09:54:48AM +0800, Youling Tang wrote:
> > > > > > > > From: Youling Tang <tangyouling@kylinos.cn>
> > > > > > > > 
> > > > > > > > Before patch:
> > > > > > > > ```
> > > > > > > >    #cat btrees/inodes/keys
> > > > > > > >    u64s 17 type inode_v3 0:4096:U32_MAX len 0 ver 0: mode=40755
> > > > > > > >      flags= (16300000)
> > > > > > > > ```
> > > > > > > > 
> > > > > > > > After patch:
> > > > > > > > ```
> > > > > > > >    #cat btrees/inodes/keys
> > > > > > > >    u64s 17 type inode_v3 0:4096:U32_MAX len 0 ver 0:
> > > > > > > >      mode=40755
> > > > > > > >      flags= (16300000)
> > > > The flags also with the space after "=". Is it reseonable?
> > > Sorry, I misspell. I mean whether it is reasonable.
> > > > > > > This would print a newline for keys that don't have a value...
> > > > > > The original intention was to make the display of the
> > > > > > printed content in
> > > > > > '__bch2_inode_unpacked_to_text ()' consistent, without
> > > > > > considering other
> > > > > > callbacks.
> > > > > > 
> > > > > > Or just modify it in the following way?
> > > > > 
> > > > > Yeah, that's better
> > > > > 
> > > > > Do it off my master branch though, there's some printbuf
> > > > > imprevements in
> > > > > there.
> > > > > 
> > > > > https://evilpiepirate.org/git/bcachefs.git
> > I will make the following changes based on the master branch,
> > 
> > --- a/fs/bcachefs/inode.c
> > 
> > +++ b/fs/bcachefs/inode.c
> > @@ -534,12 +534,13 @@ int bch2_inode_v3_invalid(struct bch_fs *c, struct
> > bkey_s_c k,
> >   static void __bch2_inode_unpacked_to_text(struct printbuf *out,
> >                                            struct bch_inode_unpacked
> > *inode)
> >   {
> > +       prt_printf(out, "\n");
> >          printbuf_indent_add(out, 2);
> >          prt_printf(out, "mode=%o\n", inode->bi_mode);
> > 
> >          prt_str(out, "flags=");
> >          prt_bitflags(out, bch2_inode_flag_strs, inode->bi_flags & ((1U
> > << 20) - 1));
> > -       prt_printf(out, " (%x)\n", inode->bi_flags);
> > +       prt_printf(out, "(%x)\n", inode->bi_flags);
> I think it's ok. Maybe use prt_newline(out) is better than prt_printf(out,
> "\n");

prt_printf("\n") is the same as prt_newline() now