Received-SPF: pass (google.com: domain of linux-kernel+bounces-148312-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <5c1ef62610506524763bc2d4f673279e0cb624b6.camel@linux.ibm.com>
Subject: Re: [PATCH net-next v6 02/11] net/smc: introduce loopback-ism for
 SMC intra-OS shortcut
From: Gerd Bayer <gbayer@linux.ibm.com>
To: Wen Gu <guwen@linux.alibaba.com>, wintera@linux.ibm.com,
        twinkler@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com,
        agordeev@linux.ibm.com, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, wenjia@linux.ibm.com,
        jaka@linux.ibm.com
Cc: borntraeger@linux.ibm.com, svens@linux.ibm.com, alibuda@linux.alibaba.com,
        tonylu@linux.alibaba.com, linux-kernel@vger.kernel.org,
        linux-s390@vger.kernel.org, netdev@vger.kernel.org
Date: Wed, 17 Apr 2024 12:20:06 +0200
In-Reply-To: <20240414040304.54255-3-guwen@linux.alibaba.com>
References: <20240414040304.54255-1-guwen@linux.alibaba.com>
	 <20240414040304.54255-3-guwen@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-2.fc39app4) 
Precedence: bulk
MIME-Version: 1.0

On Sun, 2024-04-14 at 12:02 +0800, Wen Gu wrote:
> This introduces a kind of Emulated-ISM device named loopback-ism for
> SMCv2.1. The loopback-ism device is currently exclusive for SMC
> usage, and aims to provide an SMC shortcut for sockets within the
> same kernel, leading to improved intra-OS traffic performance.
> Configuration of this feature is managed through the config SMC_LO.
>=20
> Signed-off-by: Wen Gu <guwen@linux.alibaba.com>
> ---
> =C2=A0net/smc/Kconfig=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 1=
3 ++++
> =C2=A0net/smc/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 =
1 +
> =C2=A0net/smc/af_smc.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 12 +++=
-
> =C2=A0net/smc/smc_loopback.c | 156
> +++++++++++++++++++++++++++++++++++++++++
> =C2=A0net/smc/smc_loopback.h |=C2=A0 43 ++++++++++++
> =C2=A05 files changed, 224 insertions(+), 1 deletion(-)
> =C2=A0create mode 100644 net/smc/smc_loopback.c
> =C2=A0create mode 100644 net/smc/smc_loopback.h
>=20

Thanks Wen Gu,

this looks good to me now. A W=3D1 compile-test of the whole series with
SMC_LO undefined showed that there were no additional unresolved
symbols introduced.

Feel free to add my
Reviewed-by: Gerd Bayer <gbayer@linux.ibm.com>