Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753971AbYAYBIc (ORCPT ); Thu, 24 Jan 2008 20:08:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751508AbYAYBIW (ORCPT ); Thu, 24 Jan 2008 20:08:22 -0500 Received: from mx1.redhat.com ([66.187.233.31]:42296 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751498AbYAYBIV (ORCPT ); Thu, 24 Jan 2008 20:08:21 -0500 Message-ID: <47993673.7040408@redhat.com> Date: Thu, 24 Jan 2008 20:08:03 -0500 From: Chris Snook User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Jay Cliburn CC: Jeff Garzik , linux-kernel@vger.kernel.org, atl1-devel@lists.sourceforge.net, netdev@vger.kernel.org Subject: Re: [PATCH 09/26] atl1: refactor tx processing References: <1199152804-3889-1-git-send-email-jacliburn@bellsouth.net> <1199152804-3889-10-git-send-email-jacliburn@bellsouth.net> <4795BE39.6000505@garzik.org> <20080122183109.5ab80802@osprey.hogchain.net> <20080124190024.1b81238e@osprey.hogchain.net> In-Reply-To: <20080124190024.1b81238e@osprey.hogchain.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1768 Lines: 41 Jay Cliburn wrote: > On Tue, 22 Jan 2008 18:31:09 -0600 > Jay Cliburn wrote: > >> On Tue, 22 Jan 2008 04:58:17 -0500 >> Jeff Garzik wrote: >> > [...] >>> for such a huge patch, this description is very tiny. [describe] >>> what is refactored, and why. > > Is this one any better? This satisfies me. Acked-by: Chris Snook > From df475e2eea401f9dc18ca23dab538b99fb9e710c Mon Sep 17 00:00:00 2001 > From: Jay Cliburn > Date: Wed, 23 Jan 2008 21:36:36 -0600 > Subject: [PATCH] atl1: simplify tx packet descriptor > > The transmit packet descriptor consists of four 32-bit words, with word 3 > upper bits overloaded depending upon the condition of its bits 3 and 4. > The driver currently duplicates all word 2 and some word 3 register bit > definitions unnecessarily and also uses a set of nested structures in its > definition of the TPD without good cause. This patch adds a lengthy > comment describing the TPD, eliminates duplicate TPD bit definitions, > and simplifies the TPD structure itself. It also expands the TSO check > to correctly handle custom checksum versus TSO processing using the revised > TPD definitions. Finally, shorten some variable names in the transmit > processing path to reduce line lengths, rename some variables to better > describe their purpose (e.g., nseg versus m), and add a comment or two > to better describe what the code is doing. > > Signed-off-by: Jay Cliburn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/