Received-SPF: pass (google.com: domain of linux-kernel+bounces-148348-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 17 Apr 2024 13:46:42 +0300
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Arnd Bergmann <arnd@arndb.de>, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [rfc, PATCH v1 1/1] gpiolib: Get rid of never false
 gpio_is_valid() calls
Message-ID: <Zh-oku-XzpcH_8FH@smile.fi.intel.com>
References: <20240221213208.17914-1-andriy.shevchenko@linux.intel.com>
 <CAMRc=Mfh-ojboNUELXfszKUbZRfeZn9vsN-HMTdMQv6my6ZrdQ@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAMRc=Mfh-ojboNUELXfszKUbZRfeZn9vsN-HMTdMQv6my6ZrdQ@mail.gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Tue, Feb 27, 2024 at 02:06:05PM +0100, Bartosz Golaszewski wrote:
> On Wed, Feb 21, 2024 at 10:32 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > In the cases when gpio_is_valid() is called with unsigned parameter
> > the result is always true in the GPIO library code, hence the check
> > for false won't ever be true. Get rid of such calls.
> >
> > While at it, move GPIO device base to be unsigned to clearly show
> > it won't ever be negative. This requires a new definition for the
> > maximum GPIO number in the system.

> > ---
> 
> It looks like a risky change that late in the release cycle. I want to
> avoid some CI problems at rc6. Please resend it once v6.9-rc1 is
> tagged.

Not sure why resend, but I missed that somehow. Can you consider applying it?

-- 
With Best Regards,
Andy Shevchenko