Received-SPF: pass (google.com: domain of linux-kernel+bounces-148353-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <39905c50-a228-4e85-a5de-3b10cae5f2bc@arm.com>
Date: Wed, 17 Apr 2024 11:53:09 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v7 1/3] mm/madvise: introduce clear_young_dirty_ptes()
 batch helper
Content-Language: en-GB
To: Lance Yang <ioworker0@gmail.com>, David Hildenbrand <david@redhat.com>
Cc: 21cnbao@gmail.com, akpm@linux-foundation.org, fengwei.yin@intel.com,
 linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.com,
 minchan@kernel.org, peterx@redhat.com, shy828301@gmail.com,
 songmuchun@bytedance.com, wangkefeng.wang@huawei.com, xiehuan09@gmail.com,
 zokeefe@google.com
References: <CAK1f24mEoC_Pg7-49G=y7dMUaGhzW11_A5sK0EWVhH6K1kjMMA@mail.gmail.com>
 <20240417050426.66194-1-ioworker0@gmail.com>
 <76d22c08-82db-4ea8-a7cd-c77589e132e3@redhat.com>
 <CAK1f24mFfwXky9Patwmcq-VQ8y1hxcRm8K4B4o0RO+dsr-7Q=A@mail.gmail.com>
From: Ryan Roberts <ryan.roberts@arm.com>
In-Reply-To: <CAK1f24mFfwXky9Patwmcq-VQ8y1hxcRm8K4B4o0RO+dsr-7Q=A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 17/04/2024 10:01, Lance Yang wrote:
> On Wed, Apr 17, 2024 at 4:19 PM David Hildenbrand <david@redhat.com> wrote:
>>
>> On 17.04.24 07:04, Lance Yang wrote:
>>> Hey David, Ryan,
>>>
>>> How about this change?
>>>
>>> static inline void clear_young_dirty_ptes(struct vm_area_struct *vma,
>>>                                         unsigned long addr, pte_t *ptep,
>>>                                         unsigned int nr, cydp_t flags)
>>> {
>>>       if (flags == CYDP_CLEAR_YOUNG) {
>>>               for (;;) {
>>>                       ptep_test_and_clear_young(vma, addr, ptep);
>>>                       if (--nr == 0)
>>>                               break;
>>>                       ptep++;
>>>                       addr += PAGE_SIZE;
>>>               }
>>>               return;
>>>       }
>>>
>>>       pte_t pte;
>>>
>>>       for (;;) {
>>>               pte = ptep_get_and_clear(vma->vm_mm, addr, ptep);
>>>
>>>               if (flags & CYDP_CLEAR_YOUNG)
>>>                       pte = pte_mkold(pte);
>>>               if (flags & CYDP_CLEAR_DIRTY)
>>>                       pte = pte_mkclean(pte);
>>>
>>>               if (--nr == 0)
>>>                       break;
>>>               ptep++;
>>>               addr += PAGE_SIZE;
>>>       }
>>> }
>>
>> Likely it might be best to just KIS for now and leave it as is. The
>> compiler should optimize out based on flags already, that's what I ignored.
> 
> Got it. Let's keep it as is for now :)

Yep agreed; you're passing the flags as constants so the compiler should be
completely removing one half of the conditional. And if the input isn't a
constant, I'd still expect the compiler to hoist the conditional out of the loop.

> 
> Thanks,
> Lance
> 
>>
>> --
>> Cheers,
>>
>> David / dhildenb
>>