Received-SPF: pass (google.com: domain of linux-kernel+bounces-148385-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 17 Apr 2024 06:14:35 -0500
From: Bjorn Helgaas <helgaas@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Frank Li <Frank.Li@nxp.com>, Bjorn Helgaas <bhelgaas@google.com>,
	Jingoo Han <jingoohan1@gmail.com>,
	Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, imx@lists.linux.dev,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v6 4/5] PCI: Add PCIE_MSG_CODE_PME_TURN_OFF message macro
Message-ID: <20240417111435.GA187921@bhelgaas>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240417075655.GF3894@thinkpad>

On Wed, Apr 17, 2024 at 01:26:55PM +0530, Manivannan Sadhasivam wrote:
> On Tue, Apr 16, 2024 at 12:02:42PM -0500, Bjorn Helgaas wrote:
> > On Mon, Apr 15, 2024 at 03:33:28PM -0400, Frank Li wrote:
> > > Add PCIE_MSG_CODE_PME_TURN_OFF macros to enable a PCIe host driver to send
> > > PME_Turn_Off messages.
> > > 
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > ---
> > >  drivers/pci/pci.h | 2 ++
> > >  1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
> > > index 19b4227a8a7e8..1f6d54a5a7cfc 100644
> > > --- a/drivers/pci/pci.h
> > > +++ b/drivers/pci/pci.h
> > > @@ -30,6 +30,8 @@
> > >  #define PCIE_MSG_TYPE_R_LOCAL	4
> > >  #define PCIE_MSG_TYPE_R_GATHER	5
> > >  
> > > +#define PCIE_MSG_CODE_PME_TURN_OFF	0x19
> > 
> > This is defined in PCIe r6.0, sec 2.2.8.2, so move this below the INTx
> > #defines so they're all in the order of the spec sections and add the
> 
> I think it was me who suggested moving this up to keep it sorted in ascending
> order :/

OK, the order you suggested is fine.

> > spec citation to follow the same style as the surrounding #defines,
> > i.e.,
> > 
> >   /* Power Management Messages; PCIe r6.0, sec 2.2.8.2 */
> >   #define PCIE_MSG_CODE_PME_TURN_OFF   0x19
> > 
> > While you're at it, tweak the [1/5] comments to be:
> > 
> >   /* Message Routing (r[2:0]); PCIe r6.0, sec 2.2.8 */
> >   /* INTx Mechanism Messages; PCIe r6.0, sec 2.2.8.1 */
> > 
> > since the "Message Routing See: PCIe ..." comments are run together
> > and need some punctuation between the text and the citation.

But please do add and tweak the comments.

> > With these,
> > 
> > Acked-by: Bjorn Helgaas <bhelgaas@google.com>

Still fine to add this :)

> > >  /* INTx Mechanism Messages See: PCIe r6.0, sec 2.2.8.1 */
> > >  #define PCIE_MSG_CODE_ASSERT_INTA	0x20
> > >  #define PCIE_MSG_CODE_ASSERT_INTB	0x21
> > > 
> > > -- 
> > > 2.34.1
> > > 
> 
> -- 
> மணிவண்ணன் சதாசிவம்