Received-SPF: pass (google.com: domain of linux-kernel+bounces-148380-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 17 Apr 2024 19:12:42 +0800
From: Inochi Amaoto <inochiama@outlook.com>
To: Arnd Bergmann <arnd@kernel.org>, 
	Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, 
	Chen Wang <unicorn_wang@outlook.com>, Inochi Amaoto <inochiama@outlook.com>
Cc: Arnd Bergmann <arnd@arndb.de>, linux-clk@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: sophgo: avoid open-coded 64-bit division
Message-ID:
 <IA1PR20MB4953FA5F47CDD0BFF0E64557BB0F2@IA1PR20MB4953.namprd20.prod.outlook.com>
References: <20240415134532.3467817-1-arnd@kernel.org>
 <IA1PR20MB49532CE01992005D3DA0FD17BB092@IA1PR20MB4953.namprd20.prod.outlook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <IA1PR20MB49532CE01992005D3DA0FD17BB092@IA1PR20MB4953.namprd20.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: IA1PR20MB4953:EE_|PH8PR20MB5266:EE_
X-MS-Office365-Filtering-Correlation-Id: c6be3b4d-25b8-4bec-86e8-08dc5ecf3f40
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	bpFl4aHMndQIZaUcAYQ2w85MUMbvS1n/u+noRpIF/AeHDaVb6UOOZQj8pt4OCYQTDlckViabhxLXh7lPpjIoQLRtjzCkkJiNgGIppiUJZj3txXNTBuuzTDyu+e7aKzUTidw7AiCFGa632kYJYyChf/85OHaNc8KRZmk0W08VYRDXrsq3YaVNKdF5yhRJWksJmfbEAM0CYOcR/ZX4UHUjgpE2skA1IfRjcQUpgHqMPzQXHEi4kJmlcsagwbPa5DJz1CqKa3a3W+TPCPHlDcHMWjrG0eqe+AKxX2em6E9DKNlCbjoLoxeAoZg+cXSpR0WEnI8MtWA6/vSRzidTEfOd6u4NwVJI+TFLOQzKiCnqm5Ap0/RDJNY5TuKQkdOfFqeFneaQEERCY1uzaY2/gP1bmPNKkvdXAmBqpbBshrxLHO1WZ/UjRKLylpAOkX7DzmlDX79EsLsa08W173bo2p4xBew47FeeuA38rHzt+R7bypB/tKF5gpcbRnswA4K84bPB7yQM7dRZnm7pomMsr77pgeaZjX6xif8KUGFE/U//juXXWYrngt4fuIzhBaFdkFHjMg1gDnaHjZ77mt8FW9PYAYLr7aMcUO/Pe8RXjb6Mgi5UxqydRGYoJP2nvPeQS39AaIsJk4RnlK1KCCX0nyMgMi+96xlTnbYm0NDNcZNT463Hc5WK0yrt0S9F7jQFCFXJrMvtFrW+n8av/63iH61kPsvtsTT5POyNYKBsiQIzjmKwiK9RGVWNeUU8QZdBPKa/
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?y8abW5JFN5K8BsUZDbpyHZs33YFf23FpLH7eqHjYGcmt+7VmWR6sTxQOaWM8?=
 =?us-ascii?Q?2Ui35jbwxqPAoYmDHKkEQM0csNC+di6nwCEuGg7AgX2+sEKW4YL4wFL6nbss?=
 =?us-ascii?Q?IlDDqBEQZNSsb9ixaGDP1kzGuyN+V8V/4iKtReftX/VweLRG06GzrkbwnMh2?=
 =?us-ascii?Q?dHTSYuC3OwPm4HFLpk9y8+v0fjo1p/Ojuv8MsvhZnEY0h6jlNk39dtqzzd9t?=
 =?us-ascii?Q?FaeMaLfd4Kii1MTrjyuU9l0I6JuGRGvoMV7JM8ezB1Eke+RKHJ/1pqvAiGFO?=
 =?us-ascii?Q?4EeS8H1xydSkSQ92YgD2ktm1JmXapzP6X96x7lItUI0qqZEHwGff86/1Pel4?=
 =?us-ascii?Q?I9I9RRIBs7Krqdk3gnwt7Mm8qCioiJJJ3NLXBawTmHcvqSgrxhQjFHYG+WBM?=
 =?us-ascii?Q?h+dLi8h4MBCEAQqxVIE5+z/zm2fRKcwKlMXHRJfdLCDXEX4Egig55y/kyc7B?=
 =?us-ascii?Q?G3ZC8H+oYeGQYKffXUaQbGdtOIj6JXT2+C+fMD4cwcbw8+YC+oNQn7IlKwMB?=
 =?us-ascii?Q?Sn7RdSGtDrjQZ1puyGHNfSyRmrWaSFNj/ZZrOkgj+Yv3VCz/mVAM5X+es8EV?=
 =?us-ascii?Q?1QIobwibia/QTl5GuiS4nDHJzq04qmJ3RtfvQ3GUtbTNHLBI3yZl4Uo0rT9t?=
 =?us-ascii?Q?Wjwg6xbb48y1yhisWx/geGakosMdVmLS1EqGwcLh+C3Qq/3UhBZrNSdRUFT4?=
 =?us-ascii?Q?w5HU7Q01B3d7g0Qc/Ta3Os5BPqzTTbFhFK5zxOmpAcysHqXtpasXljKR9moQ?=
 =?us-ascii?Q?a+Fhl89R/m8SewtXaBKhEz1WdprUFuiykyvK3s10tKHtdVYXvm/kN4AeJTzz?=
 =?us-ascii?Q?MbnqdqknzwGbBCF8Fu/PnqUglv9Xwripc7h/VpMson/3hUEJDV0+B2bsumME?=
 =?us-ascii?Q?EZqddYLt+Cx2fwU49BDyd56YnqIHQ6ALzcoawhbbv0jjR82z+UKFHOLEMW92?=
 =?us-ascii?Q?ekN/4N+KHEbjUljrmvKlpBfyN3d7Qotb4QxTVaL3fIOW9/uvvxcSeWgb0eKP?=
 =?us-ascii?Q?j1aMOVF8yDx9aviv5DzbYDKfctEmiDIREZ7lKt0uO1k21iAfKtVouhv1lxmH?=
 =?us-ascii?Q?Y3L+sA0dk8OAwtQMUz8wn+XDjwj8ZKUJRCSvc+RlGvc0zTlb0BV8Szb/4TEC?=
 =?us-ascii?Q?glqzJraCVotm6aJBXsgAvzlfI1SY2Nda4JkGi20vr+WgMcg7/30LYRQQnwS5?=
 =?us-ascii?Q?2jteM+ZNSyq0l2GBTCNSvXd/UBN/ZKZ3TvXdMEbexJK6B7NvQ4SgrzeRE56u?=
 =?us-ascii?Q?xElKlGJVYpRg1QukiK17?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c6be3b4d-25b8-4bec-86e8-08dc5ecf3f40
X-MS-Exchange-CrossTenant-AuthSource: IA1PR20MB4953.namprd20.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2024 11:12:19.3810
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR20MB5266

On Tue, Apr 16, 2024 at 06:30:42AM GMT, Inochi Amaoto wrote:
> On Mon, Apr 15, 2024 at 03:45:20PM +0200, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> > 
> > On 32-bit architectures, the 64-bit division leads to a link failure:
> > 
> > arm-linux-gnueabi-ld: drivers/clk/sophgo/clk-cv18xx-pll.o: in function `fpll_calc_rate':
> > clk-cv18xx-pll.c:(.text.fpll_calc_rate+0x26): undefined reference to `__aeabi_uldivmod'
> > 
> > This one is not called in a fast path, and there is already another div_u64()
> > variant used in the same function, so convert it to div64_u64_rem().
> > 
> > Fixes: 80fd61ec4612 ("clk: sophgo: Add clock support for CV1800 SoC")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> There is already a fix patch:
> https://lore.kernel.org/all/IA1PR20MB4953CB4FCCDE82AB25F6880EBB0B2@IA1PR20MB4953.namprd20.prod.outlook.com/

Hi Arnd,

I have looked your patch again and think your patch is better
than mine. So I decided to drop my patch and favor yours.

LGTM. And there are some necessary tags.

Reviewed-by: Inochi Amaoto <inochiama@outlook.com>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202404122344.d5pb2N1I-lkp@intel.com/
Closes: https://lore.kernel.org/oe-kbuild-all/202404140310.QEjZKtTN-lkp@intel.com/